ByPid::execute() - Code Metrics - Inspection of "rpc over socket, more control of workers over daem..." - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 2f2bc4...95e7c3 )

by Marco

created 2018-01-07 22:51 UTC

ByPid::execute() B

↳ Parent: ByPid

Complexity

Conditions	2
Paths	2

Size

Total Lines	30
Code Lines	20

Duplication

Lines	30
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	30
loc	30
ccs	0
cts	24
cp	0
rs	8.8571
c	0
b	0
f	0
cc	2
eloc	20
nc	2
nop	2
crap	6

<?php namespace Comodojo\Extender\Socket\Commands\Worklog;

use \Comodojo\Daemon\Daemon;
use \Comodojo\RpcServer\Request\Parameters;
use \Comodojo\Extender\Worklog\Manager;
use \Comodojo\Extender\Socket\Messages\Worklog\Filter;
use \Comodojo\Extender\Transformers\WorklogTransformer;
use \League\Fractal\Manager as FractalManager;
use \League\Fractal\Resource\Collection;

class ByPid {


    public static function execute(Parameters $params, Daemon $daemon) {

        $pid = $params->get('pid');
        $filter = $params->get('filter');

        $manager = new Manager(
            $daemon->getConfiguration(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $daemon->getLogger(),
            $daemon->getEvents()
        );

        if ( empty($filter) ) {
            $data = $manager->get(['pid' => $pid]);
        } else {
            $f = Filter::createFromExport($filter);
            $data = $manager->get(
                ['pid' => $pid],
                $f->getLimit(),
                $f->getOffset(),
                $f->getReverse()
            );
        }

        $resource = new Collection($data, new WorklogTransformer);
        $fractal = new FractalManager();
        $data = $fractal->createData($resource)->toArray();

        return $data['data'];

    }

}


1		<?php namespace Comodojo\Extender\Socket\Commands\Worklog;
2
3		use \Comodojo\Daemon\Daemon;
4		use \Comodojo\RpcServer\Request\Parameters;
5		use \Comodojo\Extender\Worklog\Manager;
6		use \Comodojo\Extender\Socket\Messages\Worklog\Filter;
7		use \Comodojo\Extender\Transformers\WorklogTransformer;
8		use \League\Fractal\Manager as FractalManager;
9		use \League\Fractal\Resource\Collection;
10
11	View Code Duplication	class ByPid {
		0 ignored issues – show Duplication introduced 2018-01-07 23:26 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12
13		public static function execute(Parameters $params, Daemon $daemon) {
14
15		$pid = $params->get('pid');
16		$filter = $params->get('filter');
17
18		$manager = new Manager(
19		$daemon->getConfiguration(),
		0 ignored issues – show Bug introduced 2018-01-07 23:26 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Comodojo\Daemon\Daemon` as the method `getConfiguration()` does only exist in the following sub-classes of `Comodojo\Daemon\Daemon`: `Comodojo\Extender\ExtenderDaemon`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
20		$daemon->getLogger(),
21		$daemon->getEvents()
22		);
23
24		if ( empty($filter) ) {
25		$data = $manager->get(['pid' => $pid]);
26		} else {
27		$f = Filter::createFromExport($filter);
28		$data = $manager->get(
29		['pid' => $pid],
30		$f->getLimit(),
31		$f->getOffset(),
32		$f->getReverse()
33		);
34		}
35
36		$resource = new Collection($data, new WorklogTransformer);
37		$fractal = new FractalManager();
38		$data = $fractal->createData($resource)->toArray();
39
40		return $data['data'];
41
42		}
43
44		}
45

comodojo / extender.framework

Push — 2.0 ( 2f2bc4...95e7c3 )

ByPid::execute() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like