Inspection of "new database-cache property, add group to tests" - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 2829e8...896296 )

by Marco

created 2018-02-19 23:29 UTC

Status

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -34,14 +34,14 @@
 block discarded – undo
     use EventsTrait;
 
     /**
-    * Class constructor
-    *
-    * @param Configuration $configuration
-    * @param LoggerInterface $logger
-    * @param TasksTable $tasks
-    * @param EventsManager $events
-    * @param EntityManager $em
-    */
+     * Class constructor
+     *
+     * @param Configuration $configuration
+     * @param LoggerInterface $logger
+     * @param TasksTable $tasks
+     * @param EventsManager $events
+     * @param EntityManager $em
+     */
     public function __construct(
         Configuration $configuration,
         LoggerInterface $logger,

Please login to merge, or discard this patch.

src/Comodojo/Extender/Socket/SocketInjector.php 1 patch

Indentation +36 added lines, -36 removed lines patch added patch discarded remove patch

@@ -32,8 +32,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.refresh",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Refresh::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Refresh::execute',
+                    $daemon)
             ->setDescription("Refresh current scheduler's schedule")
             ->setReturnType('boolean')
         );
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.info",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Info::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Info::execute',
+                    $daemon)
             ->setDescription("Refresh current scheduler status")
             ->setReturnType('array')
         );
@@ -50,8 +50,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.add",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Add::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Add::execute',
+                    $daemon)
             ->setDescription("Set new schedule")
             ->addParameter('struct', 'schedule')
             ->addParameter('struct', 'request')
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.list",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\GetList::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\GetList::execute',
+                    $daemon)
             ->setDescription("List all installed schedules")
             ->setReturnType('array')
         );
@@ -70,8 +70,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.get",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Get::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Get::execute',
+                    $daemon)
             ->setDescription("Get a schedule and related task request by id (int) or name (string)")
             ->addParameter('int', 'id')
             ->setReturnType('array')
@@ -83,8 +83,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.edit",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Edit::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Edit::execute',
+                    $daemon)
             ->setDescription("Edit a schedule")
             ->addParameter('struct', 'schedule')
             ->addParameter('struct', 'request')
@@ -94,8 +94,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.disable",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Disable::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Disable::execute',
+                    $daemon)
             ->setDescription("Disable a schedule by id (int) or name (string)")
             ->addParameter('int', 'id')
             ->setReturnType('boolean')
@@ -107,8 +107,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.enable",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Enable::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Enable::execute',
+                    $daemon)
             ->setDescription("Enable a schedule by id (int) or name (string)")
             ->addParameter('int', 'id')
             ->setReturnType('boolean')
@@ -120,8 +120,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "scheduler.remove",
-                 'Comodojo\Extender\Socket\Commands\Scheduler\Remove::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Scheduler\Remove::execute',
+                    $daemon)
             ->setDescription("Remove a schedule by id (int) or name (string)")
             ->addParameter('int', 'id')
             ->setReturnType('boolean')
@@ -137,8 +137,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "queue.info",
-                 'Comodojo\Extender\Socket\Commands\Queue\Info::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Queue\Info::execute',
+                    $daemon)
             ->setDescription("Get current queue status")
             ->setReturnType('array')
         );
@@ -146,8 +146,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "queue.add",
-                 'Comodojo\Extender\Socket\Commands\Queue\Add::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Queue\Add::execute',
+                    $daemon)
             ->setDescription("Push new request to queue")
             ->addParameter('struct', 'request')
             ->setReturnType('string')
@@ -156,8 +156,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "queue.addBulk",
-                 'Comodojo\Extender\Socket\Commands\Queue\AddBulk::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Queue\AddBulk::execute',
+                    $daemon)
             ->setDescription("Push new requests to queue")
             ->addParameter('array', 'requests')
             ->setReturnType('array')
@@ -170,8 +170,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "worklog.count",
-                 'Comodojo\Extender\Socket\Commands\Worklog\Count::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Worklog\Count::execute',
+                    $daemon)
             ->setDescription("Count recorded worklogs")
             ->setReturnType('int')
         );
@@ -179,8 +179,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "worklog.list",
-                 'Comodojo\Extender\Socket\Commands\Worklog\GetList::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Worklog\GetList::execute',
+                    $daemon)
             ->setDescription("Get a list of worklog according to (optional) filter")
             ->setReturnType('array')
             ->addSignature()
@@ -191,8 +191,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "worklog.byId",
-                 'Comodojo\Extender\Socket\Commands\Worklog\ById::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Worklog\ById::execute',
+                    $daemon)
             ->setDescription("Get a worklog from id")
             ->addParameter('int', 'id')
             ->setReturnType('struct')
@@ -201,8 +201,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "worklog.byUid",
-                 'Comodojo\Extender\Socket\Commands\Worklog\ByUid::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Worklog\ByUid::execute',
+                    $daemon)
             ->setDescription("Get a worklog from uid")
             ->addParameter('string', 'uid')
             ->setReturnType('struct')
@@ -211,8 +211,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "worklog.byJid",
-                 'Comodojo\Extender\Socket\Commands\Worklog\ByJid::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Worklog\ByJid::execute',
+                    $daemon)
             ->setDescription("Get a list of worklog from job id according to (optional) filter")
             ->addParameter('int', 'jid')
             ->setReturnType('array')
@@ -225,8 +225,8 @@  discard block
 block discarded – undo
         $mmanager->add(
             RpcMethod::create(
                 "worklog.byPid",
-                 'Comodojo\Extender\Socket\Commands\Worklog\ByPid::execute',
-                 $daemon)
+                    'Comodojo\Extender\Socket\Commands\Worklog\ByPid::execute',
+                    $daemon)
             ->setDescription("Get a list of worklog from system pid according to (optional) filter")
             ->addParameter('int', 'pid')
             ->setReturnType('array')

Please login to merge, or discard this patch.

		@@ -34,14 +34,14 @@
		block discarded – undo
34	34	use EventsTrait;
35	35
36	36	/**
37		- * Class constructor
38		- *
39		- * @param Configuration $configuration
40		- * @param LoggerInterface $logger
41		- * @param TasksTable $tasks
42		- * @param EventsManager $events
43		- * @param EntityManager $em
44		- */
	37	+ * Class constructor
	38	+ *
	39	+ * @param Configuration $configuration
	40	+ * @param LoggerInterface $logger
	41	+ * @param TasksTable $tasks
	42	+ * @param EventsManager $events
	43	+ * @param EntityManager $em
	44	+ */
45	45	public function __construct(
46	46	Configuration $configuration,
47	47	LoggerInterface $logger,

		@@ -32,8 +32,8 @@ discard block
		block discarded – undo
32	32	$mmanager->add(
33	33	RpcMethod::create(
34	34	"scheduler.refresh",
35		- 'Comodojo\Extender\Socket\Commands\Scheduler\Refresh::execute',
36		- $daemon)
	35	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Refresh::execute',
	36	+ $daemon)
37	37	->setDescription("Refresh current scheduler's schedule")
38	38	->setReturnType('boolean')
39	39	);
		@@ -41,8 +41,8 @@ discard block
		block discarded – undo
41	41	$mmanager->add(
42	42	RpcMethod::create(
43	43	"scheduler.info",
44		- 'Comodojo\Extender\Socket\Commands\Scheduler\Info::execute',
45		- $daemon)
	44	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Info::execute',
	45	+ $daemon)
46	46	->setDescription("Refresh current scheduler status")
47	47	->setReturnType('array')
48	48	);
		@@ -50,8 +50,8 @@ discard block
		block discarded – undo
50	50	$mmanager->add(
51	51	RpcMethod::create(
52	52	"scheduler.add",
53		- 'Comodojo\Extender\Socket\Commands\Scheduler\Add::execute',
54		- $daemon)
	53	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Add::execute',
	54	+ $daemon)
55	55	->setDescription("Set new schedule")
56	56	->addParameter('struct', 'schedule')
57	57	->addParameter('struct', 'request')
		@@ -61,8 +61,8 @@ discard block
		block discarded – undo
61	61	$mmanager->add(
62	62	RpcMethod::create(
63	63	"scheduler.list",
64		- 'Comodojo\Extender\Socket\Commands\Scheduler\GetList::execute',
65		- $daemon)
	64	+ 'Comodojo\Extender\Socket\Commands\Scheduler\GetList::execute',
	65	+ $daemon)
66	66	->setDescription("List all installed schedules")
67	67	->setReturnType('array')
68	68	);
		@@ -70,8 +70,8 @@ discard block
		block discarded – undo
70	70	$mmanager->add(
71	71	RpcMethod::create(
72	72	"scheduler.get",
73		- 'Comodojo\Extender\Socket\Commands\Scheduler\Get::execute',
74		- $daemon)
	73	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Get::execute',
	74	+ $daemon)
75	75	->setDescription("Get a schedule and related task request by id (int) or name (string)")
76	76	->addParameter('int', 'id')
77	77	->setReturnType('array')
		@@ -83,8 +83,8 @@ discard block
		block discarded – undo
83	83	$mmanager->add(
84	84	RpcMethod::create(
85	85	"scheduler.edit",
86		- 'Comodojo\Extender\Socket\Commands\Scheduler\Edit::execute',
87		- $daemon)
	86	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Edit::execute',
	87	+ $daemon)
88	88	->setDescription("Edit a schedule")
89	89	->addParameter('struct', 'schedule')
90	90	->addParameter('struct', 'request')
		@@ -94,8 +94,8 @@ discard block
		block discarded – undo
94	94	$mmanager->add(
95	95	RpcMethod::create(
96	96	"scheduler.disable",
97		- 'Comodojo\Extender\Socket\Commands\Scheduler\Disable::execute',
98		- $daemon)
	97	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Disable::execute',
	98	+ $daemon)
99	99	->setDescription("Disable a schedule by id (int) or name (string)")
100	100	->addParameter('int', 'id')
101	101	->setReturnType('boolean')
		@@ -107,8 +107,8 @@ discard block
		block discarded – undo
107	107	$mmanager->add(
108	108	RpcMethod::create(
109	109	"scheduler.enable",
110		- 'Comodojo\Extender\Socket\Commands\Scheduler\Enable::execute',
111		- $daemon)
	110	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Enable::execute',
	111	+ $daemon)
112	112	->setDescription("Enable a schedule by id (int) or name (string)")
113	113	->addParameter('int', 'id')
114	114	->setReturnType('boolean')
		@@ -120,8 +120,8 @@ discard block
		block discarded – undo
120	120	$mmanager->add(
121	121	RpcMethod::create(
122	122	"scheduler.remove",
123		- 'Comodojo\Extender\Socket\Commands\Scheduler\Remove::execute',
124		- $daemon)
	123	+ 'Comodojo\Extender\Socket\Commands\Scheduler\Remove::execute',
	124	+ $daemon)
125	125	->setDescription("Remove a schedule by id (int) or name (string)")
126	126	->addParameter('int', 'id')
127	127	->setReturnType('boolean')
		@@ -137,8 +137,8 @@ discard block
		block discarded – undo
137	137	$mmanager->add(
138	138	RpcMethod::create(
139	139	"queue.info",
140		- 'Comodojo\Extender\Socket\Commands\Queue\Info::execute',
141		- $daemon)
	140	+ 'Comodojo\Extender\Socket\Commands\Queue\Info::execute',
	141	+ $daemon)
142	142	->setDescription("Get current queue status")
143	143	->setReturnType('array')
144	144	);
		@@ -146,8 +146,8 @@ discard block
		block discarded – undo
146	146	$mmanager->add(
147	147	RpcMethod::create(
148	148	"queue.add",
149		- 'Comodojo\Extender\Socket\Commands\Queue\Add::execute',
150		- $daemon)
	149	+ 'Comodojo\Extender\Socket\Commands\Queue\Add::execute',
	150	+ $daemon)
151	151	->setDescription("Push new request to queue")
152	152	->addParameter('struct', 'request')
153	153	->setReturnType('string')
		@@ -156,8 +156,8 @@ discard block
		block discarded – undo
156	156	$mmanager->add(
157	157	RpcMethod::create(
158	158	"queue.addBulk",
159		- 'Comodojo\Extender\Socket\Commands\Queue\AddBulk::execute',
160		- $daemon)
	159	+ 'Comodojo\Extender\Socket\Commands\Queue\AddBulk::execute',
	160	+ $daemon)
161	161	->setDescription("Push new requests to queue")
162	162	->addParameter('array', 'requests')
163	163	->setReturnType('array')
		@@ -170,8 +170,8 @@ discard block
		block discarded – undo
170	170	$mmanager->add(
171	171	RpcMethod::create(
172	172	"worklog.count",
173		- 'Comodojo\Extender\Socket\Commands\Worklog\Count::execute',
174		- $daemon)
	173	+ 'Comodojo\Extender\Socket\Commands\Worklog\Count::execute',
	174	+ $daemon)
175	175	->setDescription("Count recorded worklogs")
176	176	->setReturnType('int')
177	177	);
		@@ -179,8 +179,8 @@ discard block
		block discarded – undo
179	179	$mmanager->add(
180	180	RpcMethod::create(
181	181	"worklog.list",
182		- 'Comodojo\Extender\Socket\Commands\Worklog\GetList::execute',
183		- $daemon)
	182	+ 'Comodojo\Extender\Socket\Commands\Worklog\GetList::execute',
	183	+ $daemon)
184	184	->setDescription("Get a list of worklog according to (optional) filter")
185	185	->setReturnType('array')
186	186	->addSignature()
		@@ -191,8 +191,8 @@ discard block
		block discarded – undo
191	191	$mmanager->add(
192	192	RpcMethod::create(
193	193	"worklog.byId",
194		- 'Comodojo\Extender\Socket\Commands\Worklog\ById::execute',
195		- $daemon)
	194	+ 'Comodojo\Extender\Socket\Commands\Worklog\ById::execute',
	195	+ $daemon)
196	196	->setDescription("Get a worklog from id")
197	197	->addParameter('int', 'id')
198	198	->setReturnType('struct')
		@@ -201,8 +201,8 @@ discard block
		block discarded – undo
201	201	$mmanager->add(
202	202	RpcMethod::create(
203	203	"worklog.byUid",
204		- 'Comodojo\Extender\Socket\Commands\Worklog\ByUid::execute',
205		- $daemon)
	204	+ 'Comodojo\Extender\Socket\Commands\Worklog\ByUid::execute',
	205	+ $daemon)
206	206	->setDescription("Get a worklog from uid")
207	207	->addParameter('string', 'uid')
208	208	->setReturnType('struct')
		@@ -211,8 +211,8 @@ discard block
		block discarded – undo
211	211	$mmanager->add(
212	212	RpcMethod::create(
213	213	"worklog.byJid",
214		- 'Comodojo\Extender\Socket\Commands\Worklog\ByJid::execute',
215		- $daemon)
	214	+ 'Comodojo\Extender\Socket\Commands\Worklog\ByJid::execute',
	215	+ $daemon)
216	216	->setDescription("Get a list of worklog from job id according to (optional) filter")
217	217	->addParameter('int', 'jid')
218	218	->setReturnType('array')
		@@ -225,8 +225,8 @@ discard block
		block discarded – undo
225	225	$mmanager->add(
226	226	RpcMethod::create(
227	227	"worklog.byPid",
228		- 'Comodojo\Extender\Socket\Commands\Worklog\ByPid::execute',
229		- $daemon)
	228	+ 'Comodojo\Extender\Socket\Commands\Worklog\ByPid::execute',
	229	+ $daemon)
230	230	->setDescription("Get a list of worklog from system pid according to (optional) filter")
231	231	->addParameter('int', 'pid')
232	232	->setReturnType('array')

comodojo / extender.framework

Push — 2.0 ( 2829e8...896296 )

Status

Category

Indentation +8 added lines, -8 removed lines patch added patch discarded remove patch

Indentation +36 added lines, -36 removed lines patch added patch discarded remove patch