Comodojo\Extender\Workers\QueueWorker

Complexity

Total Complexity

4

Size/Duplication

Total Lines	71
Duplicated Lines	16.9 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	spinup()	12	12	1
B	loop()	0	40	2
A	spindown()	0	5	1

<?php namespace Comodojo\Extender\Workers;

use \Comodojo\Daemon\Worker\AbstractWorker;
use \Comodojo\Foundation\Logging\LoggerTrait;
use \Comodojo\Foundation\Events\EventsTrait;
use \Comodojo\Extender\Queue\Manager as QueueManager;
use \Comodojo\Extender\Task\Locker;
use \Comodojo\Extender\Task\Manager as TaskManager;
use \Comodojo\Extender\Traits\TasksTableTrait;
use \Comodojo\Foundation\Base\ConfigurationTrait;
use \Comodojo\Extender\Traits\WorkerTrait;

class QueueWorker extends AbstractWorker {

    use ConfigurationTrait;
    use LoggerTrait;
    use EventsTrait;
    use TasksTableTrait;
    use WorkerTrait;

    protected $locker;

    public function spinup() {

This method seems to be duplicated in your project.

        $configuration = $this->getConfiguration();

        $base_path = $configuration->get('base-path');
        $lock_path = $configuration->get('run-path');
        $lock_file = "$base_path/$lock_path/queue.worker.lock";

        $this->locker = new Locker($lock_file);
        $this->locker->lock([]);

    }

    public function loop() {

        $task_manager = new TaskManager(
            $this->locker,
            $this->getConfiguration(),
            $this->getLogger(),
            $this->getTasksTable(),
            $this->getEvents()
        );

        $queue_manager = new QueueManager(
            $this->getConfiguration(),
            $this->getLogger(),
            $this->getEvents()
        );

        $queue = $queue_manager->get();

        if ( !empty($queue) ) {

            $requests = $this->jobsToRequests($queue);

            $queue_manager->remove($queue);
            unset($queue_manager);

            $result = $task_manager->addBulk($requests)->run();

$result is not used, you could remove the assignment.

            unset($task_manager);

        } else {

            unset($queue_manager);
            unset($task_manager);

        }



        $this->locker->lock([]);

    }

    public function spindown() {

        $this->locker->release();

    }

}