Runner::openWorklog() - Code Metrics - Inspection of "update readme and license file" - comodojo/extender.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( e481c7...bcdb1b )

by Marco
created 2018-03-22 22:36 UTC
Runner::openWorklog() B

↳ Parent: Runner
Complexity

Conditions	3
Paths	17
Size

Total Lines	44
Code Lines	22
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	3
eloc	22
nc	17
nop	8
dl	0
loc	44
rs	8.8571
c	0
b	0
f	0
How to fix Many Parameters

<?php namespace Comodojo\Extender\Task;

use \Comodojo\Extender\Components\Database;
use \Comodojo\Extender\Task\Table as TasksTable;
use \Comodojo\Extender\Events\TaskEvent;
use \Comodojo\Extender\Events\WorklogEvent;
use \Comodojo\Foundation\Base\Configuration;
use \Comodojo\Foundation\Events\Manager as EventsManager;
use \Comodojo\Foundation\Logging\LoggerTrait;
use \Comodojo\Foundation\Events\EventsTrait;
use \Comodojo\Foundation\Base\ConfigurationTrait;
use \Comodojo\Extender\Traits\TasksTableTrait;
use \Comodojo\Extender\Traits\TaskErrorHandlerTrait;
use \Comodojo\Extender\Orm\Entities\Worklog;
use \Comodojo\Extender\Utils\StopWatch;
use \Psr\Log\LoggerInterface;
use \Doctrine\ORM\EntityManager;
use \Comodojo\Exception\TaskException;
use \Exception;

/**
* @package     Comodojo Extender
* @author      Marco Giovinazzi <[email protected]>
* @license     MIT
*
* LICENSE:
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
 */

class Runner {

    use LoggerTrait;
    use ConfigurationTrait;
    use EventsTrait;
    use TasksTableTrait;
    use TaskErrorHandlerTrait;

    /**
     * @var int
     */
    protected $worklog_id;

    /**
     * @var StopWatch
     */
    protected $stopwatch;

    public function __construct(
        Configuration $configuration,
        LoggerInterface $logger,
        TasksTable $table,
        EventsManager $events
    ) {

        // init components
        $this->setConfiguration($configuration);
        $this->setLogger($logger);
        $this->setEvents($events);
        $this->setTasksTable($table);

        // create StopWatch
        $this->stopwatch = new StopWatch();

    }

    public function run(Request $request) {

        $name = $request->getName();
        $task = $request->getTask();
        $uid = $request->getUid();
        $jid = $request->getJid();
        $puid = $request->getParentUid();
        $parameters = $request->getParameters();

        ob_start();

        try {

            $this->stopwatch->start();

            $this->logger->notice("Starting new task $task ($name)");

            $thetask = $this->table->get($task)->getInstance($name, $parameters);

            $this->events->emit( new TaskEvent('start', $thetask) );

            $pid = $thetask->getPid();

            $this->openWorklog(
                $uid,
                $puid,
                $pid,
                $name,
                $jid,
                $task,
                $parameters,
                $this->stopwatch->getStartTime()
            );

            $this->installErrorHandler();

            try {

                $result = $thetask->run();

                $status = Worklog::STATUS_COMPLETE;

                $this->events->emit( new TaskEvent('complete', $thetask) );

            } catch (TaskException $te) {

                $status = Worklog::STATUS_ABORT;

                $result = $te->getMessage();

                $this->events->emit( new TaskEvent('abort', $thetask) );

            } catch (Exception $e) {

                $status = Worklog::STATUS_ERROR;

                $result = $e->getMessage();

                $this->events->emit( new TaskEvent('error', $thetask) );

            }

            $this->restoreErrorHandler();

            $this->events->emit( new TaskEvent('stop', $thetask) );

            $this->stopwatch->stop();

            $this->closeWorklog($status, $result, $this->stopwatch->getStopTime());

            $drift = $this->stopwatch->getDrift()->format('%s');

            $this->logger->notice("Task $name ($task) pid $pid ends in ".($status === Worklog::STATUS_COMPLETE ? 'success' : 'error')." in $drift secs");

        } catch (Exception $e) {

            ob_end_clean();

            throw $e;

        }

        $result = new Result([
            $uid,
            $pid,
            $jid,
            $name,
            $status === Worklog::STATUS_COMPLETE ? true : false,
            $this->stopwatch->getStartTime(),
            $this->stopwatch->getStopTime(),
            $result,
            $this->worklog_id
        ]);

        $this->stopwatch->clear();

        ob_end_clean();

        $this->events->emit( new TaskEvent(self::statusToEvent($status), $thetask, $result) );
        $this->events->emit( new TaskEvent(self::/** @scrutinizer ignore-call */ statusToEvent($status), $thetask, $result) );

        return $result;

    }

    public static function fastStart(
        Request $request,
        Configuration $configuration,
        LoggerInterface $logger,
        TasksTable $table,
        EventsManager $events,
        EntityManager $em = null
    ) {

        $runner = new Runner(
            $configuration,
            $logger,
            $table,
            $events,
            $em
        $runner = /** @scrutinizer ignore-call */ new Runner(
        );

        return $runner->run($request);

    }

    protected function openWorklog(
        $uid,
        $puid,
        $pid,
        $name,
        $jid,
        $task,
        $parameters,
        $start
    ) {

        try {

            $em = Database::init($this->getConfiguration())->getEntityManager();

            $worklog = new Worklog();

            $worklog
                ->setUid($uid)
                ->setParentUid($puid)
                ->setPid($pid)
                ->setName($name)
                ->setStatus(Worklog::STATUS_RUN)
                ->setTask($task)
                ->setParameters($parameters)
                ->setStartTime($start);

            if ( $jid !== null ) {
                $schedule = $em->find('\Comodojo\Extender\Orm\Entities\Schedule', $jid);
                $worklog->setJid($schedule);
            }

            $this->events->emit( new WorklogEvent('open', $worklog) );

            $em->persist($worklog);
            $em->flush();

            $this->worklog_id = $worklog->getId();

            //$em->getConnection()->close();
            $em->close();

        } catch (Exception $e) {
            throw $e;
        }

    }

    protected function closeWorklog(
        $status,
        $result,
        $end
    ) {

        try {

            $em = Database::init($this->getConfiguration())->getEntityManager();

            $worklog = $em->find('\Comodojo\Extender\Orm\Entities\Worklog', $this->worklog_id);

            $worklog
                ->setStatus($status)
                ->setResult($result)
                ->setEndTime($end);

            $jid = $worklog->getJid();
            if ( $jid !== null ) {
                $schedule = $em->find('\Comodojo\Extender\Orm\Entities\Schedule', $jid);
                $worklog->setJid($schedule);
            }

            $this->events->emit( new WorklogEvent('close', $worklog) );

            $em->persist($worklog);
            $em->flush();
            //$em->getConnection()->close();
            $em->close();

        } catch (Exception $e) {
            throw $e;
        }

    }

    protected function statusToEvent($status) {

        switch ($status) {
            case Worklog::STATUS_COMPLETE:
                return 'complete';
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case Worklog::STATUS_ABORT:
                return 'abort';
                break;
            case Worklog::STATUS_ERROR:
                return 'error';
                break;
        }

    }

}

comodojo / extender.framework

Push — master ( e481c7...bcdb1b )

Runner::openWorklog() B

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like
