Comodojo\Extender\Socket\Commands\Scheduler\Edit::execute()

Complexity

Conditions	8
Paths	12

Size

Total Lines	56
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php namespace Comodojo\Extender\Socket\Commands\Scheduler;
    public static function execute(Parameters $params, Daemon $daemon) {

        $schedule_message = $params->get('schedule');
        $request_message = $params->get('request');

        if (
            empty($schedule_message['id']) ||
            empty($schedule_message['name']) ||
            empty($schedule_message['expression'])
        ) {
            throw new RpcException("Missing schedule name, id or invalid expression", -32600);
        }

        try {

            $request = TaskRequest::createFromMessage(
                TaskRequestMessage::createFromExport($request_message)
            );

        } catch (Exception $e) {
            throw new RpcException("Invalid message payload in request", -32600);
        }

        try {

            $schedule = new Schedule();
            $schedule->setId($schedule_message['id']);
            $schedule->setName($schedule_message['name']);
            $schedule->setExpression(CronExpression::factory($schedule_message['expression']));
            $schedule->setDescription($schedule_message['description']);
            $schedule->setEnabled($schedule_message['enabled']);
            $schedule->setRequest($request);

        } catch (Exception $e) {
            throw new RpcException("Invalid message payload in schedule", -32600);
        }

        $manager = new Manager(
            $daemon->getConfiguration(),

The method getConfiguration() does not exist on Comodojo\Daemon\Daemon. It seems like you code against a sub-type of Comodojo\Daemon\Daemon such as Comodojo\Extender\ExtenderDaemon.

            $daemon->getLogger(),
            $daemon->getEvents()
        );

        try {
            $result = $manager->edit($schedule);
        } catch (InvalidArgumentException $iae) {
            throw new RpcException("No record could be found", -31002);
        } catch (Exception $e) {
            throw new RpcException($e->getMessage(), -32500);
        }

        $refresh = Refresh::execute($params, $daemon);

The assignment to $refresh is dead and can be removed.

        // should method ignore invalid refresh message here?

        return $result;