DefaultConfiguration::uriGetAbsolute() - Code Metrics - Inspection of "Bug fixed for router. It now works as it should" - comodojo/dispatcher.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 0c3d7c...75a76e )

by Marco

created 2016-07-05 22:48 UTC

DefaultConfiguration::uriGetAbsolute() A

↳ Parent: DefaultConfiguration

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	5
rs	9.4285
cc	1
eloc	2
nc	1
nop	0

<?php namespace Comodojo\Dispatcher\Components;

/**
 * @package     Comodojo Dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @author      Marco Castiello <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */


class DefaultConfiguration {

    private static $configuration = array(
        'enabled' => true,
        'encoding' => 'UTF-8',
        'disabled-status' => 503,
        'disabled-message' => 'Dispatcher offline',
        'supported-methods' => array('GET','PUT','POST','DELETE','OPTIONS','HEAD')
    );

    public static function get() {

        $config = self::$configuration;

        $config['base-path'] = getcwd();

        $config['base-url'] = self::urlGetAbsolute();

        $config['base-uri'] = self::uriGetAbsolute();

        return $config;

    }

    private static function urlGetAbsolute() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        $http = 'http' . ((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 's' : '') . '://';

        $uri = self::uriGetAbsolute();

        return ( $http . $_SERVER['HTTP_HOST'] . $uri . "/" );

    }

    private static function uriGetAbsolute() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        return preg_replace("/\/index.php(.*?)$/i", "", $_SERVER['PHP_SELF']);

    }

}


1			<?php namespace Comodojo\Dispatcher\Components;
2
3			/**
4			* @package Comodojo Dispatcher
5			* @author Marco Giovinazzi <[email protected]>
6			* @author Marco Castiello <[email protected]>
7			* @license GPL-3.0+
8			*
9			* LICENSE:
10			*
11			* This program is free software: you can redistribute it and/or modify
12			* it under the terms of the GNU Affero General Public License as
13			* published by the Free Software Foundation, either version 3 of the
14			* License, or (at your option) any later version.
15			*
16			* This program is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU Affero General Public License for more details.
20			*
21			* You should have received a copy of the GNU Affero General Public License
22			* along with this program. If not, see <http://www.gnu.org/licenses/>.
23			*/
24
25
26			class DefaultConfiguration {
27
28			private static $configuration = array(
29			'enabled' => true,
30			'encoding' => 'UTF-8',
31			'disabled-status' => 503,
32			'disabled-message' => 'Dispatcher offline',
33			'supported-methods' => array('GET','PUT','POST','DELETE','OPTIONS','HEAD')
34			);
35
36			public static function get() {
37
38			$config = self::$configuration;
39
40			$config['base-path'] = getcwd();
41
42			$config['base-url'] = self::urlGetAbsolute();
43
44			$config['base-uri'] = self::uriGetAbsolute();
45
46			return $config;
47
48			}
49
50			private static function urlGetAbsolute() {
			0 ignored issues – show Coding Style introduced 2016-03-03 00:05 UTC by Report Bug Copy Issue Report `urlGetAbsolute` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
51
52			$http = 'http' . ((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 's' : '') . '://';
53
54			$uri = self::uriGetAbsolute();
55
56			return ( $http . $_SERVER['HTTP_HOST'] . $uri . "/" );
57
58			}
59
60			private static function uriGetAbsolute() {
			0 ignored issues – show Coding Style introduced 2016-07-05 23:00 UTC by Report Bug Copy Issue Report `uriGetAbsolute` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
61
62			return preg_replace("/\/index.php(.*?)$/i", "", $_SERVER['PHP_SELF']);
63
64			}
65
66			}
67

comodojo / dispatcher.framework

Push — 4.0 ( 0c3d7c...75a76e )

DefaultConfiguration::uriGetAbsolute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like