Completed
Push — 4.0 ( 1533b9...4d1c3b )
by Marco
13:08
created
src/Dispatcher.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -167,6 +167,9 @@
 block discarded – undo
167 167
 
168 168
     }
169 169
 
170
+    /**
171
+     * @param string $name
172
+     */
170 173
     private function emitServiceSpecializedEvents($name) {
171 174
 
172 175
         return new ServiceEvent(
Please login to merge, or discard this patch.
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         
86 86
         $this->extra = new Extra($this->logger);
87 87
         
88
-        $this->router->load( $routing_table );
88
+        $this->router->load($routing_table);
89 89
 
90 90
     }
91 91
 
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
 
134 134
     public function dispatch() {
135 135
 
136
-        $this->events->emit( new DispatcherEvent($this) );
136
+        $this->events->emit(new DispatcherEvent($this));
137 137
         
138
-        if ( $this->configuration()->get('dispatcher-enabled') === false ) {
138
+        if ($this->configuration()->get('dispatcher-enabled') === false) {
139 139
             
140 140
             $status = $this->configuration()->get('dispatcher-disabled-status');
141 141
             
@@ -147,31 +147,31 @@  discard block
 block discarded – undo
147 147
             
148 148
         } else {
149 149
             
150
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.request') );
150
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.request'));
151 151
 
152
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.request.'.$this->request->method()->get()) );
152
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.request.'.$this->request->method()->get()));
153 153
     
154
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.request.#') );
154
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.request.#'));
155 155
     
156 156
             $this->router->route($this->request);
157 157
     
158
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.route') );
158
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.route'));
159 159
     
160
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.route.'.$this->router->getType()) );
160
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.route.'.$this->router->getType()));
161 161
     
162
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.route.'.$this->router->getService()) );
162
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.route.'.$this->router->getService()));
163 163
     
164
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.route.#') );
164
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.route.#'));
165 165
     
166 166
             // translate route to service
167 167
     
168 168
             $this->router->compose($this->response);
169 169
     
170
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.response') );
170
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.response'));
171 171
     
172
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.response.'.$this->response->status()->get()) );
172
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.response.'.$this->response->status()->get()));
173 173
     
174
-            $this->events->emit( $this->emitServiceSpecializedEvents('dispatcher.response.#') );
174
+            $this->events->emit($this->emitServiceSpecializedEvents('dispatcher.response.#'));
175 175
             
176 176
         }
177 177
 
Please login to merge, or discard this patch.
src/Cache/DispatcherCache.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -66,8 +66,6 @@
 block discarded – undo
66 66
     /**
67 67
      * Map provided log level to level code
68 68
      *
69
-     * @param   string    $level
70
-     *
71 69
      * @return  integer
72 70
      */
73 71
     protected static function getAlgorithm($algorithm) {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         
42 42
         $ttl = $configuration->get('dispatcher-cache-ttl');
43 43
         
44
-        if ( $ttl !== null && !defined('COMODOJO_CACHE_DEFAULT_TTL') ) {
44
+        if ($ttl !== null && !defined('COMODOJO_CACHE_DEFAULT_TTL')) {
45 45
             
46 46
             define('COMODOJO_CACHE_DEFAULT_TTL', $ttl);
47 47
             
@@ -49,13 +49,13 @@  discard block
 block discarded – undo
49 49
         
50 50
         $folder = $configuration->get('dispatcher-cache-folder');
51 51
         
52
-        $algorithm = self::getAlgorithm( $configuration->get('dispatcher-cache-algorithm') );
52
+        $algorithm = self::getAlgorithm($configuration->get('dispatcher-cache-algorithm'));
53 53
     
54
-        $manager = new CacheManager( $algorithm );
54
+        $manager = new CacheManager($algorithm);
55 55
         
56
-        if ( $enabled === true ) {
56
+        if ($enabled === true) {
57 57
             
58
-            $manager->addProvider( new FileCache($folder) );
58
+            $manager->addProvider(new FileCache($folder));
59 59
             
60 60
         }
61 61
         
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      */
73 73
     protected static function getAlgorithm($algorithm) {
74 74
 
75
-        switch ( strtoupper($algorithm) ) {
75
+        switch (strtoupper($algorithm)) {
76 76
 
77 77
             case 'PICK_LAST':
78 78
                 $selected = CacheManager::PICK_LAST;
Please login to merge, or discard this patch.
src/Log/DispatcherLogger.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -33,8 +33,6 @@
 block discarded – undo
33 33
     /**
34 34
      * Create the logger
35 35
      *
36
-     * @param bool $verbose
37
-     *
38 36
      * @return \Monolog\Logger
39 37
      */
40 38
     public static function create(Configuration $configuration) {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -43,19 +43,19 @@  discard block
 block discarded – undo
43 43
         
44 44
         $enabled = $configuration->get('dispatcher-log-enabled');
45 45
         
46
-        $level = self::getLevel( $configuration->get('dispatcher-log-level') );
46
+        $level = self::getLevel($configuration->get('dispatcher-log-level'));
47 47
         
48 48
         $target = $configuration->get('dispatcher-log-target');
49 49
     
50 50
         $logger = new Logger($name);
51 51
         
52
-        if ( $enabled === true ) {
52
+        if ($enabled === true) {
53 53
             
54
-            $logger->pushHandler( new StreamHandler( $target, $level) );
54
+            $logger->pushHandler(new StreamHandler($target, $level));
55 55
             
56 56
         } else {
57 57
             
58
-            $logger->pushHandler( new NullHandler($level) );
58
+            $logger->pushHandler(new NullHandler($level));
59 59
             
60 60
         }
61 61
         
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      */
73 73
     protected static function getLevel($level) {
74 74
 
75
-        switch ( strtoupper($level) ) {
75
+        switch (strtoupper($level)) {
76 76
 
77 77
             case 'INFO':
78 78
                 $logger_level = Logger::INFO;
Please login to merge, or discard this patch.
src/Components/Configuration.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         //'dispatcher-autoroute' => false
44 44
     );
45 45
 
46
-    public function __construct( $configuration = array() ) {
46
+    public function __construct($configuration = array()) {
47 47
 
48 48
         $this->attributes['dispatcher-base-url'] = self::urlGetAbsolute();
49 49
         
@@ -59,15 +59,15 @@  discard block
 block discarded – undo
59 59
 
60 60
             $value = $this->attributes[$property];
61 61
             
62
-            if ( preg_match_all('/%(.+?)%/', $value, $matches) ) {
62
+            if (preg_match_all('/%(.+?)%/', $value, $matches)) {
63 63
                 
64 64
                 $substitutions = array();
65 65
                 
66
-                foreach ( $matches as $match ) {
66
+                foreach ($matches as $match) {
67 67
                     
68 68
                     $backreference = $match[1];
69 69
                     
70
-                    if ( $backreference != $property && !isset($substitutions['/%'.$backreference.'%/']) ) {
70
+                    if ($backreference != $property && !isset($substitutions['/%'.$backreference.'%/'])) {
71 71
                         
72 72
                         $substitutions['/%'.$backreference.'%/'] = $this->$backreference;
73 73
                         
@@ -111,11 +111,11 @@  discard block
 block discarded – undo
111 111
 
112 112
     private static function urlGetAbsolute() {
113 113
 
114
-        $http = 'http' . ((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 's' : '') . '://';
114
+        $http = 'http'.((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 's' : '').'://';
115 115
 
116 116
         $uri = preg_replace("/\/index.php(.*?)$/i", "", $_SERVER['PHP_SELF']);
117 117
 
118
-        return ( $http . $_SERVER['HTTP_HOST'] . $uri . "/" );
118
+        return ($http.$_SERVER['HTTP_HOST'].$uri."/");
119 119
 
120 120
     }
121 121
     
Please login to merge, or discard this patch.
src/Router/RoutingTable.php 3 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -62,6 +62,9 @@
 block discarded – undo
62 62
         
63 63
     }
64 64
     
65
+    /**
66
+     * @param string $route
67
+     */
65 68
     public function get($route) {
66 69
         
67 70
         $folders = explode("/", $route);
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
                 $this->readpath( 
129 129
                     $folders,
130 130
                     $value,
131
-                    $regex.'(?:\/'.$param_regex.')'. (($param_required)?'{1}':'?')
131
+                    $regex.'(?:\/'.$param_regex.')'.(($param_required) ? '{1}' : '?')
132 132
                 );
133 133
                 
134 134
             } else {
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         $string = preg_replace('/(?<!\\)\((?!\?)/', '(?:', $string);
172 172
         $string = preg_replace('/\.([\*\+])(?!\?)/', '.\${1}?', $string);
173 173
         
174
-        return '(?P<' . $key . '>' . $string . ')' . (($field_required)?'{1}':'?');
174
+        return '(?P<'.$key.'>'.$string.')'.(($field_required) ? '{1}' : '?');
175 175
         
176 176
     }
177 177
     
Please login to merge, or discard this patch.
Braces   +11 added lines, -6 removed lines patch added patch discarded remove patch
@@ -68,10 +68,11 @@  discard block
 block discarded – undo
68 68
         
69 69
         $regex = $this->readpath($folders);
70 70
         
71
-        if (isset($this->routes[$regex])) 
72
-            return $this->routes[$regex];
73
-        else 
74
-            return null;
71
+        if (isset($this->routes[$regex])) {
72
+                    return $this->routes[$regex];
73
+        } else {
74
+                    return null;
75
+        }
75 76
         
76 77
     }
77 78
     
@@ -81,7 +82,9 @@  discard block
 block discarded – undo
81 82
         
82 83
         $regex = $this->readpath($folders);
83 84
         
84
-        if (isset($this->routes[$regex])) unset($this->routes[$regex]);
85
+        if (isset($this->routes[$regex])) {
86
+            unset($this->routes[$regex]);
87
+        }
85 88
         
86 89
     }
87 90
     
@@ -99,7 +102,9 @@  discard block
 block discarded – undo
99 102
     
100 103
     private function readpath($folders = array(), &$value = null, $regex = '') {
101 104
         
102
-        if (!empty($folders) && empty($folders[0])) array_shift($folders);
105
+        if (!empty($folders) && empty($folders[0])) {
106
+            array_shift($folders);
107
+        }
103 108
         
104 109
         if (empty($folders)) {
105 110
             
Please login to merge, or discard this patch.