Post::getParameters() - Code Metrics - Inspection of "using 1.0 version of exception package" - comodojo/dispatcher.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 2ca4e1...0c3d7c )

by Marco

created 2016-06-07 11:00 UTC

Post::getParameters() B

↳ Parent: Post

Complexity

Conditions	4
Paths	4

Size

Total Lines	28
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	28
rs	8.5806
cc	4
eloc	13
nc	4
nop	0

<?php namespace Comodojo\Dispatcher\Request;

use \Comodojo\Dispatcher\Components\Parameters as ParametersTrait;

/**
 * @package     Comodojo Dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @author      Marco Castiello <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class Post {

    use ParametersTrait;

    protected $raw_parameters;

    public function __construct() {

        $this->parameters = self::getParameters();

        $this->raw_parameters = self::getRawParameters();

    }

    public function raw() {

        return $this->raw_parameters;

    }

    private static function getParameters() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        switch( $_SERVER['REQUEST_METHOD'] ) {

            case 'POST':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                $parameters = $_POST;

                break;

            case 'PUT':
            case 'DELETE':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                parse_str(file_get_contents('php://input'), $parameters);

                break;

            default:
switch ($expr) {
    default:
        doSomething(); //right
        break;
}


switch ($expr) {
    default:

        doSomething(); //wrong
        break;
}

                $parameters = array();

                break;

        }

        return $parameters;

    }

    private static function getRawParameters() {

        return file_get_contents('php://input');

    }

}


1			<?php namespace Comodojo\Dispatcher\Request;
2
3			use \Comodojo\Dispatcher\Components\Parameters as ParametersTrait;
4
5			/**
6			* @package Comodojo Dispatcher
7			* @author Marco Giovinazzi <[email protected]>
8			* @author Marco Castiello <[email protected]>
9			* @license GPL-3.0+
10			*
11			* LICENSE:
12			*
13			* This program is free software: you can redistribute it and/or modify
14			* it under the terms of the GNU Affero General Public License as
15			* published by the Free Software Foundation, either version 3 of the
16			* License, or (at your option) any later version.
17			*
18			* This program is distributed in the hope that it will be useful,
19			* but WITHOUT ANY WARRANTY; without even the implied warranty of
20			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21			* GNU Affero General Public License for more details.
22			*
23			* You should have received a copy of the GNU Affero General Public License
24			* along with this program. If not, see <http://www.gnu.org/licenses/>.
25			*/
26
27			class Post {
28
29			use ParametersTrait;
30
31			protected $raw_parameters;
32
33			public function __construct() {
34
35			$this->parameters = self::getParameters();
36
37			$this->raw_parameters = self::getRawParameters();
38
39			}
40
41			public function raw() {
42
43			return $this->raw_parameters;
44
45			}
46
47			private static function getParameters() {
			0 ignored issues – show Coding Style introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `getParameters` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `getParameters` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
48
49			switch( $_SERVER['REQUEST_METHOD'] ) {
50
51			case 'POST':
			0 ignored issues – show Coding Style introduced 2016-03-03 00:05 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
52
53			$parameters = $_POST;
54
55			break;
56
57			case 'PUT':
58			case 'DELETE':
			0 ignored issues – show Coding Style introduced 2016-03-03 00:05 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
59
60			parse_str(file_get_contents('php://input'), $parameters);
61
62			break;
63
64			default:
			0 ignored issues – show Coding Style introduced 2016-03-03 00:05 UTC by Report Bug Copy Issue Report The default body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a default statement must start on the line immediately following the statement. switch ($expr) { default: doSomething(); //right break; } switch ($expr) { default: doSomething(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
65
66			$parameters = array();
67
68			break;
69
70			}
71
72			return $parameters;
73
74			}
75
76			private static function getRawParameters() {
77
78			return file_get_contents('php://input');
79
80			}
81
82			}
83

comodojo / dispatcher.framework

Push — 4.0 ( 2ca4e1...0c3d7c )

Post::getParameters() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like