UserAgent::__construct() - Code Metrics - Inspection of "events, main dispatcher class stub" - comodojo/dispatcher.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 954171...ed2d0a )

by Marco

created 2016-01-11 23:31 UTC

UserAgent::__construct() A

↳ Parent: UserAgent

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	5
rs	9.4286
cc	1
eloc	2
nc	1
nop	0

<?php namespace Comodojo\Dispatcher\Request;

/**
 *
 * @package     Comodojo dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class UserAgent {

    private $user_agent = null;

    public function __construct() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        $this->user_agent = $_SERVER['HTTP_USER_AGENT'];

    }

    public function get() {

        return $this->user_agent;

    }

    public function set($ua) {

        $this->user_agent = $ua;

        return $this;

    }

    public function browser() {

        return get_browser($this->browser);
class MyClass { }

$x = new MyClass();
$x->foo = true;

    }

}


1			<?php namespace Comodojo\Dispatcher\Request;
2
3			/**
4			*
5			* @package Comodojo dispatcher
6			* @author Marco Giovinazzi <[email protected]>
7			* @license GPL-3.0+
8			*
9			* LICENSE:
10			*
11			* This program is free software: you can redistribute it and/or modify
12			* it under the terms of the GNU Affero General Public License as
13			* published by the Free Software Foundation, either version 3 of the
14			* License, or (at your option) any later version.
15			*
16			* This program is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU Affero General Public License for more details.
20			*
21			* You should have received a copy of the GNU Affero General Public License
22			* along with this program. If not, see <http://www.gnu.org/licenses/>.
23			*/
24
25			class UserAgent {
26
27			private $user_agent = null;
28
29			public function __construct() {
			0 ignored issues – show Coding Style introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `__construct` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
30
31			$this->user_agent = $_SERVER['HTTP_USER_AGENT'];
32
33			}
34
35			public function get() {
36
37			return $this->user_agent;
38
39			}
40
41			public function set($ua) {
42
43			$this->user_agent = $ua;
44
45			return $this;
46
47			}
48
49			public function browser() {
50
51			return get_browser($this->browser);
			0 ignored issues – show Bug introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report The property `browser` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52
53			}
54
55			}
56

comodojo / dispatcher.framework

Push — 4.0 ( 954171...ed2d0a )

UserAgent::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like