Configuration::__get() - Code Metrics - Inspection of "events, main dispatcher class stub" - comodojo/dispatcher.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 954171...ed2d0a )

by Marco

created 2016-01-11 23:31 UTC

Configuration::__get() A

↳ Parent: Configuration

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4286
cc	2
eloc	4
nc	2
nop	1

<?php namespace Comodojo\Dispatcher\Components;

/**
 *
 * @package     Comodojo dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

 // define('DISPATCHER_LOG_ENABLED', false);

 //
 // define('DISPATCHER_LOG_NAME', 'dispatcher');

 //
 // define('DISPATCHER_LOG_TARGET', null);

 //
 // define('DISPATCHER_LOG_LEVEL', 'ERROR');

 //
 // define("DISPATCHER_REAL_PATH", realpath(dirname(__FILE__)."/../")."/");

 //
 // define("DISPATCHER_BASEURL","");

 //
 // define ('DISPATCHER_ENABLED', true);

 //
 // define ('DISPATCHER_USE_REWRITE', true);

 //
 // define('DISPATCHER_AUTO_ROUTE', false);

 //
 // define('DISPATCHER_CACHE_ENABLED', true);

 //
 // define('DISPATCHER_CACHE_DEFAULT_TTL', 600);

 //
 // define('DISPATCHER_CACHE_FAIL_SILENTLY', true);

 //
 // define('DISPATCHER_DEFAULT_ENCODING', 'UTF-8');

 //
 // define('DISPATCHER_SUPPORTED_METHODS', 'GET,PUT,POST,DELETE,OPTIONS,HEAD');

 //
 // define('DISPATCHER_CACHE_FOLDER', DISPATCHER_REAL_PATH."cache/");

 //
 // define('DISPATCHER_SERVICES_FOLDER', DISPATCHER_REAL_PATH."services/");

 //
 // define('DISPATCHER_PLUGINS_FOLDER', DISPATCHER_REAL_PATH."plugins/");

 //
 // define('DISPATCHER_TEMPLATES_FOLDER', DISPATCHER_REAL_PATH."templates/");

 //
 // define('DISPATCHER_LOG_FOLDER', DISPATCHER_REAL_PATH."logs/");


class Configuration {

    private $attributes = array(
        'DISPATCHER_ENABLED' => true,
        'DISPATCHER_SUPPORTED_METHODS' => 'GET,PUT,POST,DELETE,OPTIONS,HEAD',
        'DISPATCHER_DEFAULT_ENCODING' => 'UTF-8',
        'DISPATCHER_AUTO_ROUTE' => false
    );

    public function __construct() {

        $this->attributes['DISPATCHER_BASE_URL'] = self::urlGetAbsolute();

        $constants = get_defined_constants(true);

        if ( !isset($constants['user']) ) return;

        $dispatcher_constants = preg_grep("/^DISPATCHER_/", array_keys($constants['user']));

        if ( sizeof($dispatcher_constants) > 0 ) {

            $filtered_constants = array_intersect_key($constants['user'], array_flip($dispatcher_constants));

            $this->attributes = array_merge($this->attributes, $filtered_constants);

        }

    }

    final public function __get($property) {

        if (array_key_exists($property, $this->attributes)) {

            return $this->attributes[$property];

        }

        return null;

    }

    final public function __isset($property) {

        return isset($this->attributes[$property]);

    }

    private static function urlGetAbsolute() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        $http = 'http' . ((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 's' : '') . '://';

        $uri = preg_replace("/\/index.php(.*?)$/i", "", $_SERVER['PHP_SELF']);

        return ( $http . $_SERVER['HTTP_HOST'] . $uri . "/" );

    }

}


1			<?php namespace Comodojo\Dispatcher\Components;
2
3			/**
4			*
5			* @package Comodojo dispatcher
6			* @author Marco Giovinazzi <[email protected]>
7			* @license GPL-3.0+
8			*
9			* LICENSE:
10			*
11			* This program is free software: you can redistribute it and/or modify
12			* it under the terms of the GNU Affero General Public License as
13			* published by the Free Software Foundation, either version 3 of the
14			* License, or (at your option) any later version.
15			*
16			* This program is distributed in the hope that it will be useful,
17			* but WITHOUT ANY WARRANTY; without even the implied warranty of
18			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
19			* GNU Affero General Public License for more details.
20			*
21			* You should have received a copy of the GNU Affero General Public License
22			* along with this program. If not, see <http://www.gnu.org/licenses/>.
23			*/
24
25			// define('DISPATCHER_LOG_ENABLED', false);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
26			//
27			// define('DISPATCHER_LOG_NAME', 'dispatcher');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			//
29			// define('DISPATCHER_LOG_TARGET', null);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
30			//
31			// define('DISPATCHER_LOG_LEVEL', 'ERROR');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
32			//
33			// define("DISPATCHER_REAL_PATH", realpath(dirname(__FILE__)."/../")."/");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
34			//
35			// define("DISPATCHER_BASEURL","");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
36			//
37			// define ('DISPATCHER_ENABLED', true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
38			//
39			// define ('DISPATCHER_USE_REWRITE', true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `60%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
40			//
41			// define('DISPATCHER_AUTO_ROUTE', false);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
42			//
43			// define('DISPATCHER_CACHE_ENABLED', true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
44			//
45			// define('DISPATCHER_CACHE_DEFAULT_TTL', 600);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
46			//
47			// define('DISPATCHER_CACHE_FAIL_SILENTLY', true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
48			//
49			// define('DISPATCHER_DEFAULT_ENCODING', 'UTF-8');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50			//
51			// define('DISPATCHER_SUPPORTED_METHODS', 'GET,PUT,POST,DELETE,OPTIONS,HEAD');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			//
53			// define('DISPATCHER_CACHE_FOLDER', DISPATCHER_REAL_PATH."cache/");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
54			//
55			// define('DISPATCHER_SERVICES_FOLDER', DISPATCHER_REAL_PATH."services/");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
56			//
57			// define('DISPATCHER_PLUGINS_FOLDER', DISPATCHER_REAL_PATH."plugins/");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			//
59			// define('DISPATCHER_TEMPLATES_FOLDER', DISPATCHER_REAL_PATH."templates/");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
60			//
61			// define('DISPATCHER_LOG_FOLDER', DISPATCHER_REAL_PATH."logs/");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
62
63			class Configuration {
64
65			private $attributes = array(
66			'DISPATCHER_ENABLED' => true,
67			'DISPATCHER_SUPPORTED_METHODS' => 'GET,PUT,POST,DELETE,OPTIONS,HEAD',
68			'DISPATCHER_DEFAULT_ENCODING' => 'UTF-8',
69			'DISPATCHER_AUTO_ROUTE' => false
70			);
71
72			public function __construct() {
73
74			$this->attributes['DISPATCHER_BASE_URL'] = self::urlGetAbsolute();
75
76			$constants = get_defined_constants(true);
77
78			if ( !isset($constants['user']) ) return;
79
80			$dispatcher_constants = preg_grep("/^DISPATCHER_/", array_keys($constants['user']));
81
82			if ( sizeof($dispatcher_constants) > 0 ) {
83
84			$filtered_constants = array_intersect_key($constants['user'], array_flip($dispatcher_constants));
85
86			$this->attributes = array_merge($this->attributes, $filtered_constants);
87
88			}
89
90			}
91
92			final public function __get($property) {
93
94			if (array_key_exists($property, $this->attributes)) {
95
96			return $this->attributes[$property];
97
98			}
99
100			return null;
101
102			}
103
104			final public function __isset($property) {
105
106			return isset($this->attributes[$property]);
107
108			}
109
110			private static function urlGetAbsolute() {
			0 ignored issues – show Coding Style introduced 2016-01-11 23:45 UTC by Report Bug Copy Issue Report `urlGetAbsolute` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
111
112			$http = 'http' . ((isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') ? 's' : '') . '://';
113
114			$uri = preg_replace("/\/index.php(.*?)$/i", "", $_SERVER['PHP_SELF']);
115
116			return ( $http . $_SERVER['HTTP_HOST'] . $uri . "/" );
117
118			}
119
120			}
121

comodojo / dispatcher.framework

Push — 4.0 ( 954171...ed2d0a )

Configuration::__get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like