View GitHub Repository dispatcher.framework

Schedule Inspection
Subscribe
Completed
Push — 4.0 ( 4d6b64...872671 )
by Marco
03:00
created
Status
Category
Toggle Patches
src/Comodojo/Dispatcher/Response/Preprocessor/Status201.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -30,7 +30,7 @@
 
 block discarded – undo
30 30
31 31 
         $location = $this->response->getLocation()->get();
32 32
33 
-        if ( $location != null ) $this->response->getHeaders()->set("Location", $location);
33 
+        if ($location != null) $this->response->getHeaders()->set("Location", $location);
34 34
35 35 
         parent::consolidate();
36 36
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -30,7 +30,9 @@
 
 block discarded – undo
30 30
31 31 
         $location = $this->response->getLocation()->get();
32 32
33 
-        if ( $location != null ) $this->response->getHeaders()->set("Location", $location);
33 
+        if ( $location != null ) {
34 
+            $this->response->getHeaders()->set("Location", $location);
35 
+        }
34 36
35 37 
         parent::consolidate();
36 38
Please login to merge, or discard this patch.
src/Comodojo/Dispatcher/Response/Preprocessor/Status200.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@
 
 block discarded – undo
33 33 
         $type = $this->response->getContent()->type();
34 34 
         $charset = $this->response->getContent()->charset();
35 35
36 
-        if ( is_null($charset) ) {
36 
+        if (is_null($charset)) {
37 37 
             $this->response->getHeaders()->set("Content-type", strtolower($type));
38 38 
         } else {
39 39 
             $this->response->getHeaders()->set("Content-type", strtolower($type)."; charset=".$charset);
Please login to merge, or discard this patch.
src/Comodojo/Dispatcher/Response/Preprocessor/Status405.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@
 
 block discarded – undo
33 33 
         // An Allow Header should be provided from DispatcherException
34 34 
         $allow = $this->response->getHeaders()->get('Allow');
35 35
36 
-        if ( is_null($allow) ) throw new Exception("Missing Allow header");
36 
+        if (is_null($allow)) throw new Exception("Missing Allow header");
37 37
38 38 
         parent::consolidate();
39 39
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,9 @@
 
 block discarded – undo
33 33 
         // An Allow Header should be provided from DispatcherException
34 34 
         $allow = $this->response->getHeaders()->get('Allow');
35 35
36 
-        if ( is_null($allow) ) throw new Exception("Missing Allow header");
36 
+        if ( is_null($allow) ) {
37 
+            throw new Exception("Missing Allow header");
38 
+        }
37 39
38 40 
         parent::consolidate();
39 41
Please login to merge, or discard this patch.
src/Comodojo/Dispatcher/Response/Preprocessor/Status301.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -32,13 +32,13 @@
 
 block discarded – undo
32 32
33 33 
         $location = $this->response->getLocation()->get();
34 34
35 
-        if ( empty($location) ) throw new Exception("Invalid location, cannot redirect");
35 
+        if (empty($location)) throw new Exception("Invalid location, cannot redirect");
36 36
37 37 
         $this->response->getHeaders()->set("Location", $location);
38 38
39 39 
         $content = $this->response->getContent();
40 40
41 
-        if ( empty($content->get()) ) {
41 
+        if (empty($content->get())) {
42 42
43 43 
             $content->set(sprintf('<!DOCTYPE html>
44 44 
 <html>
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -32,7 +32,9 @@
 
 block discarded – undo
32 32
33 33 
         $location = $this->response->getLocation()->get();
34 34
35 
-        if ( empty($location) ) throw new Exception("Invalid location, cannot redirect");
35 
+        if ( empty($location) ) {
36 
+            throw new Exception("Invalid location, cannot redirect");
37 
+        }
36 38
37 39 
         $this->response->getHeaders()->set("Location", $location);
38 40
Please login to merge, or discard this patch.