Query::getParameters() - Code Metrics - Inspection of "move from foundation/model to setters and getters" - comodojo/dispatcher.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 4d6b64...872671 )

by Marco

created 2017-02-08 01:01 UTC

Query::getParameters() A

↳ Parent: Query

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	2

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	0
loc	23
ccs	2
cts	2
cp	1
rs	9.0856
c	1
b	1
f	0
cc	2
eloc	2
nc	2
nop	0
crap	2

<?php namespace Comodojo\Dispatcher\Request;

use \Comodojo\Foundation\Base\ParametersTrait;

/**
 * @package     Comodojo Dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @author      Marco Castiello <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class Query {

    use ParametersTrait;

    public function __construct() {

        $this->parameters = self::getParameters();

    }

    private static function getParameters() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        return isset($_GET) ? $_GET : [];

        // switch( $_SERVER['REQUEST_METHOD'] ) {

        //
        //     case 'GET':
        //
        //         $parameters = $_GET;

        //
        //         break;
        //
        //     default:
        //
        //         $parameters = [];

        //
        //         break;
        //
        // }

        // return $parameters;

    }

}


1		<?php namespace Comodojo\Dispatcher\Request;
2
3		use \Comodojo\Foundation\Base\ParametersTrait;
4
5		/**
6		* @package Comodojo Dispatcher
7		* @author Marco Giovinazzi <[email protected]>
8		* @author Marco Castiello <[email protected]>
9		* @license GPL-3.0+
10		*
11		* LICENSE:
12		*
13		* This program is free software: you can redistribute it and/or modify
14		* it under the terms of the GNU Affero General Public License as
15		* published by the Free Software Foundation, either version 3 of the
16		* License, or (at your option) any later version.
17		*
18		* This program is distributed in the hope that it will be useful,
19		* but WITHOUT ANY WARRANTY; without even the implied warranty of
20		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21		* GNU Affero General Public License for more details.
22		*
23		* You should have received a copy of the GNU Affero General Public License
24		* along with this program. If not, see <http://www.gnu.org/licenses/>.
25		*/
26
27		class Query {
28
29		use ParametersTrait;
30
31	5	public function __construct() {
32
33	5	$this->parameters = self::getParameters();
34
35	5	}
36
37	5	private static function getParameters() {
		0 ignored issues – show Coding Style introduced 2016-01-28 22:05 UTC by Report Bug Copy Issue Report `getParameters` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
38
39	5	return isset($_GET) ? $_GET : [];
40
41		// switch( $_SERVER['REQUEST_METHOD'] ) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-08 01:03 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
42		//
43		// case 'GET':
44		//
45		// $parameters = $_GET;
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-08 01:03 UTC by Report Bug Copy Issue Report `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
46		//
47		// break;
48		//
49		// default:
50		//
51		// $parameters = [];
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-08 01:03 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52		//
53		// break;
54		//
55		// }
56
57		// return $parameters;
58
59		}
60
61		}
62

comodojo / dispatcher.framework

Push — 4.0 ( 4d6b64...872671 )

Query::getParameters() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like