Status202::consolidate() - Code Metrics - Inspection of "Rewriting output processor" - comodojo/dispatcher.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 7855d8...1b9fbe )

by Marco

created 2016-05-08 20:39 UTC

Status202::consolidate() A

↳ Parent: Status202

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	8
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	8
loc	8
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php namespace Comodojo\Dispatcher\Output\HttpStatus;

/**
 * Status: Accepted
 *
 * @package     Comodojo Dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @author      Marco Castiello <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class Status202 extends AbstractHttpStatus {


    public function consolidate() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        //PLEASE NOTE: according to HTTP/1.1, 202 header SHOULD HAVE status description in body... just in case
        header($_SERVER["SERVER_PROTOCOL"].' 202 Accepted');
        header('Status: 202 Accepted');
        header('Content-Length: '.$this->response()->content()->length());

    }

}


1		<?php namespace Comodojo\Dispatcher\Output\HttpStatus;
2
3		/**
4		* Status: Accepted
5		*
6		* @package Comodojo Dispatcher
7		* @author Marco Giovinazzi <[email protected]>
8		* @author Marco Castiello <[email protected]>
9		* @license GPL-3.0+
10		*
11		* LICENSE:
12		*
13		* This program is free software: you can redistribute it and/or modify
14		* it under the terms of the GNU Affero General Public License as
15		* published by the Free Software Foundation, either version 3 of the
16		* License, or (at your option) any later version.
17		*
18		* This program is distributed in the hope that it will be useful,
19		* but WITHOUT ANY WARRANTY; without even the implied warranty of
20		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21		* GNU Affero General Public License for more details.
22		*
23		* You should have received a copy of the GNU Affero General Public License
24		* along with this program. If not, see <http://www.gnu.org/licenses/>.
25		*/
26
27	View Code Duplication	class Status202 extends AbstractHttpStatus {
		0 ignored issues – show Duplication introduced 2016-05-08 20:50 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28
29		public function consolidate() {
		0 ignored issues – show Coding Style introduced 2016-05-08 20:50 UTC by Report Bug Copy Issue Report `consolidate` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
30
31		//PLEASE NOTE: according to HTTP/1.1, 202 header SHOULD HAVE status description in body... just in case
32		header($_SERVER["SERVER_PROTOCOL"].' 202 Accepted');
33		header('Status: 202 Accepted');
34		header('Content-Length: '.$this->response()->content()->length());
35
36		}
37
38		}
39

comodojo / dispatcher.framework

Push — 4.0 ( 7855d8...1b9fbe )

Status202::consolidate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like