Query::getParameters() - Code Metrics - Inspection of "new regex to find routes and parameters. New Query..." - comodojo/dispatcher.framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 2bab8b...b7ae43 )

by Marco

created 2016-01-28 21:51 UTC

Query::getParameters() A

↳ Parent: Query

Complexity

Conditions	2
Paths	2

Size

Total Lines	21
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	21
rs	9.3142
cc	2
eloc	9
nc	2
nop	0

<?php namespace Comodojo\Dispatcher\Request;

use \Comodojo\Dispatcher\Components\Parameters as ParametersTrait;

/**
 *
 * @package     Comodojo dispatcher
 * @author      Marco Giovinazzi <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class Query {

    use ParametersTrait;

    public function __construct() {

        $this->parameters = self::getParameters();

    }

    private static function getParameters() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}

        switch( $_SERVER['REQUEST_METHOD'] ) {

            case 'GET':

                $parameters = $_GET;

                break;

            default:

                $parameters = array();

                break;

        }

        return $parameters;

    }

}


1			<?php namespace Comodojo\Dispatcher\Request;
2
3			use \Comodojo\Dispatcher\Components\Parameters as ParametersTrait;
4
5			/**
6			*
7			* @package Comodojo dispatcher
8			* @author Marco Giovinazzi <[email protected]>
9			* @license GPL-3.0+
10			*
11			* LICENSE:
12			*
13			* This program is free software: you can redistribute it and/or modify
14			* it under the terms of the GNU Affero General Public License as
15			* published by the Free Software Foundation, either version 3 of the
16			* License, or (at your option) any later version.
17			*
18			* This program is distributed in the hope that it will be useful,
19			* but WITHOUT ANY WARRANTY; without even the implied warranty of
20			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21			* GNU Affero General Public License for more details.
22			*
23			* You should have received a copy of the GNU Affero General Public License
24			* along with this program. If not, see <http://www.gnu.org/licenses/>.
25			*/
26
27			class Query {
28
29			use ParametersTrait;
30
31			public function __construct() {
32
33			$this->parameters = self::getParameters();
34
35			}
36
37			private static function getParameters() {
			0 ignored issues – show Coding Style introduced 2016-01-28 22:05 UTC by Report Bug Copy Issue Report `getParameters` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-01-28 22:05 UTC by Report Bug Copy Issue Report `getParameters` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
38
39			switch( $_SERVER['REQUEST_METHOD'] ) {
40
41			case 'GET':
42
43			$parameters = $_GET;
44
45			break;
46
47			default:
48
49			$parameters = array();
50
51			break;
52
53			}
54
55			return $parameters;
56
57			}
58
59			}
60

comodojo / dispatcher.framework

Push — 4.0 ( 2bab8b...b7ae43 )

Query::getParameters() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like