Comodojo\Dispatcher\Router\Table

Complexity

Total Complexity

33

Size/Duplication

Total Lines	242
Duplicated Lines	0 %

Test Coverage

Coverage

57.6%

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	count()	0	3	1
A	defaultRoute()	0	3	1
A	getRoutes()	0	3	1
A	dumpCache()	0	10	3
A	readCache()	0	17	3
A	__construct()	0	12	1
A	registerRoute()	0	20	1
B	updateRoute()	0	13	7
A	add()	0	36	5
A	remove()	0	17	2
A	get()	0	9	2
A	load()	0	21	5
A	regex()	0	5	1

<?php namespace Comodojo\Dispatcher\Router;

use \Comodojo\Foundation\Base\Configuration;
use \Comodojo\Dispatcher\Components\AbstractModel;
use \Comodojo\Dispatcher\Cache\RouterCache;
use \Comodojo\Dispatcher\Request\Model as Request;
use \Comodojo\Dispatcher\Router\Parser;
use \Comodojo\Dispatcher\Router\Route;
use \Comodojo\Dispatcher\Router\Model as Router;
use \Comodojo\SimpleCache\Manager as SimpleCacheManager;
use \Comodojo\Exception\DispatcherException;
use \Psr\Log\LoggerInterface;
use \Countable;
use \Exception;

/**
 * @package     Comodojo Dispatcher
 * @author      Marco Giovinazzi <marco.giovinazzi@comodojo.org>
 * @author      Marco Castiello <marco.castiello@gmail.com>
 * @license     MIT
 *
 * LICENSE:
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

class Table extends AbstractModel implements Countable {

    /**
     * Types of route that this table will accept
     * @var array
     */
    const ALLOWED_ROUTES = [ "ROUTE", "REDIRECT", "ERROR" ];

The string literal ROUTE does not require double quotes, as per coding-style, please use single quotes.

The string literal REDIRECT does not require double quotes, as per coding-style, please use single quotes.

The string literal ERROR does not require double quotes, as per coding-style, please use single quotes.

    /**
     * Current repository of routes
     * @var array
     */
    protected $routes = [];

    /**
     * @var Parser
     */
    protected $parser;

    /**
     * @var RouterCache
     */
    protected $cache;

    /**
     * Table constructor
     *
     * @param Configuration $configuration
     * @param LoggerInterface $logger
     * @param SimpleCacheManager $cache
     */
    public function __construct(
        Configuration $configuration,
        LoggerInterface $logger,
        SimpleCacheManager $cache
    ) {

        parent::__construct($configuration, $logger);

        $this->parser = new Parser($logger);
        $this->cache = new RouterCache($cache);

        $this->readCache();

    }

    public function add(
        $route,
        $type,
        $class = null,
        array $parameters = []
    ) {

        $type = strtoupper($type);

        if ( !in_array($type, self::ALLOWED_ROUTES) ) {

            $this->getLogger()->error("Invalid route definition - unknown type $type for route $route)");

As per coding-style, please use concatenation or sprintf for the variable $type instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $route instead of interpolation.

        } else if ( $type == 'ROUTE' && empty($class) ) {

Operator == prohibited; use === instead

            $this->getLogger()->error("Invalid route definition - missing class for route $route)");

As per coding-style, please use concatenation or sprintf for the variable $route instead of interpolation.

        } else {

            $routeData = $this->get($route);

            if ( !is_null($routeData) ) {

                $this->updateRoute($routeData, $type, $class, $parameters);

            } else {

                $folders = explode("/", $route);

The string literal / does not require double quotes, as per coding-style, please use single quotes.

                $this->registerRoute($folders, $type, $class, $parameters);

            }

        }

        return $this;

    }

    /**
     * Get registered routes count
     *
     * @return int
     */
    public function count() {

        return count($this->routes);

    }

    public function getRoutes() {

        return $this->routes;

    }

    public function get($route) {

        $regex = $this->regex($route);

        if (isset($this->routes[$regex])) {
            return $this->routes[$regex];
        }

        return null;

    }

    public function regex($route) {

        $folders = explode("/", $route);

The string literal / does not require double quotes, as per coding-style, please use single quotes.

        return $this->parser->read($folders);

    }

    public function remove($route) {

        $regex = $this->regex($route);

        $routes = $this->routes;

        if (isset($routes[$regex])) {

            unset($routes[$regex]);

            $this->routes = $routes;

            return true;

        }

        return false;

    }

    public function defaultRoute() {

        return $this->get('/');

    }

    public function load(array $routes) {

        if (!empty($routes)) {

            foreach ($routes as $name => $route) {

                $this->add(
                    $route['route'],
                    $route['type'],
                    empty($route['class']) ? null : $route['class'],
                    empty($route['parameters']) ? [] : $route['parameters']
                );

            }

        }

        $count = $this->count();
        $this->logger->debug("$count routes loaded in routing table");

As per coding-style, please use concatenation or sprintf for the variable $count instead of interpolation.

        $this->dumpCache();

    }

    // This method add a route to the supported list
    private function registerRoute($folders, $type, $class = null, array $parameters = []) {

        // The values associated with a route are as follows:
        // $route = new Route($this->router);

50% of this comment could be valid code. Did you maybe forget this after debugging?

        $route = new Route();

        $this->updateRoute($route, $type, $class, $parameters);

        // $route->setType($type) // Type of route

63% of this comment could be valid code. Did you maybe forget this after debugging?

        //     ->setClassName($class) // Class to be invoked

58% of this comment could be valid code. Did you maybe forget this after debugging?

        //     ->setParameters($parameters); // Parameters passed via the composer.json configuration (cache, ttl, etc...)

63% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->logger->debug("Route table - route: ".implode("/", $folders));

The string literal Route table - route: does not require double quotes, as per coding-style, please use single quotes.

The string literal / does not require double quotes, as per coding-style, please use single quotes.

        // This method generate a global regular expression which will be able to match all the URI supported by the route
        $regex = $this->parser->read($folders, $route);

        $this->logger->debug("Route table - route regex: $regex");

As per coding-style, please use concatenation or sprintf for the variable $regex instead of interpolation.

        $this->routes = array_merge($this->routes, [$regex => $route]);

    }

    private function updateRoute(Route $route, $type, $class = null, array $parameters = []) {

        $route->setType($type)
            ->setClassName($class)
            ->setParameters($parameters);

        if ( !empty($parameters['redirect-code']) ) $route->setRedirectCode($parameters['redirect-code']);
        if ( !empty($parameters['redirect-location']) ) $route->setRedirectLocation($parameters['redirect-location']);
        if ( !empty($parameters['redirect-message']) ) $route->setRedirectLocation($parameters['redirect-message']);
        if ( !empty($parameters['redirect-type']) ) $route->setRedirectType($parameters['redirect-type']);

        if ( !empty($parameters['error-code']) ) $route->setErrorCode($parameters['error-code']);
        if ( !empty($parameters['error-message']) ) $route->setErrorMessage($parameters['error-message']);

    }

    private function readCache() {

        if ($this->configuration->get('routing-table-cache') !== true) return;

        $data = $this->cache->read();

        if (is_null($data)) {

The condition is_null($data) is always false.

            $this->routes = [];

            return;

        }

        $this->routes = $data;

        $this->logger->debug("Routing table loaded from cache");

The string literal Routing table loaded from cache does not require double quotes, as per coding-style, please use single quotes.

    }

    private function dumpCache() {

        if ($this->configuration->get('routing-table-cache') !== true) return;

        $ttl = $this->configuration->get('routing-table-ttl');

        if ($this->cache->dump($this->routes, $ttl)) {
            $this->logger->debug("Routing table saved to cache");

The string literal Routing table saved to cache does not require double quotes, as per coding-style, please use single quotes.

        } else {
            $this->logger->warning("Cannot save routing table to cache");

The string literal Cannot save routing table to cache does not require double quotes, as per coding-style, please use single quotes.

        }

    }

}