comodojo / comodojo-installer

src/Actions/App.php

Spacing +7 added lines, -7 removed lines

@@ -59,19 +59,19 @@ 
 
         $update = array_intersect($old_apps, $new_apps);
         
-        foreach ( $uninstall as $app ) {
+        foreach ($uninstall as $app) {
             
             $this->removeApp($io, $package_name, $app, $initial_extra[$app]);
             
         }
         
-        foreach ( $install as $app ) {
+        foreach ($install as $app) {
             
             $this->addApp($io, $package_name, $app, $target_extra[$app]);
             
         }
         
-        foreach ( $update as $app ) {
+        foreach ($update as $app) {
             
             $this->updateApp($io, $package_name, $app, $initial_extra[$app], $target_extra[$app]);
             
@@ -105,7 +105,7 @@ 
 
         try {
             
-            if ( $assets !== null ) {
+            if ($assets !== null) {
             
                 $fs->rcopy($path.'/'.$assets, COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);    
                 
@@ -135,7 +135,7 @@ 
 
             $this->getPackageInstaller()->apps()->delete($id);
             
-            if ( $assets !== null ) {
+            if ($assets !== null) {
 
                 $fs->rmdir(COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);
             
@@ -169,13 +169,13 @@ 
             
             $this->getPackageInstaller()->apps()->update($id, $package_name, $app, $description);
 
-            if ( $old_assets !== null ) {
+            if ($old_assets !== null) {
                 
                 $fs->rmdir(COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);
                 
             }
             
-            if ( $new_assets !== null ) {
+            if ($new_assets !== null) {
                 
                 $fs->rcopy($path.'/'.$new_assets, COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);
                 

src/Actions/Authentication.php

Spacing +7 added lines, -7 removed lines

@@ -59,19 +59,19 @@ 
 
         $update = array_intersect($old_providers, $new_providers);
         
-        foreach ( $uninstall as $provider ) {
+        foreach ($uninstall as $provider) {
             
             $this->removeAuthProvider($io, $package_name, $provider, $initial_extra[$provider]);
             
         }
         
-        foreach ( $install as $provider ) {
+        foreach ($install as $provider) {
             
             $this->addAuthProvider($io, $package_name, $provider, $target_extra[$provider]);
             
         }
         
-        foreach ( $update as $provider ) {
+        foreach ($update as $provider) {
             
             $this->updateAuthProvider($io, $package_name, $provider, $target_extra[$provider]);
             
@@ -97,7 +97,7 @@ 
         
         try {
 
-            if ( !self::validateProvider($configuration) ) throw new InstallerException('Skipping invalid authentication provider '.$provider.' in '.$package_name);
+            if (!self::validateProvider($configuration)) throw new InstallerException('Skipping invalid authentication provider '.$provider.' in '.$package_name);
 
             $class = $configuration['class'];
             
@@ -119,7 +119,7 @@ 
         
         try {
 
-            if ( !self::validateProvider($configuration) ) throw new InstallerException('Skipping invalid authentication provider '.$provider.' in '.$package_name);
+            if (!self::validateProvider($configuration)) throw new InstallerException('Skipping invalid authentication provider '.$provider.' in '.$package_name);
             
             $id = $this->getPackageInstaller()->authentication()->getByName($provider)->getId();
 
@@ -139,7 +139,7 @@ 
         
         try {
 
-            if ( !self::validateProvider($configuration) ) throw new InstallerException('Skipping invalid authentication provider '.$provider.' in '.$package_name);
+            if (!self::validateProvider($configuration)) throw new InstallerException('Skipping invalid authentication provider '.$provider.' in '.$package_name);
 
             $class = $configuration['class'];
             
@@ -161,7 +161,7 @@ 
     
     private static function validateProvider($auth) {
 
-        return !( empty($auth["class"]) );
+        return !(empty($auth["class"]));
 
     }
 

src/Actions/Command.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
             
             try {
 
-                if ( !self::validateCommand($actions) ) throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
+                if (!self::validateCommand($actions)) throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
                 
                 $class = $actions["class"];
 

src/Actions/DispatcherPlugin.php

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 
             try {
 
-                if ( !self::validatePlugin($configuration) ) throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                if (!self::validatePlugin($configuration)) throw new InstallerException('Skipping invalid plugin in '.$package_name);
 
                 $plugin_name = $package_name.'-dispatcher-'.$plugin;
                 
@@ -110,7 +110,7 @@ 
 
     private static function validatePlugin($plugin) {
 
-        return !( empty($plugin["class"]) || empty($plugin["event"]) );
+        return !(empty($plugin["class"]) || empty($plugin["event"]));
 
     }
 

src/Actions/ExtenderPlugin.php

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 
             try {
 
-                if ( !self::validatePlugin($configuration) ) throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                if (!self::validatePlugin($configuration)) throw new InstallerException('Skipping invalid plugin in '.$package_name);
 
                 $plugin_name = $package_name.'-extender-'.$plugin;
                 
@@ -110,7 +110,7 @@ 
 
     private static function validatePlugin($plugin) {
 
-        return !( empty($plugin["class"]) || empty($plugin["event"]) );
+        return !(empty($plugin["class"]) || empty($plugin["event"]));
 
     }
 

src/Actions/ExtenderTask.php

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
 
             try {
 
-                if ( !self::validateTask($task) ) throw new InstallerException('Skipping invalid task in '.$package_name);
+                if (!self::validateTask($task)) throw new InstallerException('Skipping invalid task in '.$package_name);
                 
                 $name = $task['name'];
                 
@@ -111,7 +111,7 @@ 
 
     private static function validateTask($task) {
 
-        return !( empty($task["name"]) || empty($task["class"]) );
+        return !(empty($task["name"]) || empty($task["class"]));
 
     }
 

src/Actions/Rpc.php

Spacing +2 added lines, -2 removed lines

@@ -67,7 +67,7 @@ 
 
             try {
 
-                if ( !self::validateRpc($rpc) ) throw new InstallerException('Skipping invalid rpc service in '.$package_name);
+                if (!self::validateRpc($rpc)) throw new InstallerException('Skipping invalid rpc service in '.$package_name);
                 
                 $callback = $rpc['callback'];
                 
@@ -113,7 +113,7 @@ 
 
     private static function validateRpc($rpc) {
 
-        return !( empty($rpc['callback']) || ( isset($rpc['signatures']) && !is_array($rpc['signatures']) ) );
+        return !(empty($rpc['callback']) || (isset($rpc['signatures']) && !is_array($rpc['signatures'])));
 
     }
 

src/Actions/Service.php

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 
             try {
 
-                if ( !self::validateService($service) ) throw new InstallerException('Skipping invalid service in '.$package_name);
+                if (!self::validateService($service)) throw new InstallerException('Skipping invalid service in '.$package_name);
 
                 $route = $service["route"];
                 
@@ -108,7 +108,7 @@ 
 
     private static function validateService($service) {
 
-        return !( empty($service["route"]) || empty($service["type"]) || empty($service["class"]) );
+        return !(empty($service["route"]) || empty($service["type"]) || empty($service["class"]));
 
     }
 

src/Actions/Setting.php

Spacing +8 added lines, -8 removed lines

@@ -59,19 +59,19 @@ 
 
         $update = array_intersect($old_settings, $new_settings);
         
-        foreach ( $uninstall as $setting ) {
+        foreach ($uninstall as $setting) {
             
             $this->removeSetting($io, $package_name, $setting, $initial_extra[$setting]);
             
         }
         
-        foreach ( $install as $setting ) {
+        foreach ($install as $setting) {
             
             $this->addSetting($io, $package_name, $setting, $target_extra[$setting]);
             
         }
         
-        foreach ( $update as $setting ) {
+        foreach ($update as $setting) {
             
             $this->updateSetting($io, $package_name, $setting, $initial_extra[$setting], $target_extra[$setting]);
             
@@ -97,7 +97,7 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if (!self::validateSetting($value)) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
 
             $this->getPackageInstaller()->settings()->add($package_name, $setting, $value);
 
@@ -115,7 +115,7 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if (!self::validateSetting($value)) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
 
             $id = $this->getPackageInstaller()->settings()->getByName($setting)->getId();
 
@@ -135,17 +135,17 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if (!self::validateSetting($value)) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
 
             $old = $this->getPackageInstaller()->settings()->getByName($setting);
             
-            if ( $old->getValue() == $old_value ) {
+            if ($old->getValue() == $old_value) {
                 
                 $this->getPackageInstaller()->settings()->update($old->getId(), $package_name, $setting, $new_value);
                 
                 $io->write(" <comment>~</comment> updated setting ".$setting);
                 
-            } else if ( $io->askConfirmation("Replace modified setting ".$setting."?", false) === true ) {
+            } else if ($io->askConfirmation("Replace modified setting ".$setting."?", false) === true) {
                 
                 $this->getPackageInstaller()->settings()->update($old->getId(), $package_name, $setting, $new_value);