comodojo / comodojo-installer

src/Actions/App.php

Doc Comments +9 added lines

@@ -93,6 +93,9 @@ 
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     */
     private function addApp($io, $package_name, $app, $configuration) {
         
         $description = empty($configuration['description']) ? null : $configuration['description'];
@@ -123,6 +126,9 @@ 
         
     }
     
+    /**
+     * @param \Composer\IO\IOInterface $io
+     */
     private function removeApp($io, $package_name, $app, $configuration) {
         
         $fs = new Filesystem();
@@ -151,6 +157,9 @@ 
         
     }
     
+    /**
+     * @param \Composer\IO\IOInterface $io
+     */
     private function updateApp($io, $package_name, $app, $old_configuration, $new_configuration) {
         
         $description = empty($new_configuration['description']) ? null : $new_configuration['description'];

Spacing +7 added lines, -7 removed lines

@@ -59,19 +59,19 @@ 
 
         $update = array_intersect($old_apps, $new_apps);
         
-        foreach ( $uninstall as $app ) {
+        foreach ($uninstall as $app) {
             
             $this->removeApp($io, $package_name, $app, $initial_extra[$app]);
             
         }
         
-        foreach ( $install as $app ) {
+        foreach ($install as $app) {
             
             $this->addApp($io, $package_name, $app, $target_extra[$app]);
             
         }
         
-        foreach ( $update as $app ) {
+        foreach ($update as $app) {
             
             $this->updateApp($io, $package_name, $app, $initial_extra[$app], $target_extra[$app]);
             
@@ -105,7 +105,7 @@ 
 
         try {
             
-            if ( $assets !== null ) {
+            if ($assets !== null) {
             
                 $fs->rcopy($path.'/'.$assets, COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);    
                 
@@ -135,7 +135,7 @@ 
 
             $this->getPackageInstaller()->apps()->delete($id);
             
-            if ( $assets !== null ) {
+            if ($assets !== null) {
 
                 $fs->rmdir(COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);
             
@@ -169,13 +169,13 @@ 
             
             $this->getPackageInstaller()->apps()->update($id, $package_name, $app, $description);
 
-            if ( $old_assets !== null ) {
+            if ($old_assets !== null) {
                 
                 $fs->rmdir(COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);
                 
             }
             
-            if ( $new_assets !== null ) {
+            if ($new_assets !== null) {
                 
                 $fs->rcopy($path.'/'.$new_assets, COMODOJO_INSTALLER_WORKING_DIRECTORY.'/'.COMODOJO_INSTALLER_APP_ASSETS.'/'.$app);
                 

src/Actions/Command.php

Doc Comments +4 added lines

@@ -61,6 +61,10 @@
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     * @param string $action
+     */
     private static function processCommand($io, $action, $package_name, $package_extra) {
 
         foreach ($package_extra as $command => $actions) {

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
             
             try {
 
-                if ( !self::validateCommand($actions) ) throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
+                if (!self::validateCommand($actions)) throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
                 
                 $class = $actions["class"];
 

Braces +3 added lines, -1 removed lines

@@ -67,7 +67,9 @@
             
             try {
 
-                if ( !self::validateCommand($actions) ) throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
+                if ( !self::validateCommand($actions) ) {
+                    throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
+                }
                 
                 $class = $actions["class"];
 

src/Actions/DispatcherPlugin.php

Doc Comments +4 added lines

@@ -60,6 +60,10 @@
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     * @param string $action
+     */
     private static function processPlugin($io, $action, $package_name, $package_extra) {
 
         foreach ($package_extra as $plugin => $configuration) {

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 
             try {
 
-                if ( !self::validatePlugin($configuration) ) throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                if (!self::validatePlugin($configuration)) throw new InstallerException('Skipping invalid plugin in '.$package_name);
 
                 $plugin_name = $package_name.'-dispatcher-'.$plugin;
                 
@@ -110,7 +110,7 @@ 
 
     private static function validatePlugin($plugin) {
 
-        return !( empty($plugin["class"]) || empty($plugin["event"]) );
+        return !(empty($plugin["class"]) || empty($plugin["event"]));
 
     }
 

Braces +3 added lines, -1 removed lines

@@ -66,7 +66,9 @@
 
             try {
 
-                if ( !self::validatePlugin($configuration) ) throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                if ( !self::validatePlugin($configuration) ) {
+                    throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                }
 
                 $plugin_name = $package_name.'-dispatcher-'.$plugin;
                 

src/Actions/ExtenderPlugin.php

Doc Comments +4 added lines

@@ -60,6 +60,10 @@
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     * @param string $action
+     */
     private static function processPlugin($io, $action, $package_name, $package_extra) {
 
         foreach ($package_extra as $plugin => $configuration) {

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 
             try {
 
-                if ( !self::validatePlugin($configuration) ) throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                if (!self::validatePlugin($configuration)) throw new InstallerException('Skipping invalid plugin in '.$package_name);
 
                 $plugin_name = $package_name.'-extender-'.$plugin;
                 
@@ -110,7 +110,7 @@ 
 
     private static function validatePlugin($plugin) {
 
-        return !( empty($plugin["class"]) || empty($plugin["event"]) );
+        return !(empty($plugin["class"]) || empty($plugin["event"]));
 
     }
 

Braces +3 added lines, -1 removed lines

@@ -66,7 +66,9 @@
 
             try {
 
-                if ( !self::validatePlugin($configuration) ) throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                if ( !self::validatePlugin($configuration) ) {
+                    throw new InstallerException('Skipping invalid plugin in '.$package_name);
+                }
 
                 $plugin_name = $package_name.'-extender-'.$plugin;
                 

src/Actions/Rpc.php

Doc Comments +4 added lines

@@ -61,6 +61,10 @@
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     * @param string $action
+     */
     private static function processRpc($io, $action, $package_name, $package_extra) {
 
         foreach ($package_extra as $rpc_method => $rpc) {

Spacing +2 added lines, -2 removed lines

@@ -67,7 +67,7 @@ 
 
             try {
 
-                if ( !self::validateRpc($rpc) ) throw new InstallerException('Skipping invalid rpc service in '.$package_name);
+                if (!self::validateRpc($rpc)) throw new InstallerException('Skipping invalid rpc service in '.$package_name);
                 
                 $callback = $rpc['callback'];
                 
@@ -113,7 +113,7 @@ 
 
     private static function validateRpc($rpc) {
 
-        return !( empty($rpc['callback']) || ( isset($rpc['signatures']) && !is_array($rpc['signatures']) ) );
+        return !(empty($rpc['callback']) || (isset($rpc['signatures']) && !is_array($rpc['signatures'])));
 
     }
 

Braces +3 added lines, -1 removed lines

@@ -67,7 +67,9 @@
 
             try {
 
-                if ( !self::validateRpc($rpc) ) throw new InstallerException('Skipping invalid rpc service in '.$package_name);
+                if ( !self::validateRpc($rpc) ) {
+                    throw new InstallerException('Skipping invalid rpc service in '.$package_name);
+                }
                 
                 $callback = $rpc['callback'];
                 

src/Actions/Service.php

Doc Comments +4 added lines

@@ -60,6 +60,10 @@
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     * @param string $action
+     */
     private static function processService($io, $action, $package_name, $package_extra) {
 
         foreach ($package_extra as $service) {

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
 
             try {
 
-                if ( !self::validateService($service) ) throw new InstallerException('Skipping invalid service in '.$package_name);
+                if (!self::validateService($service)) throw new InstallerException('Skipping invalid service in '.$package_name);
 
                 $route = $service["route"];
                 
@@ -108,7 +108,7 @@ 
 
     private static function validateService($service) {
 
-        return !( empty($service["route"]) || empty($service["type"]) || empty($service["class"]) );
+        return !(empty($service["route"]) || empty($service["type"]) || empty($service["class"]));
 
     }
 

Braces +3 added lines, -1 removed lines

@@ -66,7 +66,9 @@
 
             try {
 
-                if ( !self::validateService($service) ) throw new InstallerException('Skipping invalid service in '.$package_name);
+                if ( !self::validateService($service) ) {
+                    throw new InstallerException('Skipping invalid service in '.$package_name);
+                }
 
                 $route = $service["route"];
                 

src/Actions/Setting.php

Doc Comments +9 added lines

@@ -93,6 +93,9 @@ 
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     */
     private function addSetting($io, $package_name, $setting, $value) {
         
         try {
@@ -111,6 +114,9 @@ 
         
     }
     
+    /**
+     * @param \Composer\IO\IOInterface $io
+     */
     private function removeSetting($io, $package_name, $setting, $value) {
         
         try {
@@ -131,6 +137,9 @@ 
         
     }
     
+    /**
+     * @param \Composer\IO\IOInterface $io
+     */
     private function updateSetting($io, $package_name, $setting, $old_value, $new_value) {
         
         try {

Spacing +8 added lines, -8 removed lines

@@ -59,19 +59,19 @@ 
 
         $update = array_intersect($old_settings, $new_settings);
         
-        foreach ( $uninstall as $setting ) {
+        foreach ($uninstall as $setting) {
             
             $this->removeSetting($io, $package_name, $setting, $initial_extra[$setting]);
             
         }
         
-        foreach ( $install as $setting ) {
+        foreach ($install as $setting) {
             
             $this->addSetting($io, $package_name, $setting, $target_extra[$setting]);
             
         }
         
-        foreach ( $update as $setting ) {
+        foreach ($update as $setting) {
             
             $this->updateSetting($io, $package_name, $setting, $initial_extra[$setting], $target_extra[$setting]);
             
@@ -97,7 +97,7 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if (!self::validateSetting($value)) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
 
             $this->getPackageInstaller()->settings()->add($package_name, $setting, $value);
 
@@ -115,7 +115,7 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if (!self::validateSetting($value)) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
 
             $id = $this->getPackageInstaller()->settings()->getByName($setting)->getId();
 
@@ -135,17 +135,17 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if (!self::validateSetting($value)) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
 
             $old = $this->getPackageInstaller()->settings()->getByName($setting);
             
-            if ( $old->getValue() == $old_value ) {
+            if ($old->getValue() == $old_value) {
                 
                 $this->getPackageInstaller()->settings()->update($old->getId(), $package_name, $setting, $new_value);
                 
                 $io->write(" <comment>~</comment> updated setting ".$setting);
                 
-            } else if ( $io->askConfirmation("Replace modified setting ".$setting."?", false) === true ) {
+            } else if ($io->askConfirmation("Replace modified setting ".$setting."?", false) === true) {
                 
                 $this->getPackageInstaller()->settings()->update($old->getId(), $package_name, $setting, $new_value);
                 

Braces +9 added lines, -3 removed lines

@@ -97,7 +97,9 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if ( !self::validateSetting($value) ) {
+                throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            }
 
             $this->getPackageInstaller()->settings()->add($package_name, $setting, $value);
 
@@ -115,7 +117,9 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if ( !self::validateSetting($value) ) {
+                throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            }
 
             $id = $this->getPackageInstaller()->settings()->getByName($setting)->getId();
 
@@ -135,7 +139,9 @@ 
         
         try {
 
-            if ( !self::validateSetting($value) ) throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            if ( !self::validateSetting($value) ) {
+                throw new InstallerException('Skipping invalid setting '.$setting.' in '.$package_name);
+            }
 
             $old = $this->getPackageInstaller()->settings()->getByName($setting);
             

src/Actions/Theme.php

Doc Comments +4 added lines

@@ -61,6 +61,10 @@
 
     }
 
+    /**
+     * @param \Composer\IO\IOInterface $io
+     * @param string $action
+     */
     private function processTheme($io, $action, $package_name, $package_extra) {
 
         foreach ($package_extra as $theme => $configuration) {

Spacing +2 added lines, -2 removed lines

@@ -67,7 +67,7 @@ 
 
             try {
 
-                if ( !self::validateTheme($configuration) ) throw new InstallerException('Skipping invalid theme in '.$package_name);
+                if (!self::validateTheme($configuration)) throw new InstallerException('Skipping invalid theme in '.$package_name);
 
                 $assets = $configuration['assets'];
                 
@@ -115,7 +115,7 @@ 
 
     private static function validateTheme($theme) {
 
-        return !( empty($theme['assets']) );
+        return !(empty($theme['assets']));
 
     }
 

Braces +3 added lines, -1 removed lines

@@ -67,7 +67,9 @@
 
             try {
 
-                if ( !self::validateTheme($configuration) ) throw new InstallerException('Skipping invalid theme in '.$package_name);
+                if ( !self::validateTheme($configuration) ) {
+                    throw new InstallerException('Skipping invalid theme in '.$package_name);
+                }
 
                 $assets = $configuration['assets'];
                 

src/Installer.php

Doc Comments +10 added lines

@@ -89,6 +89,9 @@ 
 
     }
 
+    /**
+     * @param PackageInterface $package
+     */
     private function packageInstall($package) {
 
         $actions_map = Parser::parse($package);
@@ -111,6 +114,9 @@ 
 
     }
 
+    /**
+     * @param PackageInterface $package
+     */
     private function packageUninstall($package) {
 
         $actions_map = Parser::parse($package);
@@ -133,6 +139,10 @@ 
 
     }
 
+    /**
+     * @param PackageInterface $initial
+     * @param PackageInterface $target
+     */
     private function packageUpdate($initial, $target) {
 
         $initial_actions_map = Parser::parse($initial);

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Composer\Installer\LibraryInstaller;
 use Composer\Package\PackageInterface;
 use Composer\Repository\InstalledRepositoryInterface;
-use Comodojo\Exception\InstallerException;
 use Comodojo\Installer\Properties\Parser;
 use Comodojo\Installer\Registry\SupportedTypes;
 use Comodojo\Configuration\Installer as PackageInstaller;

Spacing +5 added lines, -5 removed lines

@@ -101,7 +101,7 @@ 
 
         foreach ($actions_map as $action_class => $extra) {
 
-            $action_fqcn = 'Comodojo\\Installer\\Actions\\' . $action_class;
+            $action_fqcn = 'Comodojo\\Installer\\Actions\\'.$action_class;
 
             $action = new $action_fqcn($this->composer, $this->io, $package_path, $installer);
 
@@ -123,7 +123,7 @@ 
 
         foreach ($actions_map as $action_class => $extra) {
 
-            $action_fqcn = 'Comodojo\\Installer\\Actions\\' . $action_class;
+            $action_fqcn = 'Comodojo\\Installer\\Actions\\'.$action_class;
 
             $action = new $action_fqcn($this->composer, $this->io, $package_path, $installer);
 
@@ -161,7 +161,7 @@ 
 
         foreach ($uninstall as $action_uninstall) {
 
-            $action_fqcn = 'Comodojo\\Installer\\Actions\\' . $action_uninstall;
+            $action_fqcn = 'Comodojo\\Installer\\Actions\\'.$action_uninstall;
 
             $action = new $action_fqcn($this->composer, $this->io, $initial_package_path, $installer);
 
@@ -171,7 +171,7 @@ 
 
         foreach ($install as $action_install) {
 
-            $action_fqcn = 'Comodojo\\Installer\\Actions\\' . $action_install;
+            $action_fqcn = 'Comodojo\\Installer\\Actions\\'.$action_install;
 
             $action = new $action_fqcn($this->composer, $this->io, $target_package_path, $installer);
 
@@ -181,7 +181,7 @@ 
 
         foreach ($update as $action_update) {
 
-            $action_fqcn = 'Comodojo\\Installer\\Actions\\' . $action_update;
+            $action_fqcn = 'Comodojo\\Installer\\Actions\\'.$action_update;
 
             $action = new $action_fqcn($this->composer, $this->io, $target_package_path, $installer);