Command::processCommand() - Code Metrics - comodojo/comodojo-installer - Measure and Improve Code Quality continuously with Scrutinizer

Command::processCommand() F
last analyzed 2016-01-31 19:17 UTC

↳ Parent: Command

Complexity

Conditions	13
Paths	817

Size

Total Lines	51
Code Lines	23

Duplication

Lines	23
Ratio	45.1 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	23
loc	51
rs	3.1052
cc	13
eloc	23
nc	817
nop	4

How to fix Long Method Complexity

<?php namespace Comodojo\Installer\Actions;

use \Comodojo\Exception\InstallerException;
use \Exception;

/**
 *
 *
 * @package     Comodojo Framework
 * @author      Marco Giovinazzi <[email protected]>
 * @author      Marco Castiello <[email protected]>
 * @license     GPL-3.0+
 *
 * LICENSE:
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Affero General Public License as
 * published by the Free Software Foundation, either version 3 of the
 * License, or (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Affero General Public License for more details.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

class Command extends AbstractAction {

    public function install($package_name, $package_extra) {


        $io = $this->getIO();

        $io->write("<info>>>> Installing (extender) commands from package ".$package_name."</info>");

        self::processCommand($io, 'install', $package_name, $package_extra);

    }

    public function update($package_name, $initial_extra, $target_extra) {

        $io = $this->getIO();

        $io->write("<info>>>> Updating (extender) commands from package ".$package_name."</info>");

        self::processCommand($io, 'uninstall', $package_name, $package_extra);


        self::processCommand($io, 'install', $package_name, $package_extra);

    }

    public function uninstall($package_name, $package_extra) {

        $io = $this->getIO();

        $io->write("<info>>>> Removing (extender) commands from package ".$package_name."</info>");

        self::processCommand($io, 'uninstall', $package_name, $package_extra);

    }

    private static function processCommand($io, $action, $package_name, $package_extra) {

        foreach ($package_extra as $command => $actions) {
            
            try {

                if ( !self::validateCommand($actions) ) throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
                
                $class = $actions["class"];

                $description = empty($actions["description"]) ? null : $actions["description"];

                $aliases = isset($actions["aliases"]) && is_array($actions["aliases"]) ? $actions["aliases"] : array();
                
                $options = isset($actions["options"]) && is_array($actions["options"]) ? $actions["options"] : array();
                
                $arguments = isset($actions["arguments"]) && is_array($actions["arguments"]) ? $actions["arguments"] : array();
    
                switch ($action) {


                    case 'install':
                        
                        $this->getPackageInstaller()

                            ->commands()
                            ->add($package_name, $command, $class, $description, $aliases, $options, $arguments);

                        $io->write(" <info>+</info> enabled command ".$command);

                        break;

                    case 'uninstall':
                        
                        $id = $this->getPackageInstaller()->commands()->getByName($name)->getId();


                        $this->getPackageInstaller()->commands()->delete($id);

                        $io->write(" <comment>-</comment> disabled command ".$command);

                        break;

                }

            } catch (Exception $e) {

                $io->write('<error>Error processing command: '.$e->getMessage().'</error>');

            }

        }

    }

    private static function validateCommand($actions) {

        return !empty($actions["class"]);

    }

}


1		<?php namespace Comodojo\Installer\Actions;
2
3		use \Comodojo\Exception\InstallerException;
4		use \Exception;
5
6		/**
7		*
8		*
9		* @package Comodojo Framework
10		* @author Marco Giovinazzi <[email protected]>
11		* @author Marco Castiello <[email protected]>
12		* @license GPL-3.0+
13		*
14		* LICENSE:
15		*
16		* This program is free software: you can redistribute it and/or modify
17		* it under the terms of the GNU Affero General Public License as
18		* published by the Free Software Foundation, either version 3 of the
19		* License, or (at your option) any later version.
20		*
21		* This program is distributed in the hope that it will be useful,
22		* but WITHOUT ANY WARRANTY; without even the implied warranty of
23		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
24		* GNU Affero General Public License for more details.
25		*
26		* You should have received a copy of the GNU Affero General Public License
27		* along with this program. If not, see <http://www.gnu.org/licenses/>.
28		*/
29
30		class Command extends AbstractAction {
31
32	View Code Duplication	public function install($package_name, $package_extra) {
		0 ignored issues – show Duplication introduced 2016-01-31 19:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33
34		$io = $this->getIO();
35
36		$io->write("<info>>>> Installing (extender) commands from package ".$package_name."</info>");
37
38		self::processCommand($io, 'install', $package_name, $package_extra);
39
40		}
41
42		public function update($package_name, $initial_extra, $target_extra) {
43
44		$io = $this->getIO();
45
46		$io->write("<info>>>> Updating (extender) commands from package ".$package_name."</info>");
47
48		self::processCommand($io, 'uninstall', $package_name, $package_extra);
		0 ignored issues – show Bug introduced 2016-01-31 19:17 UTC by Report Bug Copy Issue Report The variable `$package_extra` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
49
50		self::processCommand($io, 'install', $package_name, $package_extra);
51
52		}
53
54		public function uninstall($package_name, $package_extra) {
55
56		$io = $this->getIO();
57
58		$io->write("<info>>>> Removing (extender) commands from package ".$package_name."</info>");
59
60		self::processCommand($io, 'uninstall', $package_name, $package_extra);
61
62		}
63
64		private static function processCommand($io, $action, $package_name, $package_extra) {
65
66		foreach ($package_extra as $command => $actions) {
67
68		try {
69
70		if ( !self::validateCommand($actions) ) throw new InstallerException('Skipping invalid command '.$command.' in '.$package_name);
71
72		$class = $actions["class"];
73
74		$description = empty($actions["description"]) ? null : $actions["description"];
75
76		$aliases = isset($actions["aliases"]) && is_array($actions["aliases"]) ? $actions["aliases"] : array();
77
78		$options = isset($actions["options"]) && is_array($actions["options"]) ? $actions["options"] : array();
79
80		$arguments = isset($actions["arguments"]) && is_array($actions["arguments"]) ? $actions["arguments"] : array();
81
82	View Code Duplication	switch ($action) {
		0 ignored issues – show Duplication introduced 2016-01-31 19:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83
84		case 'install':
85
86		$this->getPackageInstaller()
		0 ignored issues – show Bug introduced 2016-01-31 19:17 UTC by Report Bug Copy Issue Report The variable `$this` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
87		->commands()
88		->add($package_name, $command, $class, $description, $aliases, $options, $arguments);
89
90		$io->write(" <info>+</info> enabled command ".$command);
91
92		break;
93
94		case 'uninstall':
95
96		$id = $this->getPackageInstaller()->commands()->getByName($name)->getId();
		0 ignored issues – show Bug introduced 2016-01-31 19:17 UTC by Report Bug Copy Issue Report The variable `$name` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
97
98		$this->getPackageInstaller()->commands()->delete($id);
99
100		$io->write(" <comment>-</comment> disabled command ".$command);
101
102		break;
103
104		}
105
106		} catch (Exception $e) {
107
108		$io->write('<error>Error processing command: '.$e->getMessage().'</error>');
109
110		}
111
112		}
113
114		}
115
116		private static function validateCommand($actions) {
117
118		return !empty($actions["class"]);
119
120		}
121
122		}
123

comodojo / comodojo-installer

Command::processCommand() F last analyzed 2016-01-31 19:17 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Command::processCommand() F
last analyzed 2016-01-31 19:17 UTC