Task   A
last analyzed

Complexity

Total Complexity 11

Size/Duplication

Total Lines 85
Duplicated Lines 61.18 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 11
c 1
b 0
f 0
lcom 1
cbo 2
dl 52
loc 85
rs 10

5 Methods

Rating   Name   Duplication   Size   Complexity  
A install() 9 9 1
A update() 0 11 1
A uninstall() 0 9 1
C processTask() 43 43 7
A validateTask() 0 5 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php namespace Comodojo\Installer\Actions;
2
3
use \Comodojo\Exception\InstallerException;
4
use \Exception;
5
6
/**
7
 *
8
 *
9
 * @package     Comodojo Framework
10
 * @author      Marco Giovinazzi <[email protected]>
11
 * @author      Marco Castiello <[email protected]>
12
 * @license     GPL-3.0+
13
 *
14
 * LICENSE:
15
 *
16
 * This program is free software: you can redistribute it and/or modify
17
 * it under the terms of the GNU Affero General Public License as
18
 * published by the Free Software Foundation, either version 3 of the
19
 * License, or (at your option) any later version.
20
 *
21
 * This program is distributed in the hope that it will be useful,
22
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
23
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
24
 * GNU Affero General Public License for more details.
25
 *
26
 * You should have received a copy of the GNU Affero General Public License
27
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
28
 */
29
30
class Task extends AbstractAction {
31
32 View Code Duplication
    public function install($package_name, $package_extra) {
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
33
34
        $io = $this->getIO();
35
36
        $io->write("<info>>>> Installing (extender) tasks from package ".$package_name."</info>");
37
38
        $this->processTask($io, 'install', $package_name, $package_extra);
39
40
    }
41
42
    public function update($package_name, $initial_extra, $target_extra) {
43
44
        $io = $this->getIO();
45
46
        $io->write("<info>>>> Updating (extender) tasks from package ".$package_name."</info>");
47
48
        $this->processTask($io, 'uninstall', $package_name, $initial_extra);
49
        
50
        $this->processTask($io, 'install', $package_name, $target_extra);
51
52
    }
53
54
    public function uninstall($package_name, $package_extra) {
55
56
        $io = $this->getIO();
57
58
        $io->write("<info>>>> Removing (extender) tasks from package ".$package_name."</info>");
59
60
        $this->processTask($io, 'uninstall', $package_name, $package_extra);
61
62
    }
63
64 View Code Duplication
    private function processTask($io, $action, $package_name, $package_extra) {
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
65
66
        foreach ($package_extra as $name => $task) {
67
68
            try {
69
70
                if ( !self::validateTask($task) ) throw new InstallerException('Skipping invalid task in '.$package_name);
71
                
72
                $class = $task['class'];
73
                
74
                $description = empty($task['description']) ? null : $task['description'];
75
76
                switch ($action) {
77
78
                    case 'install':
79
                        
80
                        $this->getPackageInstaller()->tasks()->add($package_name, $name, $class, $description);
81
82
                        $io->write(" <info>+</info> enabled task ".$name);
83
84
                        break;
85
86
                    case 'uninstall':
87
                        
88
                        $id = $this->getPackageInstaller()->tasks()->getByName($name)->getId();
89
90
                        $this->getPackageInstaller()->tasks()->delete($id);
91
92
                        $io->write(" <comment>-</comment> disabled task ".$name." (id ".$id.")");
93
94
                        break;
95
96
                }
97
98
            } catch (Exception $e) {
99
100
                $io->write('<error>Error processing task: '.$e->getMessage().'</error>');
101
102
            }
103
104
        }
105
106
    }
107
108
    private static function validateTask($task) {
109
110
        return !( empty($task["class"]) );
111
112
    }
113
114
}
115