GenericManagerTrait::clear() - Code Metrics - Inspection of "add configuration parser" - comodojo/cache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( a51c1d...cacff6 )

by Marco

created 2017-01-25 15:41 UTC

GenericManagerTrait::clear() A

↳ Parent: GenericManagerTrait

Complexity

Conditions	4
Paths	3

Size

Total Lines	17
Code Lines	7

Duplication

Lines	17
Ratio	100 %

Code Coverage

Tests	6
CRAP Score	4.0466

Importance

Changes

Metric	Value
dl	17
loc	17
ccs	6
cts	7
cp	0.8571
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	3
nop	0
crap	4.0466

<?php namespace Comodojo\Cache\Traits;

/**
 *
 *
 * @package     Comodojo Spare Parts
 * @author      Marco Giovinazzi <[email protected]>
 * @license     MIT
 *
 * LICENSE:
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

trait GenericManagerTrait {

    public function genericAddProvider($provider, $weight = 0) {

        $this->stack->add($provider, $weight);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;

    }

    public function removeProvider($id) {

        return $this->stack->remove($id);

    }

    public function getProvider($id) {

        return $this->stack->get($id);

    }

    public function getProviders($enabled = false) {

        return $this->stack->getAll($enabled);

    }

    public function getSelectedProvider() {

        return $this->selected === null ? $this->vacuum : $this->selected;
class MyClass { }

$x = new MyClass();
$x->foo = true;

    }

    public function clear() {


        if ( $this->align_cache === false && $this->pick_mode < 5) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return $this->selectProvider()->clear();
        }

        $result = [];

        foreach ($this->stack as $provider) {

            $result[] = $provider[0]->clear();

        }

        return !in_array(false, $result);

    }

    public function setNamespace($namespace = null) {

        foreach ($this->stack->getAll(false) as $provider) {
            $provider->setNamespace($namespace);
        }

        $this->namespace = empty($namespace) ? "GLOBAL" : $namespace;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;

    }

    public function clearNamespace() {


        if ( $this->align_cache === false && $this->pick_mode < 5) {
            return $this->selectProvider()->clearNamespace();
        }

        $result = [];

        foreach ($this->stack->getAll() as $provider) {
            $result[] = $provider->clearNamespace();
        }

        return !in_array(false, $result);

    }

    public function getStats() {

        $stats = [];

        foreach ($this->stack->getAll(false) as $provider) {
            $stats[] = $provider->getStats();
        }

        return $stats;

    }

    protected function selectProvider() {

        switch ($this->pick_mode) {

            case 1:
                $provider = $this->stack->getFirstProvider();
                break;
            case 2:
                $provider = $this->stack->getLastProvider();
                break;
            case 3:
                $provider = $this->stack->getRandomProvider();
                break;
            case 4:
                $provider = $this->stack->getHeavyProvider();
                break;

        }

        $this->selected = $provider == null ? $this->vacuum : $provider;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        return $this->selected;

    }

}


1			<?php namespace Comodojo\Cache\Traits;
2
3			/**
4			*
5			*
6			* @package Comodojo Spare Parts
7			* @author Marco Giovinazzi <[email protected]>
8			* @license MIT
9			*
10			* LICENSE:
11			*
12			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
13			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
14			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
15			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
16			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
17			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
18			* THE SOFTWARE.
19			*/
20
21			trait GenericManagerTrait {
22
23	73		public function genericAddProvider($provider, $weight = 0) {
24
25	73		$this->stack->add($provider, $weight);
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `stack` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26
27	73		return $this;
28
29			}
30
31			public function removeProvider($id) {
32
33			return $this->stack->remove($id);
34
35			}
36
37			public function getProvider($id) {
38
39			return $this->stack->get($id);
40
41			}
42
43			public function getProviders($enabled = false) {
44
45			return $this->stack->getAll($enabled);
46
47			}
48
49	29		public function getSelectedProvider() {
50
51	29		return $this->selected === null ? $this->vacuum : $this->selected;
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `selected` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-01-25 15:46 UTC by Report Bug Copy Issue Report The property `vacuum` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52
53			}
54
55	9	View Code Duplication	public function clear() {
			0 ignored issues – show Duplication introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56
57	9		if ( $this->align_cache === false && $this->pick_mode < 5) {
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `align_cache` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `pick_mode` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
58			return $this->selectProvider()->clear();
59			}
60
61	9		$result = [];
62
63	9		foreach ($this->stack as $provider) {
64
65	9		$result[] = $provider[0]->clear();
66
67			}
68
69	9		return !in_array(false, $result);
70
71			}
72
73	4		public function setNamespace($namespace = null) {
74
75	4		foreach ($this->stack->getAll(false) as $provider) {
76	4		$provider->setNamespace($namespace);
77			}
78
79	4		$this->namespace = empty($namespace) ? "GLOBAL" : $namespace;
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `namespace` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
80
81	4		return $this;
82
83			}
84
85	2	View Code Duplication	public function clearNamespace() {
			0 ignored issues – show Duplication introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86
87	2		if ( $this->align_cache === false && $this->pick_mode < 5) {
88			return $this->selectProvider()->clearNamespace();
89			}
90
91	2		$result = [];
92
93	2		foreach ($this->stack->getAll() as $provider) {
94	2		$result[] = $provider->clearNamespace();
95			}
96
97	2		return !in_array(false, $result);
98
99			}
100
101	2		public function getStats() {
102
103	2		$stats = [];
104
105	2		foreach ($this->stack->getAll(false) as $provider) {
106	2		$stats[] = $provider->getStats();
107			}
108
109	2		return $stats;
110
111			}
112
113	61		protected function selectProvider() {
114
115	61		switch ($this->pick_mode) {
116
117	61		case 1:
118	46		$provider = $this->stack->getFirstProvider();
119	46		break;
120	15		case 2:
121	11		$provider = $this->stack->getLastProvider();
122	11		break;
123	4		case 3:
124	4		$provider = $this->stack->getRandomProvider();
125	4		break;
126			case 4:
127			$provider = $this->stack->getHeavyProvider();
128			break;
129
130			}
131
132	61		$this->selected = $provider == null ? $this->vacuum : $provider;
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The variable `$provider` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
133
134	61		return $this->selected;
135
136			}
137
138			}
139

comodojo / cache

Push — 2.0 ( a51c1d...cacff6 )

GenericManagerTrait::clear() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like