GenericManagerTrait - Code Metrics - Inspection of "Merge branch 'master' into 2.0" - comodojo/cache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.0 ( 8b0753...eaa66b )

by Marco

created 2018-06-11 22:01 UTC

GenericManagerTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	110
Duplicated Lines	21.82 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

93.62%

Importance

Changes

Metric	Value
wmc	21
lcom	1
cbo	0
dl	24
loc	110
ccs	44
cts	47
cp	0.9362
rs	10
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	genericAddProvider()	0	7	1
A	removeProvider()	0	5	1
A	getProvider()	0	5	1
A	getProviders()	0	5	1
A	getSelectedProvider()	0	5	2
A	setNamespace()	0	11	3
A	getStats()	0	11	2
B	selectProvider()	0	24	6
A	clear()	13	13	2
A	clearNamespace()	11	11	2

How to fix Duplicated Code

<?php namespace Comodojo\Cache\Traits;

/**
 * @package     Comodojo Cache
 * @author      Marco Giovinazzi <[email protected]>
 * @license     MIT
 *
 * LICENSE:
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

trait GenericManagerTrait {

    public function genericAddProvider($provider, $weight = 0) {

        $this->stack->add($provider, $weight);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;

    }

    public function removeProvider($id) {

        return $this->stack->remove($id);

    }

    public function getProvider($id) {

        return $this->stack->get($id);

    }

    public function getProviders($enabled = false) {

        return $this->stack->getAll($enabled);

    }

    public function getSelectedProvider() {

        return $this->selected === null ? $this->vacuum : $this->selected;
class MyClass { }

$x = new MyClass();
$x->foo = true;

    }

    public function clear() {


        $result = [];

        foreach ( $this->stack->getAll() as $provider ) {

            $result[] = $provider->clear();

        }

        return !in_array(false, $result);

    }

    public function setNamespace($namespace = null) {

        foreach ( $this->stack->getAll(false) as $provider ) {
            $provider->setNamespace($namespace);
        }

        $this->namespace = empty($namespace) ? "GLOBAL" : $namespace;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return $this;

    }

    public function clearNamespace() {


        $result = [];

        foreach ( $this->stack->getAll() as $provider ) {
            $result[] = $provider->clearNamespace();
        }

        return !in_array(false, $result);

    }

    public function getStats() {

        $stats = [];

        foreach ( $this->stack->getAll(false) as $provider ) {
            $stats[] = $provider->getStats();
        }

        return $stats;

    }

    protected function selectProvider() {

        switch ( $this->pick_mode ) {
class MyClass { }

$x = new MyClass();
$x->foo = true;

            case 1:
                $provider = $this->stack->getFirstProvider();
                break;
            case 2:
                $provider = $this->stack->getLastProvider();
                break;
            case 3:
                $provider = $this->stack->getRandomProvider();
                break;
            case 4:
                $provider = $this->stack->getHeavyProvider();
                break;

        }

        $this->selected = $provider == null ? $this->vacuum : $provider;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

        return $this->selected;

    }

}


1			<?php namespace Comodojo\Cache\Traits;
2
3			/**
4			* @package Comodojo Cache
5			* @author Marco Giovinazzi <[email protected]>
6			* @license MIT
7			*
8			* LICENSE:
9			*
10			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
11			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
12			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
13			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
14			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
15			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
16			* THE SOFTWARE.
17			*/
18
19			trait GenericManagerTrait {
20
21	79		public function genericAddProvider($provider, $weight = 0) {
22
23	79		$this->stack->add($provider, $weight);
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `stack` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24
25	79		return $this;
26
27			}
28
29	2		public function removeProvider($id) {
30
31	2		return $this->stack->remove($id);
32
33			}
34
35	2		public function getProvider($id) {
36
37	2		return $this->stack->get($id);
38
39			}
40
41	2		public function getProviders($enabled = false) {
42
43	2		return $this->stack->getAll($enabled);
44
45			}
46
47	29		public function getSelectedProvider() {
48
49	29		return $this->selected === null ? $this->vacuum : $this->selected;
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `selected` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-01-25 15:46 UTC by Report Bug Copy Issue Report The property `vacuum` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
50
51			}
52
53	11	View Code Duplication	public function clear() {
			0 ignored issues – show Duplication introduced 2017-08-22 22:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54
55	11		$result = [];
56
57	11		foreach ( $this->stack->getAll() as $provider ) {
58
59	9		$result[] = $provider->clear();
60
61			}
62
63	11		return !in_array(false, $result);
64
65			}
66
67	6		public function setNamespace($namespace = null) {
68
69	6		foreach ( $this->stack->getAll(false) as $provider ) {
70	4		$provider->setNamespace($namespace);
71			}
72
73	6		$this->namespace = empty($namespace) ? "GLOBAL" : $namespace;
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The property `namespace` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
74
75	6		return $this;
76
77			}
78
79	4	View Code Duplication	public function clearNamespace() {
			0 ignored issues – show Duplication introduced 2017-08-22 22:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80
81	4		$result = [];
82
83	4		foreach ( $this->stack->getAll() as $provider ) {
84	2		$result[] = $provider->clearNamespace();
85			}
86
87	4		return !in_array(false, $result);
88
89			}
90
91	2		public function getStats() {
92
93	2		$stats = [];
94
95	2		foreach ( $this->stack->getAll(false) as $provider ) {
96	2		$stats[] = $provider->getStats();
97			}
98
99	2		return $stats;
100
101			}
102
103	66		protected function selectProvider() {
104
105	66		switch ( $this->pick_mode ) {
			0 ignored issues – show Bug introduced 2017-06-02 23:12 UTC by Report Bug Copy Issue Report The property `pick_mode` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
106
107	66		case 1:
108	51		$provider = $this->stack->getFirstProvider();
109	51		break;
110	15		case 2:
111	11		$provider = $this->stack->getLastProvider();
112	11		break;
113	4		case 3:
114	4		$provider = $this->stack->getRandomProvider();
115	4		break;
116			case 4:
117			$provider = $this->stack->getHeavyProvider();
118			break;
119
120			}
121
122	66		$this->selected = $provider == null ? $this->vacuum : $provider;
			0 ignored issues – show Bug introduced 2017-01-24 23:07 UTC by Report Bug Copy Issue Report The variable `$provider` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
123
124	66		return $this->selected;
125
126			}
127
128			}
129

comodojo / cache

Push — 2.0 ( 8b0753...eaa66b )

GenericManagerTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like