Comodojo\Cache\Traits\GenericManagerTrait

Complexity

Total Complexity

21

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Test Coverage

Coverage

93.62%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getSelectedProvider()	0	3	2
A	clear()	0	11	2
A	getProviders()	0	3	1
A	selectProvider()	0	22	6
A	getStats()	0	9	2
A	getProvider()	0	3	1
A	clearNamespace()	0	9	2
A	setNamespace()	0	9	3
A	removeProvider()	0	3	1
A	genericAddProvider()	0	5	1

<?php namespace Comodojo\Cache\Traits;

/**
 * @package     Comodojo Cache
 * @author      Marco Giovinazzi <marco.giovinazzi@comodojo.org>
 * @license     MIT
 *
 * LICENSE:
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

trait GenericManagerTrait {

    public function genericAddProvider($provider, $weight = 0) {

        $this->stack->add($provider, $weight);

        return $this;

    }

    public function removeProvider($id) {

        return $this->stack->remove($id);

    }

    public function getProvider($id) {

        return $this->stack->get($id);

    }

    public function getProviders($enabled = false) {

        return $this->stack->getAll($enabled);

    }

    public function getSelectedProvider() {

        return $this->selected === null ? $this->vacuum : $this->selected;

    }

    public function clear() {

        $result = [];

        foreach ( $this->stack->getAll() as $provider ) {

            $result[] = $provider->clear();

        }

        return !in_array(false, $result);

    }

    public function setNamespace($namespace = null) {

        foreach ( $this->stack->getAll(false) as $provider ) {
            $provider->setNamespace($namespace);
        }

        $this->namespace = empty($namespace) ? "GLOBAL" : $namespace;

The property namespace does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this;

    }

    public function clearNamespace() {

        $result = [];

        foreach ( $this->stack->getAll() as $provider ) {
            $result[] = $provider->clearNamespace();
        }

        return !in_array(false, $result);

    }

    public function getStats() {

        $stats = [];

        foreach ( $this->stack->getAll(false) as $provider ) {
            $stats[] = $provider->getStats();
        }

        return $stats;

    }

    protected function selectProvider() {

        switch ( $this->pick_mode ) {

            case 1:
                $provider = $this->stack->getFirstProvider();
                break;
            case 2:
                $provider = $this->stack->getLastProvider();
                break;
            case 3:
                $provider = $this->stack->getRandomProvider();
                break;
            case 4:
                $provider = $this->stack->getHeavyProvider();
                break;

        }

        $this->selected = $provider == null ? $this->vacuum : $provider;

The variable $provider does not seem to be defined for all execution paths leading up to this point.

The property selected does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return $this->selected;

    }

}