Comodojo\Cache\Traits\BasicCacheItemPoolTrait

Complexity

Total Complexity

13

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Test Coverage

Coverage

96.97%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	commit()	0	23	4
A	saveDeferred()	0	9	1
A	checkQueueNamespace()	0	11	3
A	deleteItems()	0	11	3
A	getItems()	0	10	2

<?php namespace Comodojo\Cache\Traits;

use \Comodojo\Cache\Components\ItemsIterator;

The type Comodojo\Cache\Components\ItemsIterator was not found. Maybe you did not declare it correctly or list all dependencies?

use \Psr\Cache\CacheItemInterface;

/**
 * @package     Comodojo Cache
 * @author      Marco Giovinazzi <marco.giovinazzi@comodojo.org>
 * @license     MIT
 *
 * LICENSE:
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

trait BasicCacheItemPoolTrait {

    private $queue = [];

    public function getItems(array $keys = []) {

        $items = [];

        foreach ( $keys as $key ) {

            $items[$key] = $this->getItem($key);

The method getItem() does not exist on Comodojo\Cache\Traits\BasicCacheItemPoolTrait. Did you maybe mean getItems()?

        }

        return $items;

    }

    public function deleteItems(array $keys) {

        $result = [];

        foreach ( $keys as $key ) {

            $result[] = $this->deleteItem($key);

The method deleteItem() does not exist on Comodojo\Cache\Traits\BasicCacheItemPoolTrait. Did you maybe mean deleteItems()?

        }

        return in_array(false, $result) ? false : true;

    }

    public function saveDeferred(CacheItemInterface $item) {

        $this->checkQueueNamespace(true);

        $namespace = $this->getNamespace();

It seems like getNamespace() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->queue[$namespace][$item->getKey()] = $item;

        return true;

    }

    public function commit() {

        $result = [];

        $active_namespace = $this->getNamespace();

        foreach ( $this->queue as $namespace => $queue ) {

            $this->setNamespace($namespace);

It seems like setNamespace() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            foreach ( $queue as $key => $item ) {

                $result[] = $this->save($item);

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }

        }

        $this->queue = [];

        $this->setNamespace($active_namespace);

        return in_array(false, $result) ? false : true;

    }

    private function checkQueueNamespace($create = false) {

        $namespace = $this->getNamespace();

        if ( array_key_exists($namespace, $this->queue) ) {
            return true;
        } else if ( $create ) {
            $this->queue[$namespace] = [];
            return true;
        } else {
            return false;
        }

    }

}