Delivery - Code Metrics - Inspection of "fix(ProductSuggest): fix suggestion parameters" - commercetools/commercetools-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( fe4302...d9652d )

by Jens

created 2017-04-18 16:01 UTC

Delivery A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	29.27 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

92.31%

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	1
dl	12
loc	41
ccs	12
cts	13
cp	0.9231
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	fieldDefinitions()	0	8	1
A	destinationType()	0	10	2
A	fromArray()	12	12	4

How to fix Duplicated Code

<?php
/**
 * @author @jayS-de <[email protected]>
 */

namespace Commercetools\Core\Model\Subscription;

use Commercetools\Core\Model\Common\JsonObject;
use Commercetools\Core\Model\Common\Reference;

/**
 * @package Commercetools\Core\Model\Subscription
 *
 * @method string getProjectKey()
 * @method Delivery setProjectKey(string $projectKey = null)
 * @method string getNotificationType()
 * @method Delivery setNotificationType(string $notificationType = null)
 * @method Reference getResource()
 * @method Delivery setResource(Reference $resource = null)
 */
class Delivery extends JsonObject
{
    const NOTIFICATION_TYPE = 'notificationType';
    const TYPE_MESSAGE = 'Message';
    const TYPE_RESOURCE_CREATED = 'ResourceCreated';
    const TYPE_RESOURCE_UPDATED = 'ResourceUpdated';
    const TYPE_RESOURCE_DELETED = 'ResourceDeleted';

    public function fieldDefinitions()
    {
        return [
            'projectKey' => [static::TYPE => 'string'],
            static::NOTIFICATION_TYPE => [static::TYPE => 'string'],
            'resource' => [static::TYPE => Reference::class],
        ];
    }

    protected static function destinationType($typeId)
    {
        $types = [
            static::TYPE_MESSAGE => MessageDelivery::class,
            static::TYPE_RESOURCE_CREATED => ResourceCreatedDelivery::class,
            static::TYPE_RESOURCE_UPDATED => ResourceUpdatedDelivery::class,
            static::TYPE_RESOURCE_DELETED => ResourceDeletedDelivery::class,
        ];
        return isset($types[$typeId]) ? $types[$typeId] : Delivery::class;
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
    }

    public static function fromArray(array $data, $context = null)

    {
        if (get_called_class() == Delivery::class &&
<?php

class Certificate {
    const TRIPLEDES_CBC = 'ASDFGHJKL';

    private $key;

    public function __construct()
    {
        $this->key = Certificate::TRIPLEDES_CBC;
    }
}
            isset($data[static::NOTIFICATION_TYPE])
        ) {
            $className = static::destinationType($data[static::NOTIFICATION_TYPE]);
            if (class_exists($className)) {
                return new $className($data, $context);
            }
        }
        return new static($data, $context);
    }
}


1			<?php
2			/**
3			* @author @jayS-de <[email protected]>
4			*/
5
6			namespace Commercetools\Core\Model\Subscription;
7
8			use Commercetools\Core\Model\Common\JsonObject;
9			use Commercetools\Core\Model\Common\Reference;
10
11			/**
12			* @package Commercetools\Core\Model\Subscription
13			*
14			* @method string getProjectKey()
15			* @method Delivery setProjectKey(string $projectKey = null)
16			* @method string getNotificationType()
17			* @method Delivery setNotificationType(string $notificationType = null)
18			* @method Reference getResource()
19			* @method Delivery setResource(Reference $resource = null)
20			*/
21			class Delivery extends JsonObject
22			{
23			const NOTIFICATION_TYPE = 'notificationType';
24			const TYPE_MESSAGE = 'Message';
25			const TYPE_RESOURCE_CREATED = 'ResourceCreated';
26			const TYPE_RESOURCE_UPDATED = 'ResourceUpdated';
27			const TYPE_RESOURCE_DELETED = 'ResourceDeleted';
28
29			public function fieldDefinitions()
30			{
31			return [
32			'projectKey' => [static::TYPE => 'string'],
33			static::NOTIFICATION_TYPE => [static::TYPE => 'string'],
34			'resource' => [static::TYPE => Reference::class],
35			];
36			}
37
38	5		protected static function destinationType($typeId)
39			{
40			$types = [
41	5		static::TYPE_MESSAGE => MessageDelivery::class,
42	5		static::TYPE_RESOURCE_CREATED => ResourceCreatedDelivery::class,
43	5		static::TYPE_RESOURCE_UPDATED => ResourceUpdatedDelivery::class,
44	5		static::TYPE_RESOURCE_DELETED => ResourceDeletedDelivery::class,
45			];
46	5		return isset($types[$typeId]) ? $types[$typeId] : Delivery::class;
			1 ignored issue – show Coding Style introduced 2017-03-06 13:07 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
47			}
48
49	5	View Code Duplication	public static function fromArray(array $data, $context = null)
			0 ignored issues – show Duplication introduced 2017-04-18 16:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50			{
51	5		if (get_called_class() == Delivery::class &&
			1 ignored issue – show Coding Style introduced 2017-03-06 13:07 UTC by Report Bug Copy Issue Report As per coding style, `self` should be used for accessing local static members. This check looks for accesses to local static members using the fully qualified name instead of `self::`. <?php class Certificate { const TRIPLEDES_CBC = 'ASDFGHJKL'; private $key; public function __construct() { $this->key = Certificate::TRIPLEDES_CBC; } } While this is perfectly valid, the fully qualified name of `Certificate::TRIPLEDES_CBC` could just as well be replaced by `self::TRIPLEDES_CBC`. Referencing local members with `self::` assured the access will still work when the class is renamed, makes it perfectly clear that the member is in fact local and will usually be shorter. Loading history...
52	5		isset($data[static::NOTIFICATION_TYPE])
53			) {
54	5		$className = static::destinationType($data[static::NOTIFICATION_TYPE]);
55	5		if (class_exists($className)) {
56	5		return new $className($data, $context);
57			}
58			}
59			return new static($data, $context);
60			}
61			}
62

commercetools / commercetools-php-sdk

Push — develop ( fe4302...d9652d )

Delivery A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like