Set::initialize() - Code Metrics - Inspection of "feat(CustomField): add type safe getter for field..." - commercetools/commercetools-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 347ecb...732f86 )

by Jens

created 2017-09-26 13:19 UTC

Set::initialize() A

↳ Parent: Set

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	2
nop	1
crap	3

<?php
/**
 * @author @jayS-de <[email protected]>
 */

namespace Commercetools\Core\Model\Common;

/**
 * @package Commercetools\Core\Model\Common
 * @link https://dev.commercetools.com/http-api-projects-products.html#attribute
 * @link https://dev.commercetools.com/http-api-projects-productTypes.html#settype
 * @link https://dev.commercetools.com/http-api-projects-productTypes.html#attributetype
 */
class Set extends Collection implements TypeableInterface
{
    /**
     * @param $offset
     * @internal
     */
    protected function initialize($offset)
    {
        parent::initialize($offset);

        $type = $this->getType();
        if (!$this->isPrimitive($type) && !$this->isDeserializableType($type)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $value = new $type($this->typeData[$offset]);
            $this->typeData[$offset] = $value;
        }
    }

    /**
     * @param $type
     * @param Context|callable $context
     * @return $this
     */
    public static function ofType($type, $context = null)
    {
        $set = static::of($context);
        return $set->setType($type);
    }

    /**
     * @param $type
     * @param array $data
     * @param Context|callable $context
     * @return $this
     */
    public static function ofTypeAndData($type, array $data, $context = null)
    {
        return static::ofType($type, $context)->setRawData($data);
    }


    public function __toString()
    {
        $values = [];
        foreach ($this as $set) {
            $values[] = (string)$set;
        }
        return implode(', ', $values);
    }
}


1		<?php
2		/**
3		* @author @jayS-de <[email protected]>
4		*/
5
6		namespace Commercetools\Core\Model\Common;
7
8		/**
9		* @package Commercetools\Core\Model\Common
10		* @link https://dev.commercetools.com/http-api-projects-products.html#attribute
11		* @link https://dev.commercetools.com/http-api-projects-productTypes.html#settype
12		* @link https://dev.commercetools.com/http-api-projects-productTypes.html#attributetype
13		*/
14		class Set extends Collection implements TypeableInterface
15		{
16		/**
17		* @param $offset
18		* @internal
19		*/
20	28	protected function initialize($offset)
21		{
22	28	parent::initialize($offset);
23
24	28	$type = $this->getType();
25	28	if (!$this->isPrimitive($type) && !$this->isDeserializableType($type)) {
		0 ignored issues – show Bug Best Practice introduced 2017-09-26 13:28 UTC by Report Bug Copy Issue Report The expression `$this->isPrimitive($type)` of type `string\|false` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
26	4	$value = new $type($this->typeData[$offset]);
27	4	$this->typeData[$offset] = $value;
28		}
29	28	}
30
31		/**
32		* @param $type
33		* @param Context\|callable $context
34		* @return $this
35		*/
36	30	public static function ofType($type, $context = null)
37		{
38	30	$set = static::of($context);
39	30	return $set->setType($type);
40		}
41
42		/**
43		* @param $type
44		* @param array $data
45		* @param Context\|callable $context
46		* @return $this
47		*/
48	27	public static function ofTypeAndData($type, array $data, $context = null)
49		{
50	27	return static::ofType($type, $context)->setRawData($data);
51		}
52
53
54	1	public function __toString()
55		{
56	1	$values = [];
57	1	foreach ($this as $set) {
58	1	$values[] = (string)$set;
59		}
60	1	return implode(', ', $values);
61		}
62		}
63

commercetools / commercetools-php-sdk

Push — develop ( 347ecb...732f86 )

Set::initialize() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like