ErrorResponse::isError() - Code Metrics - Inspection of "fix(ErrorResponse): add getter for inner exception" - commercetools/commercetools-php-sdk - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( e6fbfe...96413a )

by Jens

created 2021-02-23 13:46 UTC

ErrorResponse::isError() A

↳ Parent: ErrorResponse

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	1
nc	1
nop	0
crap	1

<?php
/**
 * @author @jenschude <[email protected]>
 */

namespace Commercetools\Core\Response;

use Commercetools\Core\Error\ErrorContainer;
use Commercetools\Core\Model\Common\Context;
use Commercetools\Core\Request\ClientRequestInterface;
use Psr\Http\Message\ResponseInterface;

class ErrorResponse extends AbstractApiResponse
{
    /**
     * @var \Exception
     */
    private $exception;

    /**
     * @var string
     */
    private $message;

    /**
     * ErrorResponse constructor.
     * @param ResponseInterface $response
     * @param ClientRequestInterface $request
     * @param \Exception $exception
     * @param Context $context
     */
    public function __construct(
        \Exception $exception,
        ClientRequestInterface $request,
        ResponseInterface $response,
        Context $context = null
    ) {
        parent::__construct($response, $request, $context);
        $this->exception = $exception;
    }

    public function isError()
    {
        return true;
    }

    public function getMessage()
    {
        if (is_null($this->message)) {

            $message = $this->getResponseField('message', null);
            $this->message = !is_null($message) ? $message : $this->getResponse()->getReasonPhrase();
        }
        return $this->message;
    }

    /**
     * @return \Exception
     */
    public function getException()
    {
        return $this->exception;
    }
}


1		<?php
2		/**
3		* @author @jenschude <[email protected]>
4		*/
5
6		namespace Commercetools\Core\Response;
7
8		use Commercetools\Core\Error\ErrorContainer;
9		use Commercetools\Core\Model\Common\Context;
10		use Commercetools\Core\Request\ClientRequestInterface;
11		use Psr\Http\Message\ResponseInterface;
12
13		class ErrorResponse extends AbstractApiResponse
14		{
15		/**
16		* @var \Exception
17		*/
18		private $exception;
19
20		/**
21		* @var string
22		*/
23		private $message;
24
25		/**
26		* ErrorResponse constructor.
27		* @param ResponseInterface $response
28		* @param ClientRequestInterface $request
29		* @param \Exception $exception
30		* @param Context $context
31		*/
32	16	public function __construct(
33		\Exception $exception,
34		ClientRequestInterface $request,
35		ResponseInterface $response,
36		Context $context = null
37		) {
38	16	parent::__construct($response, $request, $context);
39	16	$this->exception = $exception;
40	16	}
41
42	11	public function isError()
43		{
44	11	return true;
45		}
46
47	2	public function getMessage()
48		{
49	2	if (is_null($this->message)) {
		0 ignored issues – show introduced 2018-10-19 12:44 UTC by Report Bug Copy Issue Report The condition `is_null($this->message)` is always `false`. Loading history...
50	2	$message = $this->getResponseField('message', null);
51	2	$this->message = !is_null($message) ? $message : $this->getResponse()->getReasonPhrase();
52		}
53	2	return $this->message;
54		}
55
56		/**
57		* @return \Exception
58		*/
59		public function getException()
60		{
61		return $this->exception;
62		}
63		}
64

commercetools / commercetools-php-sdk

Push — develop ( e6fbfe...96413a )

ErrorResponse::isError() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like