Commercetools\Core\Response\ErrorResponse

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	isError()	0	4	1
A	getMessage()	0	7	2

<?php
/**
 * @author @jayS-de <jens.schulze@commercetools.de>
 */

namespace Commercetools\Core\Response;

use Commercetools\Core\Error\ErrorContainer;
use Commercetools\Core\Model\Common\Context;
use Commercetools\Core\Request\ClientRequestInterface;
use Psr\Http\Message\ResponseInterface;

class ErrorResponse extends AbstractApiResponse
{
    /**
     * @var \Exception
     */
    private $exception;

    private $message;
    private $statusCode;

The property $statusCode is not used and could be removed.

    /**
     * ErrorResponse constructor.
     * @param ResponseInterface $response
     * @param ClientRequestInterface $request
     * @param \Exception $exception
     * @param Context $context
     */
    public function __construct(
        \Exception $exception,
        ClientRequestInterface $request,
        ResponseInterface $response = null,
        Context $context = null
    ) {
        parent::__construct($response, $request, $context);

It seems like $response defined by parameter $response on line 33 can be null; however, Commercetools\Core\Response\AbstractApiResponse::__construct() does not accept null, maybe add an additional type check?

        $this->exception = $exception;
    }

    public function isError()
    {
        return true;
    }

    public function getMessage()
    {
        if (is_null($this->message)) {
            $this->message = $this->getResponseField('message');
        }
        return $this->message;
    }
}