Passed
Push — develop ( a82d29...5207c2 )
by Jens
08:45
created

RelativeCartDiscountValue   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 40
Duplicated Lines 100 %

Coupling/Cohesion

Components 0
Dependencies 1

Test Coverage

Coverage 66.67%

Importance

Changes 0
Metric Value
wmc 4
lcom 0
cbo 1
dl 40
loc 40
ccs 8
cts 12
cp 0.6667
rs 10
c 0
b 0
f 0

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 6 6 1
A fieldDefinitions() 8 8 1
A getMoney() 4 4 1
A setMoney() 4 4 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * @author @jayS-de <[email protected]>
4
 */
5
6
namespace Commercetools\Core\Model\CartDiscount;
7
8
use Commercetools\Core\Model\Common\MoneyCollection;
9
10
/**
11
 * @package Commercetools\Core\Model\CartDiscount
12
 * @method string getType()
13
 * @method RelativeCartDiscountValue setType(string $type = null)
14
 * @method int getPermyriad()
15
 * @method RelativeCartDiscountValue setPermyriad(int $permyriad = null)
16
 */
17 View Code Duplication
class RelativeCartDiscountValue extends CartDiscountValue
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
18
{
19
    /**
20
     * @inheritDoc
21
     */
22 1
    public function __construct(array $data = [], $context = null)
23
    {
24 1
        $data['type'] = static::TYPE_RELATIVE;
25
26 1
        parent::__construct($data, $context);
27 1
    }
28
29 1
    public function fieldDefinitions()
30
    {
31
        return [
32 1
            'type' => [static::TYPE => 'string'],
33 1
            'permyriad' => [static::TYPE => 'int'],
34 1
            'money' => [static::TYPE => MoneyCollection::class]
35
        ];
36
    }
37
38
    /**
39
     * @deprecated getMoney will be removed for relative cart discounts with v3.0
40
     * @return MoneyCollection
41
     */
42
    public function getMoney()
43
    {
44
        return parent::getMoney();
45
    }
46
47
    /**
48
     * @deprecated setMoney will be removed for relative cart discounts with v3.0
49
     * @param MoneyCollection|null $money
50
     * @return CartDiscountValue
51
     */
52
    public function setMoney(MoneyCollection $money = null)
53
    {
54
        return parent::setMoney($money);
55
    }
56
}
57