Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | View Code Duplication | class RelativeCartDiscountValue extends CartDiscountValue |
|
|
|||
18 | { |
||
19 | /** |
||
20 | * @inheritDoc |
||
21 | */ |
||
22 | 1 | public function __construct(array $data = [], $context = null) |
|
28 | |||
29 | 1 | public function fieldDefinitions() |
|
37 | |||
38 | /** |
||
39 | * @deprecated getMoney will be removed for relative cart discounts with v3.0 |
||
40 | * @return MoneyCollection |
||
41 | */ |
||
42 | public function getMoney() |
||
46 | |||
47 | /** |
||
48 | * @deprecated setMoney will be removed for relative cart discounts with v3.0 |
||
49 | * @param MoneyCollection|null $money |
||
50 | * @return CartDiscountValue |
||
51 | */ |
||
52 | public function setMoney(MoneyCollection $money = null) |
||
56 | } |
||
57 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.