Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class JwtBearerTest extends TestBase |
||
10 | { |
||
11 | public function testMissingConfigException() |
||
16 | |||
17 | public function testPrivateKeyNotSplFileObject() |
||
25 | |||
26 | View Code Duplication | public function testValidRequestGetsToken() |
|
36 | } |
||
37 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.