| Conditions | 10 | 
| Paths | 8 | 
| Total Lines | 25 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Tests | 11 | 
| CRAP Score | 15.8818 | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php  | 
            ||
| 18 | 1 | protected function validate(array $values)  | 
            |
| 19 |     { | 
            ||
| 20 | 1 |         if (!isset($values['length'])) { | 
            |
| 21 |             throw new \InvalidArgumentException('Interval must have a length.'); | 
            ||
| 22 | }  | 
            ||
| 23 | 1 |         if (!isset($values['unit'])) { | 
            |
| 24 |             throw new \InvalidArgumentException('Interval must have a unit.'); | 
            ||
| 25 | }  | 
            ||
| 26 | 1 |         if (!array_intersect(['days', 'months'], (array) $values['unit'])) { | 
            |
| 27 |             throw new \InvalidArgumentException('Interval unit must be days or months.'); | 
            ||
| 28 | }  | 
            ||
| 29 | 1 |         switch ($values['unit']) { | 
            |
| 30 | 1 | case 'days':  | 
            |
| 31 |                 if ($values['length'] < 7 || $values['length'] > 365) { | 
            ||
| 32 |                     throw new \InvalidArgumentException('Interval length for days must be between 7 and 365, inclusive.'); | 
            ||
| 33 | }  | 
            ||
| 34 | break;  | 
            ||
| 35 | |||
| 36 | 1 | case 'months':  | 
            |
| 37 | 1 |                 if ($values['length'] < 1 || $values['length'] > 12) { | 
            |
| 38 |                     throw new \InvalidArgumentException('Interval length for months must be between 1 and 12, inclusive.'); | 
            ||
| 39 | }  | 
            ||
| 40 | 1 | break;  | 
            |
| 41 | 1 | }  | 
            |
| 42 | 1 | }  | 
            |
| 43 | }  | 
            ||
| 44 |