View GitHub Repository spss

Schedule Inspection
Subscribe
Completed
Push — master ( dd1269...21c3dd )
by Sam
02:11
created

LongVariableNames::read()   A

↳ Parent: LongVariableNames

Complexity

Conditions 2
Paths 2

Size

Total Lines 8
Code Lines 5

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 6
CRAP Score 2

Importance

Changes 2
Bugs 0 Features 0
Metric Value
cc 2
eloc 5
c 2
b 0
f 0
nc 2
nop 1
dl 0
loc 8
ccs 6
cts 6
cp 1
crap 2
rs 10
1 
<?php
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
namespace SPSS\Sav\Record\Info;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
use SPSS\Buffer;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
use SPSS\Sav\Record\Info;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
class LongVariableNames extends Info

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
    const SUBTYPE = 13;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
    const DELIMITER = "\t";

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
     * @var array

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
     */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
    public $data = [];

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
     * @param Buffer $buffer

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
     */

            


            
                                                                        
                            
            
                                    
            
            

                
                    21
                

                                    
                             5                         
                
                
                
    public function read(Buffer $buffer)

            


            
                                                                        
                            
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
    {

            


            
                                                                        
                            
            
                                    
            
            

                
                    23
                

                                    
                             5                         
                
                
                
        parent::read($buffer);

            


            
                                                                        
                            
            
                                    
            
            

                
                    24
                

                                    
                             5                         
                
                
                
        $data = rtrim($buffer->readString($this->dataSize * $this->dataCount));

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
It seems like $buffer->readString($thi...ize * $this->dataCount) can also be of type false; however, parameter $str of rtrim() does only seem to accept string, maybe add an additional type check?
                                                                                                                                                                                           (
                                     Ignorable by Annotation
                                )
                                

                                    
 If this is a false-positive, you can also ignore this issue in your code via the ignore-type   annotation

                                    

                                        

                                            24
                                            
                                                
        $data = rtrim(/** @scrutinizer ignore-type */ $buffer->readString($this->dataSize * $this->dataCount));

                                        

                                                                            

                                

                                                                                                                                                                                                                                                                                        

                    
                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                        
                            
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                

            


            
                                                                        
                            
            
                                    
            
            

                
                    26
                

                                    
                             5                         
                
                
                
        foreach (explode(self::DELIMITER, $data) as $item) {

            


            
                                                                        
                            
            
                                    
            
            

                
                    27
                

                                    
                             5                         
                
                
                
            list($key, $value) = explode('=', $item);

            


            
                                                                        
                            
            
                                    
            
            

                
                    28
                

                                    
                             5                         
                
                
                
            $this->data[$key] = trim($value);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    29
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    30
                

                                    
                             5                         
                
                
                
    }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    32
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    33
                

                                    
                                                    
                
                
                
     * @param Buffer $buffer

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    34
                

                                    
                                                    
                
                
                
     */

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    35
                

                                    
                             5                         
                
                
                
    public function write(Buffer $buffer)

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    36
                

                                    
                                                    
                
                
                
    {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    37
                

                                    
                             5                         
                
                
                
        $data = '';

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    38
                

                                    
                             5                         
                
                
                
        foreach ($this->data as $key => $value) {

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    39
                

                                    
                             5                         
                
                
                
            $data .= sprintf('%s=%s', $key, $value) . self::DELIMITER;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    40
                

                                    
                                                    
                
                
                
        }

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    41
                

                                    
                             5                         
                
                
                
        $this->dataCount = strlen($data);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    42
                

                                    
                             5                         
                
                
                
        parent::write($buffer);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    43
                

                                    
                             5                         
                
                
                
        $buffer->writeString($data);

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    44
                

                                    
                             5                         
                
                
                
    }

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    45
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    46