SPSS\Sav\Record\Info\VariableDisplayParam

Complexity

Total Complexity

7

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

76%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	read()	0	23	4
A	write()	0	9	3

<?php

namespace SPSS\Sav\Record\Info;

use SPSS\Buffer;
use SPSS\Exception;
use SPSS\Sav\Record\Info;

class VariableDisplayParam extends Info
{
    const SUBTYPE = 11;

    /**
     * @var array
     */
    public $data = [];

    /**
     * @var int
     */
    protected $dataSize = 4;

    /**
     * @param Buffer $buffer
     * @throws Exception
     */
    public function read(Buffer $buffer)
    {
        parent::read($buffer);
        if ($this->dataSize != 4) {
            throw new Exception(
                sprintf('Error reading record type 7 subtype 11: bad data element length [%s]. Expecting 4.',
                    $this->dataSize
                )
            );
        }
        if (($this->dataCount % 3) != 0) {
            throw new Exception(
                sprintf('Error reading record type 7 subtype 11: number of data elements [%s] is not a multiple of 3.',
                    $this->dataCount
                )
            );
        }
        $itemCount = $this->dataCount / 3;
        for ($i = 0; $i < $itemCount; $i++) {
            $this->data[] = [
                $buffer->readInt(), // The measurement type of the variable
                $buffer->readInt(), // The width of the display column for the variable in characters.
                $buffer->readInt(), // The alignment of the variable
            ];
        }
    }

    /**
     * @param Buffer $buffer
     */
    public function write(Buffer $buffer)
    {
        if ($this->data) {

The expression $this->data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->dataCount = count($this->data) * 3;
            parent::write($buffer);
            foreach ($this->data as $item) {
                $buffer->writeInt(0xFF & $item[0]);
                $buffer->writeInt(0xFF & $item[1]);
                $buffer->writeInt(0xFF & $item[2]);
            }
        }
    }
}