SPSS\Sav\Record\Info\LongStringMissingValues

Complexity

Total Complexity

7

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

7.69%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	write()	0	17	4
A	read()	0	12	3

<?php

namespace SPSS\Sav\Record\Info;

use SPSS\Buffer;
use SPSS\Sav\Record\Info;

class LongStringMissingValues extends Info
{
    const SUBTYPE = 22;

    /**
     * @param \SPSS\Buffer $buffer
     * @throws \SPSS\Exception
     */
    public function read(Buffer $buffer)
    {
        parent::read($buffer);
        $buffer = $buffer->allocate($this->dataCount * $this->dataSize);
        while ($varNameLength = $buffer->readInt()) {
            $varName = trim($buffer->readString($varNameLength));

It seems like $buffer->readString($varNameLength) can also be of type false; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

            $count = ord($buffer->read(1));
            $this->data[$varName] = [];
            $valueLength = $buffer->readInt();
            for ($i = 0; $i < $count; $i++) {
                $value = $buffer->readString($valueLength);
                $this->data[$varName][] = rtrim($value);

It seems like $value can also be of type false; however, parameter $str of rtrim() does only seem to accept string, maybe add an additional type check?

            }
        }
    }

    /**
     * @param Buffer $buffer
     */
    public function write(Buffer $buffer)
    {
        if ($this->data) {

The expression $this->data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $localBuffer = Buffer::factory();
            foreach ($this->data as $varName => $values) {
                $localBuffer->writeInt(mb_strlen($varName));
                $localBuffer->writeString($varName);
                $localBuffer->write(chr(count($values)), 1);
                $localBuffer->writeInt(8);
                foreach ($values as $value) {
                    $localBuffer->writeString($value, 8);
                }
            }
            $this->dataCount = $localBuffer->position();
            parent::write($buffer);
            $localBuffer->rewind();
            $buffer->writeStream($localBuffer->getStream(), $this->dataCount);
        }
    }
}