SPSS\Sav\Record\Data

Complexity

Total Complexity

22

Size/Duplication

Total Lines	161
Duplicated Lines	0 %

Test Coverage

Coverage

88.61%

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	writeVariable()	0	18	3
B	read()	0	60	11
B	write()	0	50	7
A	toArray()	0	3	1

<?php

namespace SPSS\Sav\Record;

use phpDocumentor\Reflection\DocBlock\Tags\Var_;
use SebastianBergmann\CodeCoverage\Util;
use SPSS\Buffer;
use SPSS\ByteCodeReader;
use SPSS\ByteCodeWriter;
use SPSS\Exception;
use SPSS\Sav\Record;
use SPSS\Utils;

class Data extends Record
{
    const TYPE = 999;
    /**
     * @var array [case_index][var_index]
     */
    public $matrix = [];

    /**
     * @param Buffer $buffer
     * @throws Exception
     */
    public function read(Buffer $buffer)
    {

        if ($buffer->readInt() != 0) {
            throw new \InvalidArgumentException('Error reading data record. Non-zero value found.');
        }
        if (! isset($buffer->context->variables)) {
            throw new \InvalidArgumentException('Variables required');
        }
        if (! isset($buffer->context->header)) {
            throw new \InvalidArgumentException('Header required');
        }
        if (! isset($buffer->context->info)) {
            throw new \InvalidArgumentException('Info required');
        }

        $compressed = $buffer->context->header->compression;

The assignment to $compressed is dead and can be removed.

        $bias = $buffer->context->header->bias;

The assignment to $bias is dead and can be removed.

        $casesCount = $buffer->context->header->casesCount;

        /** @var Record\Info[] $info */
        $info = $buffer->context->info;


        if (isset($info[Record\Info\VeryLongString::SUBTYPE])) {
            $veryLongStrings = $info[Record\Info\VeryLongString::SUBTYPE]->toArray();
        } else {
            $veryLongStrings = [];
        }

        /** @var Variable[] $variables */
        $variables = $buffer->context->variables;

        if (isset($info[Record\Info\MachineFloatingPoint::SUBTYPE])) {
            $sysmis = $info[Record\Info\MachineFloatingPoint::SUBTYPE]->sysmis;

The assignment to $sysmis is dead and can be removed.

        } else {
            $sysmis = NAN;
        }

        $reader = new ByteCodeReader($buffer);
        for ($case = 0; $case < $casesCount; $case++) {
            $varNum = 0;

            for($index = 0; $index < count($variables); $index++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $var = $variables[$index];
                $isNumeric = \SPSS\Sav\Variable::isNumberFormat($var->write[1]);
                if ($isNumeric) {
                    $data = $reader->read(8);
                    $this->matrix[$case][$varNum] = unpack('d', $data)[1];
                } else {
                    $value = '';
                    foreach(Utils::getSegments($veryLongStrings[$var->name] ?? $var->width) as $segmentWidth) {
                        $segment = $reader->read($segmentWidth + 8 - ($segmentWidth % 8));
                        $value .= rtrim($segment);
                        $index++;
                    }
                    $index--;
                    $this->matrix[$case][$varNum] = $value;
                }
                $varNum++;
            }

        }
    }

    /**
     * @param Buffer $buffer
     */
    public function write(Buffer $buffer)
    {
        $buffer->writeInt(self::TYPE);
        $buffer->writeInt(0);


        if (! isset($buffer->context->variables)) {
            throw new \InvalidArgumentException('Variables required');
        }
        if (! isset($buffer->context->header)) {
            throw new \InvalidArgumentException('Header required');
        }
        if (! isset($buffer->context->info)) {
            throw new \InvalidArgumentException('Info required');
        }

        $casesCount = $buffer->context->header->casesCount;

        /** @var Variable[] $variables */
        $variables = $buffer->context->variables;

        /** @var Record\Info[] $info */
        $info = $buffer->context->info;

        if (isset($info[Record\Info\MachineFloatingPoint::SUBTYPE])) {
            $sysmis = $info[Record\Info\MachineFloatingPoint::SUBTYPE]->sysmis;

The assignment to $sysmis is dead and can be removed.

        } else {
            $sysmis = NAN;
        }

        /** @var Record\Info\VeryLongString $vls */
        $veryLongStrings = $info[Record\Info\VeryLongString::SUBTYPE];

        $dataBuffer = Buffer::factory('', ['memory' => true]);

        $writer = new ByteCodeWriter($dataBuffer);
        for ($case = 0; $case < $casesCount; $case++) {
            /**
             * @var  $index
             * @var Variable $variable
             */
            foreach ($variables as $index => $variable) {
                $width = $veryLongStrings[$variable->name] ?? $variable->width;
                $value = $this->matrix[$case][$index];
                $this->writeVariable($writer, $variable, $width, $value);
            }
        }

        $dataBuffer->rewind();
        $buffer->writeStream($dataBuffer->getStream());
    }

    private function writeVariable(
        ByteCodeWriter $writer,
        Variable $variable,
        int $width,
        $value
    ) {
        $isNumeric = \SPSS\Sav\Variable::isNumberFormat($variable->write[1]);
        if ($isNumeric) {
            $writer->append(pack('d', $value));
            $writer->flush();
        } else {
            foreach(Utils::getSegments($width) as $segmentWidth) {
                $segment = str_pad(substr($value, 0, $segmentWidth), $segmentWidth);
                $padding = str_repeat(' ', 8 - (strlen($segment) % 8));
                $writer->append($segment);
                $writer->append($padding);
                $writer->flush();
                $value = substr($value, $segmentWidth);
            }
        }
    }


    /**
     * @return array
     */
    public function toArray()
    {
        return $this->matrix;
    }
}