VariableDisplayParam::read() - Code Metrics - collecthor/spss - Measure and Improve Code Quality continuously with Scrutinizer

VariableDisplayParam::read() A
last analyzed 2020-11-12 11:01 UTC

↳ Parent: VariableDisplayParam

Complexity

Conditions	4
Paths	4

Size

Total Lines	23
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	4
eloc	15
c	2
b	0
f	0
nc	4
nop	1
dl	0
loc	23
ccs	0
cts	16
cp	0
crap	20
rs	9.7666

<?php

namespace SPSS\Sav\Record\Info;

use SPSS\Buffer;
use SPSS\Exception;
use SPSS\Sav\Record\Info;

class VariableDisplayParam extends Info
{
    const SUBTYPE = 11;

    /**
     * @var array
     */
    public $data = [];

    /**
     * @var int
     */
    protected $dataSize = 4;

    /**
     * @param Buffer $buffer
     * @throws Exception
     */
    public function read(Buffer $buffer)
    {
        parent::read($buffer);
        if ($this->dataSize != 4) {
            throw new Exception(
                sprintf('Error reading record type 7 subtype 11: bad data element length [%s]. Expecting 4.',
                    $this->dataSize
                )
            );
        }
        if (($this->dataCount % 3) != 0) {
            throw new Exception(
                sprintf('Error reading record type 7 subtype 11: number of data elements [%s] is not a multiple of 3.',
                    $this->dataCount
                )
            );
        }
        $itemCount = $this->dataCount / 3;
        for ($i = 0; $i < $itemCount; $i++) {
            $this->data[] = [
                $buffer->readInt(), // The measurement type of the variable
                $buffer->readInt(), // The width of the display column for the variable in characters.
                $buffer->readInt(), // The alignment of the variable
            ];
        }
    }

    /**
     * @param Buffer $buffer
     */
    public function write(Buffer $buffer)
    {
        if ($this->data) {

            $this->dataCount = count($this->data) * 3;
            parent::write($buffer);
            foreach ($this->data as $item) {
                $buffer->writeInt(0xFF & $item[0]);
                $buffer->writeInt(0xFF & $item[1]);
                $buffer->writeInt(0xFF & $item[2]);
            }
        }
    }
}


1			<?php
2
3			namespace SPSS\Sav\Record\Info;
4
5			use SPSS\Buffer;
6			use SPSS\Exception;
7			use SPSS\Sav\Record\Info;
8
9			class VariableDisplayParam extends Info
10			{
11			const SUBTYPE = 11;
12
13			/**
14			* @var array
15			*/
16			public $data = [];
17
18			/**
19			* @var int
20			*/
21			protected $dataSize = 4;
22
23			/**
24			* @param Buffer $buffer
25			* @throws Exception
26			*/
27			public function read(Buffer $buffer)
28			{
29			parent::read($buffer);
30			if ($this->dataSize != 4) {
31			throw new Exception(
32			sprintf('Error reading record type 7 subtype 11: bad data element length [%s]. Expecting 4.',
33			$this->dataSize
34			)
35			);
36			}
37			if (($this->dataCount % 3) != 0) {
38			throw new Exception(
39			sprintf('Error reading record type 7 subtype 11: number of data elements [%s] is not a multiple of 3.',
40			$this->dataCount
41			)
42			);
43			}
44			$itemCount = $this->dataCount / 3;
45			for ($i = 0; $i < $itemCount; $i++) {
46			$this->data[] = [
47			$buffer->readInt(), // The measurement type of the variable
48			$buffer->readInt(), // The width of the display column for the variable in characters.
49			$buffer->readInt(), // The alignment of the variable
50			];
51			}
52			}
53
54			/**
55			* @param Buffer $buffer
56			*/
57			public function write(Buffer $buffer)
58			{
59			if ($this->data) {
			0 ignored issues – show Bug Best Practice introduced 2019-11-19 12:54 UTC by Report Bug Copy Issue Report The expression `$this->data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
60			$this->dataCount = count($this->data) * 3;
61			parent::write($buffer);
62			foreach ($this->data as $item) {
63			$buffer->writeInt(0xFF & $item[0]);
64			$buffer->writeInt(0xFF & $item[1]);
65			$buffer->writeInt(0xFF & $item[2]);
66			}
67			}
68			}
69			}
70

collecthor / spss

VariableDisplayParam::read() A last analyzed 2020-11-12 11:01 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

VariableDisplayParam::read() A
last analyzed 2020-11-12 11:01 UTC