SPSS\Sav\Record\Info\LongStringMissingValues::write()

Complexity

Conditions	4
Paths	4

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

0

<?php
    public function write(Buffer $buffer)
    {
        if ($this->data) {

The expression $this->data of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $localBuffer = Buffer::factory();
            foreach ($this->data as $varName => $values) {
                $localBuffer->writeInt(mb_strlen($varName));
                $localBuffer->writeString($varName);
                $localBuffer->write(chr(count($values)), 1);
                $localBuffer->writeInt(8);
                foreach ($values as $value) {
                    $localBuffer->writeString($value, 8);
                }
            }
            $this->dataCount = $localBuffer->position();
            parent::write($buffer);
            $localBuffer->rewind();
            $buffer->writeStream($localBuffer->getStream(), $this->dataCount);
        }