SPSS\Sav\Record\Info\LongStringMissingValues::read()

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function read(Buffer $buffer)
    {
        parent::read($buffer);
        $buffer = $buffer->allocate($this->dataCount * $this->dataSize);
        while ($varNameLength = $buffer->readInt()) {
            $varName = trim($buffer->readString($varNameLength));

It seems like $buffer->readString($varNameLength) can also be of type false; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

            $count = ord($buffer->read(1));
            $this->data[$varName] = [];
            $valueLength = $buffer->readInt();
            for ($i = 0; $i < $count; $i++) {
                $value = $buffer->readString($valueLength);
                $this->data[$varName][] = rtrim($value);

It seems like $value can also be of type false; however, parameter $str of rtrim() does only seem to accept string, maybe add an additional type check?

            }