SPSS\Sav\Record\Info\LongVariableNames

Complexity

Total Complexity

4

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	read()	0	8	2
A	write()	0	9	2

<?php

namespace SPSS\Sav\Record\Info;

use SPSS\Buffer;
use SPSS\Sav\Record\Info;

class LongVariableNames extends Info
{
    const SUBTYPE = 13;
    const DELIMITER = "\t";

    /**
     * @var array
     */
    public $data = [];

    /**
     * @param Buffer $buffer
     */
    public function read(Buffer $buffer)
    {
        parent::read($buffer);
        $data = rtrim($buffer->readString($this->dataSize * $this->dataCount));

It seems like $buffer->readString($this->dataSize * $this->dataCount) can also be of type false; however, parameter $str of rtrim() does only seem to accept string, maybe add an additional type check?

        foreach (explode(self::DELIMITER, $data) as $item) {
            list($key, $value) = explode('=', $item);
            $this->data[$key] = trim($value);
        }
    }

    /**
     * @param Buffer $buffer
     */
    public function write(Buffer $buffer)
    {
        $data = '';
        foreach ($this->data as $key => $value) {
            $data .= sprintf('%s=%s', $key, $value) . self::DELIMITER;
        }
        $this->dataCount = strlen($data);
        parent::write($buffer);
        $buffer->writeString($data);
    }
}