SPSS\Sav\Record\Info\LongStringValueLabels

Complexity

Total Complexity

9

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	read()	0	18	3
B	write()	0	29	6

<?php

namespace SPSS\Sav\Record\Info;

use SPSS\Buffer;
use SPSS\Sav\Record\Info;

class LongStringValueLabels extends Info
{
    const SUBTYPE = 21;

    /**
     * @var array
     */
    public $data = [];

    /**
     * @param \SPSS\Buffer $buffer
     * @throws \SPSS\Exception
     */
    public function read(Buffer $buffer)
    {
        parent::read($buffer);
        $buffer = $buffer->allocate($this->dataCount * $this->dataSize);
        while ($varNameLength = $buffer->readInt()) {
            $varName = $buffer->readString($varNameLength);
            $varWidth = $buffer->readInt(); // The width of the variable, in bytes, which will be between 9 and 32767
            $valuesCount = $buffer->readInt();
            $this->data[$varName] = [
                'width' => $varWidth,
                'values' => [],
            ];
            for ($i = 0; $i < $valuesCount; $i++) {
                $valueLength = $buffer->readInt();
                $value = rtrim($buffer->readString($valueLength));

It seems like $buffer->readString($valueLength) can also be of type false; however, parameter $str of rtrim() does only seem to accept string, maybe add an additional type check?

                $labelLength = $buffer->readInt();
                $label = rtrim($buffer->readString($labelLength));
                $this->data[$varName]['values'][$value] = $label;
            }
        }
    }

    /**
     * @param \SPSS\Buffer $buffer
     */
    public function write(Buffer $buffer)
    {
        $localBuffer = Buffer::factory('', ['memory' => true]);
        foreach ($this->data as $varName => $data) {
            if (! isset($data['width'])) {
                throw new \InvalidArgumentException('width required');
            }
            if (! isset($data['values'])) {
                throw new \InvalidArgumentException('values required');
            }
            $width = (int) $data['width'];
            $localBuffer->writeInt(mb_strlen($varName));
            $localBuffer->writeString($varName);
            $localBuffer->writeInt($width);
            $localBuffer->writeInt(count($data['values']));
            foreach ($data['values'] as $value => $label) {
                $localBuffer->writeInt($width);
                $localBuffer->writeString($value, $width);
                $localBuffer->writeInt(mb_strlen($label));
                $localBuffer->writeString($label);
            }
        }

        // retrieve bytes count
        $this->dataCount = $localBuffer->position();
        if ($this->dataCount > 0) {
            parent::write($buffer);
            $localBuffer->rewind();
            $buffer->writeStream($localBuffer->getStream());
        }
    }
}