CoiSA\Http\Middleware\MoveUploadedFilesMiddleware

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	process()	0	16	4

<?php declare(strict_types=1);
/*
 * This file is part of coisa/http.
 *
 * (c) Felipe Sayão Lobato Abreu <github@felipeabreu.com.br>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace CoiSA\Http\Middleware;

use CoiSA\Http\Message\UploadedFile\FilterInterface;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\UploadedFileInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

/**
 * Class MoveUploadedFilesMiddleware
 *
 * @package CoiSA\Http\Middleware
 */
final class MoveUploadedFilesMiddleware implements MiddlewareInterface
{
    /**
     * @var string
     */
    private $targetPath;

    /**
     * @var callable
     */
    private $filter;

    /**
     * MoveUploadedFilesMiddleware constructor.
     *
     * @param string $targetPath
     * @param FilterInterface|null $filter
     */
    public function __construct(string $targetPath, FilterInterface $filter = null)
    {
        $this->targetPath = $targetPath;
        $this->filter = $filter;

It seems like $filter can also be of type CoiSA\Http\Message\UploadedFile\FilterInterface. However, the property $filter is declared as type callable. Maybe add an additional type check?

    }

    /**
     * {@inheritdoc}
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $uploadedFiles = $request->getUploadedFiles();

        if ($this->filter) {
            $uploadedFiles = $this->filter->filter($uploadedFiles);
        }

        if (!empty($uploadedFiles)) {
            /** @var UploadedFileInterface $uploadedFile */
            foreach ($uploadedFiles as $uploadedFile) {
                $uploadedFile->moveTo($this->targetPath);
            }
        }

        return $handler->handle($request);
    }
}