codysnider / tt-rss

plugins/close_button/init.php

<?php
class Close_Button extends Plugin {
    private $host;

    public function init($host) {
        $this->host = $host;

        $host->add_hook($host::HOOK_ARTICLE_BUTTON, $this);
    }

    public function about() {
        return array(1.0,
            "Adds a button to close article panel",
            "fox");
    }

    public function get_css() {
        return "i.icon-close-article { color : red; }";
    }

    /**
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     */
    public function hook_article_button($line) {

The parameter $line is not used and could be removed.

        if (!get_pref("COMBINED_DISPLAY_MODE")) {
            $rv = "<i class='material-icons icon-close-article'
				style='cursor : pointer' onclick='Article.close()'
				title='".__('Close article')."'>close</i>";
        }

        return $rv;

The variable $rv does not seem to be defined for all execution paths leading up to this point.

    }

    public function api_version() {
        return 2;
    }

}