codysnider / tt-rss

plugins/af_readability/init.php

<?php
use andreskrey\Readability\Readability;
use andreskrey\Readability\Configuration;

class Af_Readability extends Plugin {

    /* @var PluginHost $host */
    private $host;

    public function about() {
        return array(1.0,
            "Try to inline article content using Readability",
            "fox");
    }

    public function flags() {
        return array("needs_curl" => true);
    }

    public function save() {
        $enable_share_anything = checkbox_to_sql_bool($_POST["enable_share_anything"]);

        $this->host->set($this, "enable_share_anything", $enable_share_anything);

        echo __("Data saved.");
    }

    public function init($host)
    {
        $this->host = $host;

        if (version_compare(PHP_VERSION, '7.0.0', '<')) {
            user_error("af_readability requires PHP 7.0", E_USER_WARNING);
            return;
        }

        $host->add_hook($host::HOOK_ARTICLE_FILTER, $this);
        $host->add_hook($host::HOOK_PREFS_TAB, $this);
        $host->add_hook($host::HOOK_PREFS_EDIT_FEED, $this);
        $host->add_hook($host::HOOK_PREFS_SAVE_FEED, $this);

        // Note: we have to install the hook even if disabled because init() is being run before plugin data has loaded
        // so we can't check for our storage-set options here
        $host->add_hook($host::HOOK_GET_FULL_TEXT, $this);

        $host->add_filter_action($this, "action_inline", __("Inline content"));
    }

    public function hook_prefs_tab($args) {
        if ($args != "prefFeeds") {
            return;
        }

        print "<div dojoType='dijit.layout.AccordionPane'
			title=\"<i class='material-icons'>extension</i> ".__('Readability settings (af_readability)')."\">";

        if (version_compare(PHP_VERSION, '7.0.0', '<')) {
            print_error("This plugin requires PHP 7.0.");

The call to print_error() has too many arguments starting with 'This plugin requires PHP 7.0.'.

The function print_error() has been deprecated: Use twig function errorMessage

        } else {

            print "<h2>".__("Global settings")."</h2>";

            print_notice("Enable for specific feeds in the feed editor.");

The call to print_notice() has too many arguments starting with 'Enable for specific feeds in the feed editor.'.

The function print_notice() has been deprecated: Use twig function noticeMessage

            print "<form dojoType='dijit.form.Form'>";

            print "<script type='dojo/method' event='onSubmit' args='evt'>
			evt.preventDefault();
			if (this.validate()) {
				console.log(dojo.objectToQuery(this.getValues()));
				new Ajax.Request('backend.php', {
					parameters: dojo.objectToQuery(this.getValues()),
					onComplete: function(transport) {
						Notify.info(transport.responseText);
					}
				});
				//this.reset();
			}
			</script>";

            print_hidden("op", "pluginhandler");
            print_hidden("method", "save");
            print_hidden("plugin", "af_readability");

            $enable_share_anything = $this->host->get($this, "enable_share_anything");

            print "<fieldset>";
            print "<label class='checkbox'> ";
            print_checkbox("enable_share_anything", $enable_share_anything);
            print " ".__("Provide full-text services to core code (bookmarklets) and other plugins");
            print "</label>";
            print "</fieldset>";

            print_button("submit", __("Save"), "class='alt-primary'");
            print "</form>";

            $enabled_feeds = $this->host->get($this, "enabled_feeds");
            if (!is_array($enabled_feeds)) {
                $enabled_feeds = array();
            }

            $enabled_feeds = $this->filter_unknown_feeds($enabled_feeds);
            $this->host->set($this, "enabled_feeds", $enabled_feeds);

            if (count($enabled_feeds) > 0) {
                print "<h3>".__("Currently enabled for (click to edit):")."</h3>";

                print "<ul class='panel panel-scrollable list list-unstyled'>";
                foreach ($enabled_feeds as $f) {
                    print "<li><i class='material-icons'>rss_feed</i> <a href='#'
						onclick='CommonDialogs.editFeed($f)'>".
                        Feeds::getFeedTitle($f)."</a></li>";
                }
                print "</ul>";
            }

        }

        print "</div>";
    }

    public function hook_prefs_edit_feed($feed_id) {
        print "<header>".__("Readability")."</header>";
        print "<section>";

        $enabled_feeds = $this->host->get($this, "enabled_feeds");
        if (!is_array($enabled_feeds)) {
            $enabled_feeds = array();
        }

        $key = array_search($feed_id, $enabled_feeds);
        $checked = $key !== false ? "checked" : "";

        print "<fieldset>";

        print "<label class='checkbox'><input dojoType='dijit.form.CheckBox' type='checkbox' id='af_readability_enabled'
			name='af_readability_enabled' $checked>&nbsp;".__('Inline article content')."</label>";

        print "</fieldset>";

        print "</section>";
    }

    public function hook_prefs_save_feed($feed_id) {
        $enabled_feeds = $this->host->get($this, "enabled_feeds");
        if (!is_array($enabled_feeds)) {
            $enabled_feeds = array();
        }

        $enable = checkbox_to_sql_bool($_POST["af_readability_enabled"]);
        $key = array_search($feed_id, $enabled_feeds);

        if ($enable) {
            if ($key === false) {
                array_push($enabled_feeds, $feed_id);
            }
        } else {
            if ($key !== false) {
                unset($enabled_feeds[$key]);
            }
        }

        $this->host->set($this, "enabled_feeds", $enabled_feeds);
    }

    /**
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     */
    public function hook_article_filter_action($article, $action) {

The parameter $action is not used and could be removed.

        return $this->process_article($article);
    }

    public function extract_content($url) {

        global $fetch_effective_url;

        $tmp = fetch_file_contents([
            "url" => $url,
            "http_accept" => "text/*",
            "type" => "text/html"]);

        if ($tmp && mb_strlen($tmp) < 1024 * 500) {

It seems like $tmp can also be of type true; however, parameter $str of mb_strlen() does only seem to accept string, maybe add an additional type check?

            $tmpdoc = new DOMDocument("1.0", "UTF-8");

            if (!@$tmpdoc->loadHTML($tmp)) {

It seems like $tmp can also be of type true; however, parameter $source of DOMDocument::loadHTML() does only seem to accept string, maybe add an additional type check?

                            return false;
            }

            // this is the worst hack yet :(
            if (strtolower($tmpdoc->encoding) != 'utf-8') {
                $tmp = preg_replace("/<meta.*?charset.*?\/?>/i", "", $tmp);
                if (empty($tmpdoc->encoding)) {
                    $tmp = mb_convert_encoding($tmp, 'utf-8');
                } else {
                    $tmp = mb_convert_encoding($tmp, 'utf-8', $tmpdoc->encoding);
                }
            }

            try {
                $r = new Readability(new Configuration());

                if ($r->parse($tmp)) {

                    $tmpxpath = new DOMXPath($r->getDOMDOcument());
                    $entries = $tmpxpath->query('(//a[@href]|//img[@src])');

                    foreach ($entries as $entry) {
                        if ($entry->hasAttribute("href")) {
                            $entry->setAttribute("href",
                                    rewrite_relative_url($fetch_effective_url, $entry->getAttribute("href")));

                        }

                        if ($entry->hasAttribute("src")) {
                            $entry->setAttribute("src",
                                    rewrite_relative_url($fetch_effective_url, $entry->getAttribute("src")));

                        }
                    }

                    return $r->getContent();
                }

            } catch (Exception $e) {
                return false;
            }
        }

        return false;
    }

    public function process_article($article) {

        $extracted_content = $this->extract_content($article["link"]);

        # let's see if there's anything of value in there
        $content_test = trim(strip_tags(sanitize($extracted_content)));

        if ($content_test) {
            $article["content"] = $extracted_content;
        }

        return $article;
    }

    public function hook_article_filter($article) {

        $enabled_feeds = $this->host->get($this, "enabled_feeds");
        if (!is_array($enabled_feeds)) {
            return $article;
        }

        $key = array_search($article["feed"]["id"], $enabled_feeds);
        if ($key === false) {
            return $article;
        }

        return $this->process_article($article);

    }

    public function hook_get_full_text($link)
    {
        $enable_share_anything = $this->host->get($this, "enable_share_anything");

        if ($enable_share_anything) {
            $extracted_content = $this->extract_content($link);

            # let's see if there's anything of value in there
            $content_test = trim(strip_tags(sanitize($extracted_content)));

            if ($content_test) {
                return $extracted_content;
            }
        }

        return false;
    }

    public function api_version() {
        return 2;
    }

    private function filter_unknown_feeds($enabled_feeds) {
        $tmp = array();

        foreach ($enabled_feeds as $feed) {

            $sth = $this->pdo->prepare("SELECT id FROM ttrss_feeds WHERE id = ? AND owner_uid = ?");
            $sth->execute([$feed, $_SESSION['uid']]);

            if ($row = $sth->fetch()) {

The assignment to $row is dead and can be removed.

                array_push($tmp, $feed);
            }
        }

        return $tmp;
    }

}