codysnider / tt-rss

lib/phpqrcode/qrimage.php

<?php

/*

 * PHP QR Code encoder

 *

 * Image output of code using GD2

 *

 * PHP QR Code is distributed under LGPL 3

 * Copyright (C) 2010 Dominik Dzienia <deltalab at poczta dot fm>

 *

 * This library is free software; you can redistribute it and/or

 * modify it under the terms of the GNU Lesser General Public

 * License as published by the Free Software Foundation; either

 * version 3 of the License, or any later version.

 *

 * This library is distributed in the hope that it will be useful,

 * but WITHOUT ANY WARRANTY; without even the implied warranty of

 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU

 * Lesser General Public License for more details.

 *

 * You should have received a copy of the GNU Lesser General Public

 * License along with this library; if not, write to the Free Software

 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA

 */

 

    define('QR_IMAGE', true);


    class QRimage {

    

        //----------------------------------------------------------------------

        public static function png($frame, $filename = false, $pixelPerPoint = 4, $outerFrame = 4, $saveandprint = false) 

        {

            $image = self::image($frame, $pixelPerPoint, $outerFrame);

            

            if ($filename === false) {

                Header("Content-type: image/png");

                ImagePng($image);

It seems like $image can also be of type false; however, parameter $image of imagepng() does only seem to accept resource, maybe add an additional type check?

            } else {

                if ($saveandprint === true) {

                    ImagePng($image, $filename);

                    header("Content-type: image/png");

                    ImagePng($image);

                } else {

                    ImagePng($image, $filename);

                }

            }

            

            ImageDestroy($image);

It seems like $image can also be of type false; however, parameter $image of imagedestroy() does only seem to accept resource, maybe add an additional type check?

        }

    

        //----------------------------------------------------------------------

        public static function jpg($frame, $filename = false, $pixelPerPoint = 8, $outerFrame = 4, $q = 85) 

        {

            $image = self::image($frame, $pixelPerPoint, $outerFrame);

            

            if ($filename === false) {

                Header("Content-type: image/jpeg");

                ImageJpeg($image, null, $q);

It seems like $image can also be of type false; however, parameter $image of imagejpeg() does only seem to accept resource, maybe add an additional type check?

            } else {

                ImageJpeg($image, $filename, $q);            

            }

            

            ImageDestroy($image);

It seems like $image can also be of type false; however, parameter $image of imagedestroy() does only seem to accept resource, maybe add an additional type check?

        }

    

        //----------------------------------------------------------------------

        private static function image($frame, $pixelPerPoint = 4, $outerFrame = 4) 

        {

            $h = count($frame);

            $w = strlen($frame[0]);

            

            $imgW = $w + 2 * $outerFrame;

            $imgH = $h + 2 * $outerFrame;

            

            $base_image = ImageCreate($imgW, $imgH);

            

            $col[0] = ImageColorAllocate($base_image, 255, 255, 255);

$col was never initialized. Although not strictly required by PHP, it is generally a good practice to add $col = array(); before regardless.

It seems like $base_image can also be of type false; however, parameter $image of imagecolorallocate() does only seem to accept resource, maybe add an additional type check?

            $col[1] = ImageColorAllocate($base_image, 0, 0, 0);


            imagefill($base_image, 0, 0, $col[0]);

It seems like $base_image can also be of type false; however, parameter $image of imagefill() does only seem to accept resource, maybe add an additional type check?

            for ($y = 0; $y < $h; $y++) {

                for ($x = 0; $x < $w; $x++) {

                    if ($frame[$y][$x] == '1') {

                        ImageSetPixel($base_image, $x + $outerFrame, $y + $outerFrame, $col[1]); 

It seems like $base_image can also be of type false; however, parameter $image of imagesetpixel() does only seem to accept resource, maybe add an additional type check?

                    }

                }

            }

            

            $target_image = ImageCreate($imgW * $pixelPerPoint, $imgH * $pixelPerPoint);

            ImageCopyResized($target_image, $base_image, 0, 0, 0, 0, $imgW * $pixelPerPoint, $imgH * $pixelPerPoint, $imgW, $imgH);

It seems like $target_image can also be of type false; however, parameter $dst_image of imagecopyresized() does only seem to accept resource, maybe add an additional type check?

It seems like $base_image can also be of type false; however, parameter $src_image of imagecopyresized() does only seem to accept resource, maybe add an additional type check?

            ImageDestroy($base_image);

It seems like $base_image can also be of type false; however, parameter $image of imagedestroy() does only seem to accept resource, maybe add an additional type check?

            

            return $target_image;

        }

    }