Issues (1270)

lib/floIcon.php (6 issues)

1
<?php
2
// Compatibility shim for hooking up jimIcon to Tiny Tiny RSS.
3
4
require_once "jimIcon.php";
5
6
class floIconIcon {
7
        function getImageResource() {
0 ignored issues
show
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
8
                return $this->img;
0 ignored issues
show
Bug Best Practice introduced by
The property img does not exist on floIconIcon. Did you maybe forget to declare it?
Loading history...
9
        }
10
}
11
12
class floIcon {
13
        function readICO($file) {
0 ignored issues
show
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
14
                $jim = new jimIcon();
15
                $icon = new floIconIcon();
16
                $icon->img = $jim->fromiconstring(file_get_contents($file));
0 ignored issues
show
The property img does not seem to exist on floIconIcon.
Loading history...
17
                $this->images = array($icon);
0 ignored issues
show
Bug Best Practice introduced by
The property images does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.
Loading history...
18
        }
19
}
20
?>
0 ignored issues
show
It is not recommended to use PHP's closing tag ?> in files other than templates.

Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore.

A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever.

Loading history...
21