Passed
Push — master ( 5a5c41...fade3b )
by Cody
04:50 queued 10s
created
register.php 1 patch
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,7 +18,9 @@  discard block
 block discarded – undo
18 18
 
19 19
 	$action = $_REQUEST["action"];
20 20
 
21
-	if (!init_plugins()) return;
21
+	if (!init_plugins()) {
22
+		return;
23
+	}
22 24
 
23 25
 	if ($_REQUEST["format"] == "feed") {
24 26
 		header("Content-Type: text/xml");
@@ -35,7 +37,9 @@  discard block
 block discarded – undo
35 37
 			$num_users = db_fetch_result($result, 0, "cu");
36 38
 
37 39
 			$num_users = REG_MAX_USERS - $num_users;
38
-			if ($num_users < 0) $num_users = 0;
40
+			if ($num_users < 0) {
41
+				$num_users = 0;
42
+			}
39 43
 			$reg_suffix = "enabled";
40 44
 		} else {
41 45
 			$num_users = 0;
@@ -310,7 +314,9 @@  discard block
 block discarded – undo
310 314
 						"subject" => "Registration information for Tiny Tiny RSS",
311 315
 						"message" => $reg_text]);
312 316
 
313
-					if (!$rc) print_error($mailer->error());
317
+					if (!$rc) {
318
+						print_error($mailer->error());
319
+					}
314 320
 
315 321
 					$reg_text = "Hi!\n".
316 322
 						"\n".
@@ -324,7 +330,9 @@  discard block
 block discarded – undo
324 330
 						"subject" => "Registration notice for Tiny Tiny RSS",
325 331
 						"message" => $reg_text]);
326 332
 
327
-					if (!$rc) print_error($mailer->error());
333
+					if (!$rc) {
334
+						print_error($mailer->error());
335
+					}
328 336
 
329 337
 					print_notice(__("Account created successfully."));
330 338
 
Please login to merge, or discard this patch.
update.php 1 patch
Braces   +32 added lines, -19 removed lines patch added patch discarded remove patch
@@ -59,8 +59,9 @@  discard block
 block discarded – undo
59 59
 		return $tags_deleted;
60 60
 	}
61 61
 
62
-	if (!defined('PHP_EXECUTABLE'))
63
-		define('PHP_EXECUTABLE', '/usr/bin/php');
62
+	if (!defined('PHP_EXECUTABLE')) {
63
+			define('PHP_EXECUTABLE', '/usr/bin/php');
64
+	}
64 65
 
65 66
 	$pdo = Db::pdo();
66 67
 
@@ -249,8 +250,9 @@  discard block
 block discarded – undo
249 250
 
250 251
 		RSSUtils::update_daemon_common(isset($options["pidlock"]) ? 50 : DAEMON_FEED_LIMIT);
251 252
 
252
-		if (!isset($options["pidlock"]) || $options["task"] == 0)
253
-			RSSUtils::housekeeping_common(true);
253
+		if (!isset($options["pidlock"]) || $options["task"] == 0) {
254
+					RSSUtils::housekeeping_common(true);
255
+		}
254 256
 
255 257
 		PluginHost::getInstance()->run_hooks(PluginHost::HOOK_UPDATE_TASK, "hook_update_task", $op);
256 258
 	}
@@ -264,8 +266,9 @@  discard block
 block discarded – undo
264 266
 		Debug::log("PLEASE BACKUP YOUR DATABASE BEFORE PROCEEDING!");
265 267
 		Debug::log("Type 'yes' to continue.");
266 268
 
267
-		if (read_stdin() != 'yes')
268
-			exit;
269
+		if (read_stdin() != 'yes') {
270
+					exit;
271
+		}
269 272
 
270 273
 		Debug::log("clearing existing indexes...");
271 274
 
@@ -319,8 +322,9 @@  discard block
 block discarded – undo
319 322
 		Debug::log("WARNING: this will remove all existing type2 filters.");
320 323
 		Debug::log("Type 'yes' to continue.");
321 324
 
322
-		if (read_stdin() != 'yes')
323
-			exit;
325
+		if (read_stdin() != 'yes') {
326
+					exit;
327
+		}
324 328
 
325 329
 		Debug::log("converting filters...");
326 330
 
@@ -374,16 +378,18 @@  discard block
 block discarded – undo
374 378
 		if ($updater->isUpdateRequired()) {
375 379
 			Debug::log("Schema update required, version " . $updater->getSchemaVersion() . " to " . SCHEMA_VERSION);
376 380
 
377
-			if (DB_TYPE == "mysql")
378
-				Debug::Log("READ THIS: Due to MySQL limitations, your database is not completely protected while updating.\n".
381
+			if (DB_TYPE == "mysql") {
382
+							Debug::Log("READ THIS: Due to MySQL limitations, your database is not completely protected while updating.\n".
379 383
 					"Errors may put it in an inconsistent state requiring manual rollback.\nBACKUP YOUR DATABASE BEFORE CONTINUING.");
380
-			else
381
-				Debug::log("WARNING: please backup your database before continuing.");
384
+			} else {
385
+							Debug::log("WARNING: please backup your database before continuing.");
386
+			}
382 387
 
383 388
 			Debug::log("Type 'yes' to continue.");
384 389
 
385
-			if (read_stdin() != 'yes')
386
-				exit;
390
+			if (read_stdin() != 'yes') {
391
+							exit;
392
+			}
387 393
 
388 394
 			Debug::log("Performing updates to version " . SCHEMA_VERSION);
389 395
 
@@ -456,7 +462,9 @@  discard block
 block discarded – undo
456 462
 
457 463
 			$status = $about[3] ? "system" : "user";
458 464
 
459
-			if (in_array($name, $enabled)) $name .= "*";
465
+			if (in_array($name, $enabled)) {
466
+				$name .= "*";
467
+			}
460 468
 
461 469
 			printf("%-50s %-10s v%.2f (by %s)\n%s\n\n",
462 470
 				$name, $status, $about[0], $about[2], $about[1]);
@@ -469,8 +477,12 @@  discard block
 block discarded – undo
469 477
 	if (isset($options["debug-feed"])) {
470 478
 		$feed = $options["debug-feed"];
471 479
 
472
-		if (isset($options["force-refetch"])) $_REQUEST["force_refetch"] = true;
473
-		if (isset($options["force-rehash"])) $_REQUEST["force_rehash"] = true;
480
+		if (isset($options["force-refetch"])) {
481
+			$_REQUEST["force_refetch"] = true;
482
+		}
483
+		if (isset($options["force-rehash"])) {
484
+			$_REQUEST["force_rehash"] = true;
485
+		}
474 486
 
475 487
 		Debug::set_loglevel(Debug::$LOG_EXTENDED);
476 488
 
@@ -485,7 +497,8 @@  discard block
 block discarded – undo
485 497
 
486 498
 	PluginHost::getInstance()->run_commands($options);
487 499
 
488
-	if (file_exists(LOCK_DIRECTORY . "/$lock_filename"))
489
-		if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN')
500
+	if (file_exists(LOCK_DIRECTORY . "/$lock_filename")) {
501
+			if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN')
490 502
 			fclose($lock_handle);
503
+	}
491 504
 		unlink(LOCK_DIRECTORY . "/$lock_filename");
Please login to merge, or discard this patch.
backend.php 1 patch
Braces   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -5,10 +5,11 @@  discard block
 block discarded – undo
5 5
 	$op = $_REQUEST["op"];
6 6
 	@$method = $_REQUEST['subop'] ? $_REQUEST['subop'] : $_REQUEST["method"];
7 7
 
8
-	if (!$method)
9
-		$method = 'index';
10
-	else
11
-		$method = strtolower($method);
8
+	if (!$method) {
9
+			$method = 'index';
10
+	} else {
11
+			$method = strtolower($method);
12
+	}
12 13
 
13 14
 	/* Public calls compatibility shim */
14 15
 
@@ -33,7 +34,9 @@  discard block
 block discarded – undo
33 34
 
34 35
 	$script_started = microtime(true);
35 36
 
36
-	if (!init_plugins()) return;
37
+	if (!init_plugins()) {
38
+		return;
39
+	}
37 40
 
38 41
 	header("Content-Type: text/json; charset=utf-8");
39 42
 
Please login to merge, or discard this patch.
public.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,9 @@
 block discarded – undo
14 14
 
15 15
 	$script_started = microtime(true);
16 16
 
17
-	if (!init_plugins()) return;
17
+	if (!init_plugins()) {
18
+		return;
19
+	}
18 20
 
19 21
 	if (ENABLE_GZIP_OUTPUT && function_exists("ob_gzhandler")) {
20 22
 		ob_start("ob_gzhandler");
Please login to merge, or discard this patch.
include/autoload.php 1 patch
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -5,8 +5,9 @@  discard block
 block discarded – undo
5 5
 		$namespace = '';
6 6
 		$class_name = $class;
7 7
 
8
-		if (strpos($class, '\\') !== FALSE)
9
-			list ($namespace, $class_name) = explode('\\', $class, 2);
8
+		if (strpos($class, '\\') !== FALSE) {
9
+					list ($namespace, $class_name) = explode('\\', $class, 2);
10
+		}
10 11
 
11 12
 		$root_dir = dirname(__DIR__); // we're in tt-rss/include
12 13
 
@@ -20,7 +21,8 @@  discard block
 block discarded – undo
20 21
 			$class_file = "$root_dir/classes/" . str_replace("_", "/", strtolower($class)) . ".php";
21 22
 		}
22 23
 
23
-		if (file_exists($class_file))
24
-			include $class_file;
24
+		if (file_exists($class_file)) {
25
+					include $class_file;
26
+		}
25 27
 
26 28
 	});
Please login to merge, or discard this patch.
include/controls.php 1 patch
Braces   +54 added lines, -32 removed lines patch added patch discarded remove patch
@@ -1,14 +1,17 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3 3
 function print_select($id, $default, $values, $attributes = "", $name = "") {
4
-	if (!$name) $name = $id;
4
+	if (!$name) {
5
+		$name = $id;
6
+	}
5 7
 
6 8
 	print "<select name=\"$name\" id=\"$id\" $attributes>";
7 9
 	foreach ($values as $v) {
8
-		if ($v == $default)
9
-			$sel = "selected=\"1\"";
10
-		else
11
-			$sel = "";
10
+		if ($v == $default) {
11
+					$sel = "selected=\"1\"";
12
+		} else {
13
+					$sel = "";
14
+		}
12 15
 
13 16
 		$v = trim($v);
14 17
 
@@ -18,14 +21,17 @@  discard block
 block discarded – undo
18 21
 }
19 22
 
20 23
 function print_select_hash($id, $default, $values, $attributes = "", $name = "") {
21
-	if (!$name) $name = $id;
24
+	if (!$name) {
25
+		$name = $id;
26
+	}
22 27
 
23 28
 	print "<select name=\"$name\" id='$id' $attributes>";
24 29
 	foreach (array_keys($values) as $v) {
25
-		if ($v == $default)
26
-			$sel = 'selected="selected"';
27
-		else
28
-			$sel = "";
30
+		if ($v == $default) {
31
+					$sel = 'selected="selected"';
32
+		} else {
33
+					$sel = "";
34
+		}
29 35
 
30 36
 		$v = trim($v);
31 37
 
@@ -53,10 +59,11 @@  discard block
 block discarded – undo
53 59
 function print_radio($id, $default, $true_is, $values, $attributes = "") {
54 60
 	foreach ($values as $v) {
55 61
 
56
-		if ($v == $default)
57
-			$sel = "checked";
58
-		else
59
-			$sel = "";
62
+		if ($v == $default) {
63
+					$sel = "checked";
64
+		} else {
65
+					$sel = "";
66
+		}
60 67
 
61 68
 		if ($v == $true_is) {
62 69
 			$sel .= " value=\"1\"";
@@ -88,7 +95,9 @@  discard block
 block discarded – undo
88 95
 
89 96
 	if (get_pref('ENABLE_FEED_CATS')) {
90 97
 
91
-		if (!$root_id) $root_id = null;
98
+		if (!$root_id) {
99
+			$root_id = null;
100
+		}
92 101
 
93 102
 		$sth = $pdo->prepare("SELECT id,title,
94 103
 				(SELECT COUNT(id) FROM ttrss_feed_categories AS c2 WHERE
@@ -101,17 +110,19 @@  discard block
 block discarded – undo
101 110
 
102 111
 		while ($line = $sth->fetch()) {
103 112
 
104
-			for ($i = 0; $i < $nest_level; $i++)
105
-				$line["title"] = " - " . $line["title"];
113
+			for ($i = 0; $i < $nest_level; $i++) {
114
+							$line["title"] = " - " . $line["title"];
115
+			}
106 116
 
107 117
 			$is_selected = in_array("CAT:".$line["id"], $default_ids) ? "selected=\"1\"" : "";
108 118
 
109 119
 			printf("<option $is_selected value='CAT:%d'>%s</option>",
110 120
 				$line["id"], htmlspecialchars($line["title"]));
111 121
 
112
-			if ($line["num_children"] > 0)
113
-				print_feed_multi_select($id, $default_ids, $attributes,
122
+			if ($line["num_children"] > 0) {
123
+							print_feed_multi_select($id, $default_ids, $attributes,
114 124
 					$include_all_feeds, $line["id"], $nest_level+1);
125
+			}
115 126
 
116 127
 			$f_sth = $pdo->prepare("SELECT id,title FROM ttrss_feeds
117 128
 					WHERE cat_id = ? AND owner_uid = ? ORDER BY title");
@@ -123,8 +134,9 @@  discard block
 block discarded – undo
123 134
 
124 135
 				$fline["title"] = " + " . $fline["title"];
125 136
 
126
-				for ($i = 0; $i < $nest_level; $i++)
127
-					$fline["title"] = " - " . $fline["title"];
137
+				for ($i = 0; $i < $nest_level; $i++) {
138
+									$fline["title"] = " - " . $fline["title"];
139
+				}
128 140
 
129 141
 				printf("<option $is_selected value='%d'>%s</option>",
130 142
 					$fline["id"], htmlspecialchars($fline["title"]));
@@ -146,8 +158,9 @@  discard block
 block discarded – undo
146 158
 
147 159
 				$fline["title"] = " + " . $fline["title"];
148 160
 
149
-				for ($i = 0; $i < $nest_level; $i++)
150
-					$fline["title"] = " - " . $fline["title"];
161
+				for ($i = 0; $i < $nest_level; $i++) {
162
+									$fline["title"] = " - " . $fline["title"];
163
+				}
151 164
 
152 165
 				printf("<option $is_selected value='%d'>%s</option>",
153 166
 					$fline["id"], htmlspecialchars($fline["title"]));
@@ -182,7 +195,9 @@  discard block
 block discarded – undo
182 195
 
183 196
 	$pdo = DB::pdo();
184 197
 
185
-	if (!$root_id) $root_id = null;
198
+	if (!$root_id) {
199
+		$root_id = null;
200
+	}
186 201
 
187 202
 	$sth = $pdo->prepare("SELECT id,title,
188 203
 				(SELECT COUNT(id) FROM ttrss_feed_categories AS c2 WHERE
@@ -203,16 +218,19 @@  discard block
 block discarded – undo
203 218
 			$is_selected = "";
204 219
 		}
205 220
 
206
-		for ($i = 0; $i < $nest_level; $i++)
207
-			$line["title"] = " - " . $line["title"];
221
+		for ($i = 0; $i < $nest_level; $i++) {
222
+					$line["title"] = " - " . $line["title"];
223
+		}
208 224
 
209
-		if ($line["title"])
210
-			printf("<option $is_selected value='%d'>%s</option>",
225
+		if ($line["title"]) {
226
+					printf("<option $is_selected value='%d'>%s</option>",
211 227
 				$line["id"], htmlspecialchars($line["title"]));
228
+		}
212 229
 
213
-		if ($line["num_children"] > 0)
214
-			print_feed_cat_select($id, $default_id, $attributes,
230
+		if ($line["num_children"] > 0) {
231
+					print_feed_cat_select($id, $default_id, $attributes,
215 232
 				$include_all_cats, $line["id"], $nest_level+1);
233
+		}
216 234
 	}
217 235
 
218 236
 	if (!$root_id) {
@@ -251,7 +269,9 @@  discard block
 block discarded – undo
251 269
 
252 270
 	$timestamp = filemtime($filename);
253 271
 
254
-	if ($query) $timestamp .= "&$query";
272
+	if ($query) {
273
+		$timestamp .= "&$query";
274
+	}
255 275
 
256 276
 	return "<script type=\"text/javascript\" charset=\"utf-8\" src=\"$filename?$timestamp\"></script>\n";
257 277
 }
@@ -299,8 +319,10 @@  discard block
 block discarded – undo
299 319
 
300 320
 		}
301 321
 
302
-		if ($entry) $entry .= "<a target=\"_blank\" rel=\"noopener noreferrer\"
322
+		if ($entry) {
323
+			$entry .= "<a target=\"_blank\" rel=\"noopener noreferrer\"
303 324
 				href=\"$url\">" . basename($url) . "</a>";
325
+		}
304 326
 
305 327
 		$entry .= "</div>";
306 328
 
Please login to merge, or discard this patch.
include/errorhandler.php 1 patch
Braces   +16 added lines, -8 removed lines patch added patch discarded remove patch
@@ -32,16 +32,19 @@  discard block
 block discarded – undo
32 32
 }
33 33
 
34 34
 function ttrss_error_handler($errno, $errstr, $file, $line, $context) {
35
-	if (error_reporting() == 0 || !$errno) return false;
35
+	if (error_reporting() == 0 || !$errno) {
36
+		return false;
37
+	}
36 38
 
37 39
 	$file = substr(str_replace(dirname(dirname(__FILE__)), "", $file), 1);
38 40
 
39 41
 	$context = format_backtrace(debug_backtrace());
40 42
 	$errstr = truncate_middle($errstr, 16384, " (...) ");
41 43
 
42
-	if (class_exists("Logger"))
43
-		return Logger::get()->log_error($errno, $errstr, $file, $line, $context);
44
-}
44
+	if (class_exists("Logger")) {
45
+			return Logger::get()->log_error($errno, $errstr, $file, $line, $context);
46
+	}
47
+	}
45 48
 
46 49
 function ttrss_fatal_handler() {
47 50
 	global $last_query;
@@ -54,16 +57,21 @@  discard block
 block discarded – undo
54 57
 		$line = $error["line"];
55 58
 		$errstr  = $error["message"];
56 59
 
57
-		if (!$errno) return false;
60
+		if (!$errno) {
61
+			return false;
62
+		}
58 63
 
59 64
 		$context = format_backtrace(debug_backtrace());
60 65
 
61 66
 		$file = substr(str_replace(dirname(dirname(__FILE__)), "", $file), 1);
62 67
 
63
-		if ($last_query) $errstr .= " [Last query: $last_query]";
68
+		if ($last_query) {
69
+			$errstr .= " [Last query: $last_query]";
70
+		}
64 71
 
65
-		if (class_exists("Logger"))
66
-			return Logger::get()->log_error($errno, $errstr, $file, $line, $context);
72
+		if (class_exists("Logger")) {
73
+					return Logger::get()->log_error($errno, $errstr, $file, $line, $context);
74
+		}
67 75
 	}
68 76
 
69 77
 	return false;
Please login to merge, or discard this patch.
prefs.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,9 @@
 block discarded – undo
19 19
 	require_once "config.php";
20 20
 	require_once "db-prefs.php";
21 21
 
22
-	if (!init_plugins()) return;
22
+	if (!init_plugins()) {
23
+		return;
24
+	}
23 25
 
24 26
 	login_sequence();
25 27
 
Please login to merge, or discard this patch.
plugins/auth_remote/init.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -44,10 +44,16 @@
 block discarded – undo
44 44
 		$try_login = $_SERVER["REMOTE_USER"];
45 45
 
46 46
 		// php-cgi
47
-		if (!$try_login) $try_login = $_SERVER["REDIRECT_REMOTE_USER"];
48
-		if (!$try_login) $try_login = $_SERVER["PHP_AUTH_USER"];
47
+		if (!$try_login) {
48
+			$try_login = $_SERVER["REDIRECT_REMOTE_USER"];
49
+		}
50
+		if (!$try_login) {
51
+			$try_login = $_SERVER["PHP_AUTH_USER"];
52
+		}
49 53
 
50
-		if (!$try_login) $try_login = $this->get_login_by_ssl_certificate();
54
+		if (!$try_login) {
55
+			$try_login = $this->get_login_by_ssl_certificate();
56
+		}
51 57
 
52 58
 		if ($try_login) {
53 59
 			$user_id = $this->base->auto_create_user($try_login, $password);
Please login to merge, or discard this patch.