Db_Prefs::read() - Code Metrics - Inspection of "Merge pull request #3 from codysnider/codysnider/c..." - codysnider/tt-rss - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5a5c41...fade3b )

by Cody

created 2019-12-20 20:43 UTC

Db_Prefs::read() B

↳ Parent: Db_Prefs

Complexity

Conditions	10
Paths	18

Size

Total Lines	44
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	10
eloc	23
c	2
b	0
f	0
nc	18
nop	3
dl	0
loc	44
rs	7.6666

How to fix Complexity

<?php
class Db_Prefs {
	private $pdo;
	private static $instance;
	private $cache;

	public function __construct() {
		$this->pdo = Db::pdo();
		$this->cache = array();

		if ($_SESSION["uid"]) $this->cache();
	}

	public static function get() {
		if (self::$instance == null)
			self::$instance = new self();

		return self::$instance;
	}

	public function cache() {
		$user_id = $_SESSION["uid"];
		@$profile = $_SESSION["profile"];

		if (!is_numeric($profile) || !$profile || get_schema_version() < 63) $profile = null;

		$sth = $this->pdo->prepare("SELECT
			value,ttrss_prefs_types.type_name as type_name,ttrss_prefs.pref_name AS pref_name
			FROM
				ttrss_user_prefs,ttrss_prefs,ttrss_prefs_types
			WHERE
				(profile = :profile OR (:profile IS NULL AND profile IS NULL)) AND
				ttrss_prefs.pref_name NOT LIKE '_MOBILE%' AND
				ttrss_prefs_types.id = type_id AND
				owner_uid = :uid AND
				ttrss_user_prefs.pref_name = ttrss_prefs.pref_name");

		$sth->execute([":profile" => $profile, ":uid" => $user_id]);

		while ($line = $sth->fetch()) {
			if ($user_id == $_SESSION["uid"]) {
				$pref_name = $line["pref_name"];

				$this->cache[$pref_name]["type"] = $line["type_name"];
				$this->cache[$pref_name]["value"] = $line["value"];
			}
		}
	}

	public function read($pref_name, $user_id = false, $die_on_error = false) {

		if (!$user_id) {
			$user_id = $_SESSION["uid"];
			@$profile = $_SESSION["profile"];
		} else {
			$profile = false;
		}

		if ($user_id == $_SESSION['uid'] && isset($this->cache[$pref_name])) {
			$tuple = $this->cache[$pref_name];
			return $this->convert($tuple["value"], $tuple["type"]);
		}

		if (!is_numeric($profile) || !$profile || get_schema_version() < 63) $profile = null;

		$sth = $this->pdo->prepare("SELECT
			value,ttrss_prefs_types.type_name as type_name
			FROM
				ttrss_user_prefs,ttrss_prefs,ttrss_prefs_types
			WHERE
				(profile = :profile OR (:profile IS NULL AND profile IS NULL)) AND
				ttrss_user_prefs.pref_name = :pref_name AND
				ttrss_prefs_types.id = type_id AND
				owner_uid = :uid AND
				ttrss_user_prefs.pref_name = ttrss_prefs.pref_name");
		$sth->execute([":uid" => $user_id, ":profile" => $profile, ":pref_name" => $pref_name]);

		if ($row = $sth->fetch()) {
			$value = $row["value"];
			$type_name = $row["type_name"];

			if ($user_id == $_SESSION["uid"]) {
				$this->cache[$pref_name]["type"] = $type_name;
				$this->cache[$pref_name]["value"] = $value;
			}

			return $this->convert($value, $type_name);

		} else if ($die_on_error) {
			user_error("Fatal error, unknown preferences key: $pref_name (owner: $user_id)", E_USER_ERROR);
			return null;
		} else {
			return null;
		}
	}

	public function convert($value, $type_name) {
		if ($type_name == "bool") {
			return $value == "true";
		} else if ($type_name == "integer") {
			return (int)$value;
		} else {
			return $value;
		}
	}

	public function write($pref_name, $value, $user_id = false, $strip_tags = true) {
		if ($strip_tags) $value = strip_tags($value);

		if (!$user_id) {
			$user_id = $_SESSION["uid"];
			@$profile = $_SESSION["profile"];
		} else {
			$profile = null;
		}

		if (!is_numeric($profile) || !$profile || get_schema_version() < 63) $profile = null;

		$type_name = "";
		$current_value = "";

		if (isset($this->cache[$pref_name])) {
			$type_name = $this->cache[$pref_name]["type"];
			$current_value = $this->cache[$pref_name]["value"];
		}

		if (!$type_name) {
			$sth = $this->pdo->prepare("SELECT type_name
				FROM ttrss_prefs,ttrss_prefs_types
				WHERE pref_name = ? AND type_id = ttrss_prefs_types.id");
			$sth->execute([$pref_name]);

			if ($row = $sth->fetch())
				$type_name = $row["type_name"];

		} else if ($current_value == $value) {
			return;
		}

		if ($type_name) {
			if ($type_name == "bool") {
				if ($value == "1" || $value == "true") {
					$value = "true";
				} else {
					$value = "false";
				}
			} else if ($type_name == "integer") {
				$value = (int)$value;
			}

			if ($pref_name == 'USER_TIMEZONE' && $value == '') {
				$value = 'UTC';
			}

			$sth = $this->pdo->prepare("UPDATE ttrss_user_prefs SET
				value = :value WHERE pref_name = :pref_name
					AND (profile = :profile OR (:profile IS NULL AND profile IS NULL))
					AND owner_uid = :uid");

			$sth->execute([":pref_name" => $pref_name, ":value" => $value, ":uid" => $user_id, ":profile" => $profile]);

			if ($user_id == $_SESSION["uid"]) {
				$this->cache[$pref_name]["type"] = $type_name;
				$this->cache[$pref_name]["value"] = $value;
			}
		}
	}
}


1			<?php
2			class Db_Prefs {
3			private $pdo;
4			private static $instance;
5			private $cache;
6
7			public function __construct() {
8			$this->pdo = Db::pdo();
9			$this->cache = array();
10
11			if ($_SESSION["uid"]) $this->cache();
12			}
13
14			public static function get() {
15			if (self::$instance == null)
16			self::$instance = new self();
17
18			return self::$instance;
19			}
20
21			public function cache() {
22			$user_id = $_SESSION["uid"];
23			@$profile = $_SESSION["profile"];
24
25			if (!is_numeric($profile) \|\| !$profile \|\| get_schema_version() < 63) $profile = null;
26
27			$sth = $this->pdo->prepare("SELECT
28			value,ttrss_prefs_types.type_name as type_name,ttrss_prefs.pref_name AS pref_name
29			FROM
30			ttrss_user_prefs,ttrss_prefs,ttrss_prefs_types
31			WHERE
32			(profile = :profile OR (:profile IS NULL AND profile IS NULL)) AND
33			ttrss_prefs.pref_name NOT LIKE '_MOBILE%' AND
34			ttrss_prefs_types.id = type_id AND
35			owner_uid = :uid AND
36			ttrss_user_prefs.pref_name = ttrss_prefs.pref_name");
37
38			$sth->execute([":profile" => $profile, ":uid" => $user_id]);
39
40			while ($line = $sth->fetch()) {
41			if ($user_id == $_SESSION["uid"]) {
42			$pref_name = $line["pref_name"];
43
44			$this->cache[$pref_name]["type"] = $line["type_name"];
45			$this->cache[$pref_name]["value"] = $line["value"];
46			}
47			}
48			}
49
50			public function read($pref_name, $user_id = false, $die_on_error = false) {
51
52			if (!$user_id) {
53			$user_id = $_SESSION["uid"];
54			@$profile = $_SESSION["profile"];
55			} else {
56			$profile = false;
57			}
58
59			if ($user_id == $_SESSION['uid'] && isset($this->cache[$pref_name])) {
60			$tuple = $this->cache[$pref_name];
61			return $this->convert($tuple["value"], $tuple["type"]);
62			}
63
64			if (!is_numeric($profile) \|\| !$profile \|\| get_schema_version() < 63) $profile = null;
65
66			$sth = $this->pdo->prepare("SELECT
67			value,ttrss_prefs_types.type_name as type_name
68			FROM
69			ttrss_user_prefs,ttrss_prefs,ttrss_prefs_types
70			WHERE
71			(profile = :profile OR (:profile IS NULL AND profile IS NULL)) AND
72			ttrss_user_prefs.pref_name = :pref_name AND
73			ttrss_prefs_types.id = type_id AND
74			owner_uid = :uid AND
75			ttrss_user_prefs.pref_name = ttrss_prefs.pref_name");
76			$sth->execute([":uid" => $user_id, ":profile" => $profile, ":pref_name" => $pref_name]);
77
78			if ($row = $sth->fetch()) {
79			$value = $row["value"];
80			$type_name = $row["type_name"];
81
82			if ($user_id == $_SESSION["uid"]) {
83			$this->cache[$pref_name]["type"] = $type_name;
84			$this->cache[$pref_name]["value"] = $value;
85			}
86
87			return $this->convert($value, $type_name);
88
89			} else if ($die_on_error) {
90			user_error("Fatal error, unknown preferences key: $pref_name (owner: $user_id)", E_USER_ERROR);
91			return null;
92			} else {
93			return null;
94			}
95			}
96
97			public function convert($value, $type_name) {
98			if ($type_name == "bool") {
99			return $value == "true";
100			} else if ($type_name == "integer") {
101			return (int)$value;
102			} else {
103			return $value;
104			}
105			}
106
107			public function write($pref_name, $value, $user_id = false, $strip_tags = true) {
108			if ($strip_tags) $value = strip_tags($value);
109
110			if (!$user_id) {
111			$user_id = $_SESSION["uid"];
112			@$profile = $_SESSION["profile"];
113			} else {
114			$profile = null;
115			}
116
117			if (!is_numeric($profile) \|\| !$profile \|\| get_schema_version() < 63) $profile = null;
118
119			$type_name = "";
120			$current_value = "";
121
122			if (isset($this->cache[$pref_name])) {
123			$type_name = $this->cache[$pref_name]["type"];
124			$current_value = $this->cache[$pref_name]["value"];
125			}
126
127			if (!$type_name) {
128			$sth = $this->pdo->prepare("SELECT type_name
129			FROM ttrss_prefs,ttrss_prefs_types
130			WHERE pref_name = ? AND type_id = ttrss_prefs_types.id");
131			$sth->execute([$pref_name]);
132
133			if ($row = $sth->fetch())
134			$type_name = $row["type_name"];
135
136			} else if ($current_value == $value) {
137			return;
138			}
139
140			if ($type_name) {
141			if ($type_name == "bool") {
142			if ($value == "1" \|\| $value == "true") {
143			$value = "true";
144			} else {
145			$value = "false";
146			}
147			} else if ($type_name == "integer") {
148			$value = (int)$value;
149			}
150
151			if ($pref_name == 'USER_TIMEZONE' && $value == '') {
152			$value = 'UTC';
153			}
154
155			$sth = $this->pdo->prepare("UPDATE ttrss_user_prefs SET
156			value = :value WHERE pref_name = :pref_name
157			AND (profile = :profile OR (:profile IS NULL AND profile IS NULL))
158			AND owner_uid = :uid");
159
160			$sth->execute([":pref_name" => $pref_name, ":value" => $value, ":uid" => $user_id, ":profile" => $profile]);
161
162			if ($user_id == $_SESSION["uid"]) {
163			$this->cache[$pref_name]["type"] = $type_name;
164			$this->cache[$pref_name]["value"] = $value;
165			}
166			}
167			}
168			}
169

codysnider / tt-rss

Push — master ( 5a5c41...fade3b )

Db_Prefs::read() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like