Debug::log()

Complexity

Conditions	12
Paths	23

Size

Total Lines	51
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function log($message, $level = 0) {

        if (!Debug::$enabled || Debug::$loglevel < $level) {
            return false;
        }

        $ts = strftime("%H:%M:%S", time());
        if (function_exists('posix_getpid')) {
            $ts = "$ts/".posix_getpid();
        }

        if (Debug::$logfile) {
            $fp = fopen(Debug::$logfile, 'a+');

Debug::logfile of type true is incompatible with the type string expected by parameter $filename of fopen().

            if ($fp) {

$fp is of type false|resource, thus it always evaluated to false.

                $locked = false;

                if (function_exists("flock")) {
                    $tries = 0;

                    // try to lock logfile for writing
                    while ($tries < 5 && !$locked = flock($fp, LOCK_EX | LOCK_NB)) {
                        sleep(1);
                        ++$tries;
                    }

                    if (!$locked) {
                        fclose($fp);
                        user_error("Unable to lock debugging log file: ".Debug::$logfile, E_USER_WARNING);
                        return;
                    }
                }

                fputs($fp, "[$ts] $message\n");

                if (function_exists("flock")) {
                    flock($fp, LOCK_UN);
                }

                fclose($fp);

                if (Debug::$quiet) {
                                    return;
                }

            } else {
                user_error("Unable to open debugging log file: ".Debug::$logfile, E_USER_WARNING);

Are you sure Debug::logfile of type true can be used in concatenation?

            }
        }

        print "[$ts] $message\n";
    }
}