Af_Fsckportal

Complexity

Total Complexity

8

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	hook_article_filter()	0	23	5
A	init()	0	4	1
A	api_version()	0	2	1
A	about()	0	4	1

<?php
class Af_Fsckportal extends Plugin {

    private $host;

    public function about() {
        return array(1.0,
            "Remove feedsportal spamlinks from article content",
            "fox");
    }

    public function init($host) {
        $this->host = $host;

        $host->add_hook($host::HOOK_ARTICLE_FILTER, $this);
    }

    public function hook_article_filter($article) {

            $doc = new DOMDocument();

            @$doc->loadHTML('<?xml encoding="UTF-8">'.$article["content"]);

It seems like you do not handle an error condition for loadHTML(). This can introduce security issues, and is generally not recommended.

            if ($doc) {

$doc is of type DOMDocument, thus it always evaluated to true.

                $xpath = new DOMXPath($doc);
                $entries = $xpath->query('(//img[@src]|//a[@href])');

                foreach ($entries as $entry) {
                    if (preg_match("/feedsportal.com/", $entry->getAttribute("src"))) {
                        $entry->parentNode->removeChild($entry);
                    } else if (preg_match("/feedsportal.com/", $entry->getAttribute("href"))) {
                        $entry->parentNode->removeChild($entry);
                    }
                }

                $article["content"] = $doc->saveHTML();

        }

        return $article;
    }

    public function api_version() {
        return 2;
    }

}