ExpressionMatcher::match() - Code Metrics - coduo/php-matcher - Measure and Improve Code Quality continuously with Scrutinizer

ExpressionMatcher::match() A
last analyzed 2016-10-20 19:57 UTC

↳ Parent: ExpressionMatcher

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	2

<?php

namespace Coduo\PHPMatcher\Matcher;

use Coduo\ToString\StringConverter;
use Symfony\Component\ExpressionLanguage\ExpressionLanguage;

final class ExpressionMatcher extends Matcher
{
    const MATCH_PATTERN = "/^expr\((.*?)\)$/";

    /**
     * {@inheritDoc}
     */
    public function match($value, $pattern)
    {
        $language = new ExpressionLanguage();
        preg_match(self::MATCH_PATTERN, $pattern, $matches);
        $expressionResult = $language->evaluate($matches[1], array('value' => $value));

        if (!$expressionResult) {

            $this->error = sprintf("\"%s\" expression fails for value \"%s\".", $pattern, new StringConverter($value));
        }

        return (bool) $expressionResult;
    }

    /**
     * {@inheritDoc}
     */
    public function canMatch($pattern)
    {
        return is_string($pattern) && 0 !== preg_match(self::MATCH_PATTERN, $pattern);
    }
}


1			<?php
2
3			namespace Coduo\PHPMatcher\Matcher;
4
5			use Coduo\ToString\StringConverter;
6			use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
7
8			final class ExpressionMatcher extends Matcher
9			{
10			const MATCH_PATTERN = "/^expr\((.*?)\)$/";
11
12			/**
13			* {@inheritDoc}
14			*/
15			public function match($value, $pattern)
16			{
17			$language = new ExpressionLanguage();
18			preg_match(self::MATCH_PATTERN, $pattern, $matches);
19			$expressionResult = $language->evaluate($matches[1], array('value' => $value));
20
21			if (!$expressionResult) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-13 13:07 UTC by Report Bug Copy Issue Report The expression `$expressionResult` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
22			$this->error = sprintf("\"%s\" expression fails for value \"%s\".", $pattern, new StringConverter($value));
23			}
24
25			return (bool) $expressionResult;
26			}
27
28			/**
29			* {@inheritDoc}
30			*/
31			public function canMatch($pattern)
32			{
33			return is_string($pattern) && 0 !== preg_match(self::MATCH_PATTERN, $pattern);
34			}
35			}
36

coduo / php-matcher

GitHub Access Token became invalid

ExpressionMatcher::match() A last analyzed 2016-10-20 19:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ExpressionMatcher::match() A
last analyzed 2016-10-20 19:57 UTC