| Conditions | 15 |
| Paths | 15 |
| Total Lines | 55 |
| Code Lines | 32 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 57 | protected function getType(&$value) |
||
| 58 | { |
||
| 59 | $type = self::T_NONE; |
||
| 60 | |||
| 61 | if (')' === $value) { |
||
| 62 | return self::T_CLOSE_PARENTHESIS; |
||
| 63 | } |
||
| 64 | if ('{' === $value) { |
||
| 65 | return self::T_OPEN_CURLY_BRACE; |
||
| 66 | } |
||
| 67 | if ('}' === $value) { |
||
| 68 | return self::T_CLOSE_CURLY_BRACE; |
||
| 69 | } |
||
| 70 | if (':' === $value) { |
||
| 71 | return self::T_COLON; |
||
| 72 | } |
||
| 73 | if (',' === $value) { |
||
| 74 | return self::T_COMMA; |
||
| 75 | } |
||
| 76 | |||
| 77 | if ($this->isTypePatternToken($value)) { |
||
| 78 | $value = trim($value, '@'); |
||
| 79 | return self::T_TYPE_PATTERN; |
||
| 80 | } |
||
| 81 | |||
| 82 | if ($this->isStringToken($value)) { |
||
| 83 | $value = $this->extractStringValue($value); |
||
| 84 | return self::T_STRING; |
||
| 85 | } |
||
| 86 | |||
| 87 | if ($this->isBooleanToken($value)) { |
||
| 88 | $value = (strtolower($value) === 'true') ? true : false; |
||
| 89 | return self::T_BOOLEAN; |
||
| 90 | } |
||
| 91 | |||
| 92 | if ($this->isNullToken($value)) { |
||
| 93 | $value = null; |
||
| 94 | return self::T_NULL; |
||
| 95 | } |
||
| 96 | |||
| 97 | if (is_numeric($value)) { |
||
| 98 | if (is_string($value)) { |
||
| 99 | $value = (strpos($value, '.') === false) ? (int) $value : (float) $value; |
||
| 100 | } |
||
| 101 | |||
| 102 | return self::T_NUMBER; |
||
| 103 | } |
||
| 104 | |||
| 105 | if ($this->isExpanderNameToken($value)) { |
||
| 106 | $value = rtrim(ltrim($value, '.'), '('); |
||
| 107 | return self::T_EXPANDER_NAME; |
||
| 108 | } |
||
| 109 | |||
| 110 | return $type; |
||
| 111 | } |
||
| 112 | |||
| 167 |